Split uvm(9)

2019-12-05 Thread Martin Pieuchot
Diff below split uvm(9) into the following: - uvm_init(9) - uvm_fault(9) - uvm_km_alloc(9) - uvm_map(9) - uvm_pagealloc(9) - uvn_attach(9) That will allow us to work on smaller pages and improve the overall documentation of UVM. This split doesn't include changes. Ok? Index: Makefile

Re: Split uvm(9)

2019-12-05 Thread Jason McIntyre
On Thu, Dec 05, 2019 at 01:55:00PM +0100, Martin Pieuchot wrote: > Diff below split uvm(9) into the following: > > - uvm_init(9) > - uvm_fault(9) > - uvm_km_alloc(9) > - uvm_map(9) > - uvm_pagealloc(9) > - uvn_attach(9) > > That will allow us to work on smaller pages and improve the overall >

Re: Split uvm(9)

2019-12-05 Thread Theo de Raadt
Jason McIntyre wrote: > > + uvn_attach.9 \ > > uv*m*_attach nope, it is correct. uvm object to vnode attach.

Re: Split uvm(9)

2019-12-05 Thread Jason McIntyre
On Thu, Dec 05, 2019 at 06:06:55AM -0700, Theo de Raadt wrote: > Jason McIntyre wrote: > > > > + uvn_attach.9 \ > > > > uv*m*_attach > > nope, it is correct. uvm object to vnode attach. > oops, sorry!

login_passwd: reject challenge service

2019-12-05 Thread Lindner, Thomas 1. (Nokia - DE/Nuremberg)
Hi, I read https://www.openwall.com/lists/oss-security/2019/12/04/5 and wondered how the authentication bypass was possible, since the manpage says: If this style of authentication does not support challenge response, but does support the response service (described below) it should

Re: .Aq in smtpd.conf(5)

2019-12-05 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Thu, Dec 05, 2019 at 06:54:28AM -0700: > CVSROOT: /cvs > Module name: src > Changes by: j...@cvs.openbsd.org2019/12/05 06:54:28 > > Modified files: > usr.sbin/smtpd : smtpd.conf.5 > > Log message: > replace "Pf < ... Ns >" with Aq; tidy up

Re: Split uvm(9)

2019-12-05 Thread Ingo Schwarze
Hi Martin, Martin Pieuchot wrote on Thu, Dec 05, 2019 at 01:55:00PM +0100: > Diff below split uvm(9) into the following: > > - uvm_init(9) > - uvm_fault(9) > - uvm_km_alloc(9) > - uvm_map(9) > - uvm_pagealloc(9) > - uvn_attach(9) Yes please! In particular, i like how this reduces usage of .nr

Re: .Aq in smtpd.conf(5)

2019-12-05 Thread Jason McIntyre
On Thu, Dec 05, 2019 at 03:15:31PM +0100, Ingo Schwarze wrote: > Hi Jason, > > Jason McIntyre wrote on Thu, Dec 05, 2019 at 06:54:28AM -0700: > > > CVSROOT:/cvs > > Module name:src > > Changes by: j...@cvs.openbsd.org2019/12/05 06:54:28 > > > > Modified files: > >

Re: un-boolean_t i386's pmap

2019-12-05 Thread Martin Pieuchot
On 05/12/19(Thu) 11:57, Otto Moerbeek wrote: > On Thu, Dec 05, 2019 at 12:38:34PM +0100, Martin Pieuchot wrote: > > > ok? > > I'm no kernel hacker but I really do not see the point. Most of the kernel doesn't use any type for boolean. The exception is UVM which uses its own boolean_t. This

Re: un-boolean_t i386's pmap

2019-12-05 Thread Otto Moerbeek
On Thu, Dec 05, 2019 at 04:12:01PM +0100, Martin Pieuchot wrote: > On 05/12/19(Thu) 11:57, Otto Moerbeek wrote: > > On Thu, Dec 05, 2019 at 12:38:34PM +0100, Martin Pieuchot wrote: > > > > > ok? > > > > I'm no kernel hacker but I really do not see the point. > > Most of the kernel doesn't use

Re: .Aq in smtpd.conf(5)

2019-12-05 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Thu, Dec 05, 2019 at 02:54:20PM +: > i have reverted it, with a heavy heart. Do you think i should try and convince the groff folks to always render .Aq/.Ao/.Ac as ASCII '<' and '>', even in UTF-8, HTML, PDF output and the like? Benefits: + easier rules

Re: .Aq in smtpd.conf(5)

2019-12-05 Thread gilles
December 5, 2019 4:34 PM, "Ingo Schwarze" wrote: > Hi Jason, > > Jason McIntyre wrote on Thu, Dec 05, 2019 at 02:54:20PM +: > >> i have reverted it, with a heavy heart. > > Do you think i should try and convince the groff folks to always > render .Aq/.Ao/.Ac as ASCII '<' and '>', even in

Re: .Aq in smtpd.conf(5)

2019-12-05 Thread Jason McIntyre
On Thu, Dec 05, 2019 at 04:34:50PM +0100, Ingo Schwarze wrote: > Hi Jason, > > Jason McIntyre wrote on Thu, Dec 05, 2019 at 02:54:20PM +: > > > i have reverted it, with a heavy heart. > > Do you think i should try and convince the groff folks to always > render .Aq/.Ao/.Ac as ASCII '<' and

iked(8): fix erroneous responder certreqs with multiple policies

2019-12-05 Thread Tobias Heider
We send certificate request (CERTREQ) payloads to notify the peer which CAs or public key schemes we accept in the authentication. Our current behaviour is incorrect when multiple policies between the same two hosts use different kinds of raw public key authentication. At this point of the

Sync KVE_ET_* with UVM_ET_*

2019-12-05 Thread Martin Pieuchot
Sync with reality, will help KERN_PROC_VMMAP consumers. Ok? Index: sys/sysctl.h === RCS file: /cvs/src/sys/sys/sysctl.h,v retrieving revision 1.196 diff -u -p -r1.196 sysctl.h --- sys/sysctl.h22 Oct 2019 21:19:22 -

uvm/uvm_map.h cleanup

2019-12-05 Thread Martin Pieuchot
Following cleanup diff: - reduces gratuitous differences with NetBSD, - merges multiple '#ifdef _KERNEL' blocks, - kills unused 'struct vm_map_intrsafe' - turns 'union vm_map_object' into a anonymous union (following to NetBSD) - move questionable vm_map_modflags() into uvm/uvm_map.c - remove

vm.conf: owner: do not default to root

2019-12-05 Thread Klemens Nanni
vm.conf(5) states it must be `owner user[:group]' or `owner group', not specifying a value is undocumented and ought to be invalid syntax, yet `owner' is treated as `owner root' which is the same as simply omitting the owner line. Diff below causes the following behaviour change: $ cat

Fix cross references in {MD5,SHA1,RMD160}Init.3

2019-12-05 Thread Martin
Hey! Some cross references in the {MD5,SHA1,RMD160}Init(3) pages are misspelled. Best, Martin Index: MD5Init.3 === RCS file: /cvs/src/lib/libc/hash/MD5Init.3,v retrieving revision 1.1 diff -u -p -r1.1 MD5Init.3 --- MD5Init.3 30

[PATCH] correcting in-sane ntpd.conf

2019-12-05 Thread List
Hello, here a diff replacing www.google.com as a default time constraint by www.openbsd.org. It is claimed that OpenBSD would have sane and secure defaults. While www.google.com might be secure it ain't sane from a privacy concerned perspective. Therefore the diff. Regards, Stephan Index:

Re: Fix cross references in {MD5,SHA1,RMD160}Init.3

2019-12-05 Thread Jason McIntyre
On Thu, Dec 05, 2019 at 10:18:14PM +0100, Martin wrote: > Hey! > > Some cross references in the {MD5,SHA1,RMD160}Init(3) pages are > misspelled. > > Best, > > Martin > fixed, thanks. jmc > Index: MD5Init.3 > === > RCS file:

Re: [PATCH] correcting in-sane ntpd.conf

2019-12-05 Thread Theo de Raadt
I guess you don't understand what is going on there. List wrote: > Hello, > > here a diff replacing www.google.com as a default time constraint by > www.openbsd.org. > It is claimed that OpenBSD would have sane and secure defaults. While > www.google.com might be secure it ain't sane from a

OpenSSH Feature Request

2019-12-05 Thread Tareq Saif
Hello, After reviewing the source code available at the below URL I believe the '-N' flag does not have an ssh_config counterpart. Can this be added? Is it something I can add? https://github.com/openssh/openssh-portable/blob/a70d92f236576c032a45c39e68ca0d71e958d19d/ssh.c Tareq Saif *Computer

Re: massage tcpdump ip and encapsulation output

2019-12-05 Thread David Gwynne
> On 5 Dec 2019, at 21:14, Sebastian Benoit wrote: > > Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.05 09:53:49 +0100: >> I would suggest to just pack most of the headers into one group of (). >> >> IPv4 ttl 1 [tos 0x20] 10.0.127.15 > 10.0.127.1 >> would become >> IPv4 (ttl 1 tos 0x20)

Re: Sync KVE_ET_* with UVM_ET_*

2019-12-05 Thread Philip Guenther
On Thu, Dec 5, 2019 at 9:15 AM Martin Pieuchot wrote: > Sync with reality, will help KERN_PROC_VMMAP consumers. Ok? > ok guenther@

Re: massage tcpdump ip and encapsulation output

2019-12-05 Thread David Gwynne
On Fri, Dec 06, 2019 at 03:14:42PM +1000, David Gwynne wrote: > > > > On 5 Dec 2019, at 21:14, Sebastian Benoit wrote: > > > > Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.05 09:53:49 +0100: > >> I would suggest to just pack most of the headers into one group of (). > >> > >> IPv4 ttl 1

Re: massage tcpdump ip and encapsulation output

2019-12-05 Thread Claudio Jeker
On Tue, Dec 03, 2019 at 10:00:01PM +1000, David Gwynne wrote: > this is a significant reworking of tcpdump with a couple of goals > twisted together. > > it is becoming increasingly common to encapsulate protocols, leading > to situations where you have some kind of ip packet inside another > ip

Re: un-boolean_t i386's pmap

2019-12-05 Thread Otto Moerbeek
On Thu, Dec 05, 2019 at 12:38:34PM +0100, Martin Pieuchot wrote: > ok? I'm no kernel hacker but I really do not see the point. boolean_t helps to see if a functions is supposed to return a boolean instead of an error code. I hate reading a function and having to guess if 0 is supposed to mean

Re: ftp(1): https:// handling with NOSSL

2019-12-05 Thread Jeremie Courreges-Anglas
On Wed, Dec 04 2019, Jeremie Courreges-Anglas wrote: > ftp(1) built with no TLS support is confused (confusing?) when handled > an https url. I have noticed this during tests with > /usr/src/distrib/special/ftp. > > Now: > --8<-- > ritchie /usr/src/distrib/special/ftp$ obj/ftp -o/dev/null >

Infinite sleeps in sys/uvm

2019-12-05 Thread Martin Pieuchot
Convert them to {m,t}sleep_nsec(9), ok? Index: uvm/uvm_device.c === RCS file: /cvs/src/sys/uvm/uvm_device.c,v retrieving revision 1.56 diff -u -p -r1.56 uvm_device.c --- uvm/uvm_device.c18 Jul 2019 23:47:33 - 1.56 +++

Re: massage tcpdump ip and encapsulation output

2019-12-05 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.05 09:53:49 +0100: > I would suggest to just pack most of the headers into one group of (). > > IPv4 ttl 1 [tos 0x20] 10.0.127.15 > 10.0.127.1 > would become > IPv4 (ttl 1 tos 0x20) 10.0.127.15 > 10.0.127.1 > and > IPv4 ttl 1 [tos 0x20] (id

Re: Does rpki-client need to unveil(NULL, NULL)?

2019-12-05 Thread Sebastian Benoit
ok George Brown(321.geo...@gmail.com) on 2019.12.04 18:57:17 +: > After pledge is immediately called without the unveil promise so this > seems redundant. > > diff --git a/usr.sbin/rpki-client/main.c b/usr.sbin/rpki-client/main.c > index f05ec1c5837..53ee4223371 100644 > ---

Re: [patch] ftp: improve SMALL and NOSSL #ifdefs

2019-12-05 Thread Jeremie Courreges-Anglas
On Wed, Nov 06 2019, Hiltjo Posthuma wrote: [...] > Thanks for reviewing the patch. Sadly I noticed and made a stupid mistake. > When > NOSSL is set, but SMALL is not set. It will set scheme = HTTPS_URL for the > file handler. > > Below is the full updated patch: I think we don't want to

Infinite sleeps in kern/vfs_*

2019-12-05 Thread Martin Pieuchot
Convert them to tsleep_nsec(9), ok? Index: kern/vfs_bio.c === RCS file: /cvs/src/sys/kern/vfs_bio.c,v retrieving revision 1.193 diff -u -p -r1.193 vfs_bio.c --- kern/vfs_bio.c 29 Nov 2019 01:04:08 - 1.193 +++

Re: ldomctl: Add create-vdisk command

2019-12-05 Thread Sebastian Benoit
Klemens Nanni(k...@openbsd.org) on 2019.11.30 01:44:48 +0100: > Just like on amd64 with vmctl(8), I want to be able to easily create > disk images. > > ldomctl(8) currently advises to use dd(1), those files are not sparse > either so creating big images may take a lot of time and the process >

un-boolean_t i386's pmap

2019-12-05 Thread Martin Pieuchot
ok? Index: i386/pmap.c === RCS file: /cvs/src/sys/arch/i386/i386/pmap.c,v retrieving revision 1.204 diff -u -p -r1.204 pmap.c --- i386/pmap.c 18 Jan 2019 01:34:50 - 1.204 +++ i386/pmap.c 5 Dec 2019 11:23:20 - @@ -403,7