Re: fix races in if_clone_create()

2020-07-13 Thread Vitaliy Makkoveev
On Mon, Jul 13, 2020 at 09:53:44AM +0200, Martin Pieuchot wrote: > On 06/07/20(Mon) 15:44, Vitaliy Makkoveev wrote: > > > On 6 Jul 2020, at 12:17, Martin Pieuchot wrote: > > > Assertions and documentation are more important than preventing races > > > because they allow to build awareness and

tmpfs bug in reclaim

2020-07-13 Thread Gerhard Roth
tmpfs_reclaim() has to make sure that the VFS cache has no more locks held for the vnode. Else vclean() could panic because v_holdcnt is non-zero. I know that tmpfs is disabled by default, but it would be nice to have this fix in the code base anyway. Gerhard Index: sys/tmpfs/tmpfs_vnops.c

Re: Add missing `IFXF_CLONED' to pseudo-interfaces

2020-07-13 Thread Vitaliy Makkoveev
ping? On Fri, Jul 10, 2020 at 02:59:55PM +0300, Vitaliy Makkoveev wrote: > Some pseudo interfaces have missing `IFXF_CLONED' flag. Diff below fixes > this. > > Index: sys/net/if_ppp.c > === > RCS file: /cvs/src/sys/net/if_ppp.c,v >

Use CPU_IS_PRIMARY macro in identifycpu() on i386

2020-07-13 Thread Frederic Cambus
Hi tech@, Here is a diff to use the CPU_IS_PRIMARY macro in identifycpu() on i386. Comments? OK? Index: sys/arch/i386/i386/machdep.c === RCS file: /cvs/src/sys/arch/i386/i386/machdep.c,v retrieving revision 1.636 diff -u -p -r1.636

Re: fix races in if_clone_create()

2020-07-13 Thread Vitaliy Makkoveev
On Mon, Jul 13, 2020 at 12:52:15PM +0300, Vitaliy Makkoveev wrote: > On Mon, Jul 13, 2020 at 09:53:44AM +0200, Martin Pieuchot wrote: > > On 06/07/20(Mon) 15:44, Vitaliy Makkoveev wrote: > > > > On 6 Jul 2020, at 12:17, Martin Pieuchot wrote: > > > > Assertions and documentation are more

[Patch] Make some functions static in httpd's server_fcgi.c

2020-07-13 Thread Ross L Richardson
Noticed when working on my next [more interesting] patch... Various functions could/should be static. Ross Index: server_fcgi.c === RCS file: /cvs/src/usr.sbin/httpd/server_fcgi.c,v retrieving revision 1.81 diff -u -p -r1.81

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-13 Thread Marcus Glocker
On Sat, 11 Jul 2020 23:43:43 +0200 Marcus Glocker wrote: > On Sat, 11 Jul 2020 20:14:03 +0200 > Marcus Glocker wrote: > > > On Sat, 11 Jul 2020 11:56:38 +0200 > > Marcus Glocker wrote: > > > > > On Fri, 10 Jul 2020 14:32:47 +0200 > > > Marcus Glocker wrote: > > > > > > > On Fri, 10

Re: fix races in if_clone_create()

2020-07-13 Thread Martin Pieuchot
On 06/07/20(Mon) 15:44, Vitaliy Makkoveev wrote: > > On 6 Jul 2020, at 12:17, Martin Pieuchot wrote: > > Assertions and documentation are more important than preventing races > > because they allow to build awareness and elegant solutions instead of > > hacking diffs until stuff work without

Re: wg: fix build without pf

2020-07-13 Thread Theo Buehler
On Sun, Jul 12, 2020 at 07:44:47PM +0200, Klemens Nanni wrote: > Feedback? OK? You need to have pf.h in scope to condition on NPF > 0. panic: kernel diagnostic assertion "m->m_ptheader.pf.statekey == NULL" failed: file "/usr/src/sys/net/pf.c" line 7455 Index: sys/net/if_wg.c

Re: timekeep: tk_generation problem

2020-07-13 Thread Paul Irofti
Hi, I am assuming you tested on amd64. Mind sharing the dmesg? Could this be due to the lack of RDTSC serialization in userland? Thank you for the report! Paul În 13 iulie 2020 06:44:57 EEST, George Koehler a scris: >Hello tech list, > >My CLOCK_MONOTONIC can jump backwards. It looks like

Re: pppac(4): fix races in pppacopen()

2020-07-13 Thread Martin Pieuchot
On 11/07/20(Sat) 23:51, Vitaliy Makkoveev wrote: > [...] > The way you suggest to go is to introduce rwlock and serialize > pppacopen() and pppacclose(). This is bad idea because we will sleep > while we are holding rwlock. That's the whole point of a rwlock to be able to sleep while holding the

Re: pppac(4): fix races in pppacopen()

2020-07-13 Thread Vitaliy Makkoveev
On Mon, Jul 13, 2020 at 09:39:38AM +0200, Martin Pieuchot wrote: > On 11/07/20(Sat) 23:51, Vitaliy Makkoveev wrote: > > [...] > > The way you suggest to go is to introduce rwlock and serialize > > pppacopen() and pppacclose(). This is bad idea because we will sleep > > while we are holding

[Patch] Be strict with fastcgi Status header

2020-07-13 Thread Ross L Richardson
The current code hides gross errors in the Status header generated by fastcgi applications: - Bogus codes are converted to 200. - The presence of multple Status headers is not reported as an error. IMHO, this doesn't really help anyone. The patch below attempts to address both these concerns.

Use CPU_IS_PRIMARY macro on alpha and mips64

2020-07-13 Thread Frederic Cambus
Hi tech@, Here is a diff to use the CPU_IS_PRIMARY macro on alpha and mips64. Comments? OK? Index: sys/arch/alpha/alpha/cpu.c === RCS file: /cvs/src/sys/arch/alpha/alpha/cpu.c,v retrieving revision 1.43 diff -u -p -r1.43 cpu.c ---

Add white temperature balance adjustability to video(1)

2020-07-13 Thread Laurence Tratt
This patch adds the ability to control the white balance temperature on webcams in video(1). This is bound to keys W/w in steps of +/-10K (because changing the temperature 1K at a time is tortuously slow given a typical range of 2800-6500K, and +/-10 seems to roughly be the minimum difference that

download site or stuff from sources with weak password

2020-07-13 Thread sven falempin
?(+([!@])@) is not very smart for something:something@ but i guess it is enough ? ( tabulation should be present below ) Index: ./distrib/miniroot/install.sub === RCS file: /cvs/src/distrib/miniroot/install.sub,v retrieving

Re: download site or stuff from sources with weak password

2020-07-13 Thread Theo de Raadt
The install script has never used all features of all commands hiding inside it, intentionally, because we don't want to maintain all the edge conditions. *OUR* install scripts are meant to reach to *OUR* distribution infrastructure, and *OUR* distribution infrastructure doesn't use usernames or

Re: disable libc sys wrappers?

2020-07-13 Thread Ted Unangst
On 2020-07-09, Theo de Raadt wrote: > > Added a -T option to ktrace for transparency. I got ambitious here and made > > it take suboptions, anticipating that other transparency modifications may > > be desired. > > Please don't do that. Here is a simpler version. Index: lib/libc/dlfcn/init.c

Re: download site or stuff from sources with weak password

2020-07-13 Thread Theo de Raadt
I am sceptical of any need to support what you propose, especially when it isn't documented, and secondly when it is shitty, and outside the scope of the project. sven falempin wrote: > ?(+([!@])@) > > is not very smart for something:something@ > but i guess it is enough ? > > ( tabulation

Add ability to set control values with video(1)

2020-07-13 Thread Laurence Tratt
video(1) allows users to adjust controls such as brightness, saturation (etc.) depending on the input device in question. These values persist even after video(1) has quit, allowing you to e.g. increase the brightness of a webcam before connecting to a video call. However, the only way to adjust

UPgrading pkg to 6.7 missed a package

2020-07-13 Thread sven falempin
Readers, pkg_add -u failed to upgrade p5-DBD-MariaDB-1.2 to p5-DBD-MariaDB-1.21p0 p5-DBD-MariaDB-1.2 is previous released so maybe it is too old and my fault , but it is odd that pkg_add -u p5-DBD-MariaDB does nothing when p5-DBD-MariaDB-1.2 is in the package list and p5-DBD-MariaDB-1.21p0.tgz

Re: download site or stuff from sources with weak password

2020-07-13 Thread sven falempin
On Mon, Jul 13, 2020 at 2:38 PM Theo de Raadt wrote: > I am sceptical of any need to support what you propose, especially > when it isn't documented, and secondly when it is shitty, and > outside the scope of the project. > FTP(1) General Commands Manual

Re: timekeep: tk_generation problem

2020-07-13 Thread George Koehler
On Mon, 13 Jul 2020 10:24:49 +0300 Paul Irofti wrote: > I am assuming you tested on amd64. Mind sharing the dmesg? Could this be due > to the lack of RDTSC serialization in userland? I got the problem on my 4-core amd64 and on a 1-cpu macppc. Here's my amd64 dmesg. In my next mail, I will

pf: remove ptr_array from struct pf_ruleset

2020-07-13 Thread Klemens Nanni
Each ruleset's rules are stored in a TAILQ called `ptr' with `rcount' representing the number of rules in the ruleset; `ptr_array' points to an array of the same length: struct pf_ruleset { struct { ... struct {

Re: timekeep: tk_generation problem

2020-07-13 Thread George Koehler
On Mon, 13 Jul 2020 01:18:14 -0500 Scott Cheloha wrote: > To review, the update protocol is: > > 1. Set tk_generation to zero; the update has begun. > > 2. Memory barrier. The side effects of step (1) are "visible" to >other CPUs before those of step (3). > > 3. Update the other tk_*

Re: UPgrading pkg to 6.7 missed a package

2020-07-13 Thread Solene Rapenne
On Mon, 13 Jul 2020 15:39:39 -0400 sven falempin : > Readers, > > pkg_add -u > failed to upgrade > > p5-DBD-MariaDB-1.2 > to > p5-DBD-MariaDB-1.21p0 > > p5-DBD-MariaDB-1.2 is previous released so maybe it is too old and my fault > , but it is > odd that pkg_add -u p5-DBD-MariaDB does nothing

Re: ssh-keygen(1): -a is missing in SYNOPSIS and small wording change

2020-07-13 Thread Solene Rapenne
On Thu, 25 Jun 2020 18:02:23 +0100 Jason McIntyre : > On Thu, Jun 25, 2020 at 06:40:36PM +0200, Solene Rapenne wrote: > > I found that ssh-keygen(1) missed mention of -a flag in SYNOPSIS. > > > > i think this got accidently removed in -r1.184: > > remove single letter flags for moduli

Re: disable libc sys wrappers?

2020-07-13 Thread Theo de Raadt
Fine with me. Ted Unangst wrote: > On 2020-07-09, Theo de Raadt wrote: > > > Added a -T option to ktrace for transparency. I got ambitious here and > > > made > > > it take suboptions, anticipating that other transparency modifications may > > > be desired. > > > > Please don't do that. > >

pfkeyv2: add sizes to free() calls

2020-07-13 Thread Klemens Nanni
There are more, but these ones are obvious as the size is already used to clear the buffers' contents beforehand. Feedback? OK? Index: sys/net/pfkeyv2.c === RCS file: /cvs/src/sys/net/pfkeyv2.c,v retrieving revision 1.200 diff -u -p

Re: pppac(4): fix races in pppacopen()

2020-07-13 Thread Vitaliy Makkoveev
Forget please about previous diff. Except ac_ioctl() the only function which can have race with pppacclose() is pppacopen(), but since `sc' is still linked to `pppac_devs' list we can't reopen dying `sc'. So the only race is pppacopen() vs pppacopen(). We only need to malloc(9) before

Re: ssh-keygen(1): -a is missing in SYNOPSIS and small wording change

2020-07-13 Thread Jason McIntyre
On Mon, Jul 13, 2020 at 10:36:45PM +0200, Solene Rapenne wrote: > On Thu, 25 Jun 2020 18:02:23 +0100 > Jason McIntyre : > > > On Thu, Jun 25, 2020 at 06:40:36PM +0200, Solene Rapenne wrote: > > > I found that ssh-keygen(1) missed mention of -a flag in SYNOPSIS. > > > > > > > i think this got

Re: timekeep: tk_generation problem

2020-07-13 Thread Scott Cheloha
On Sun, Jul 12, 2020 at 11:44:57PM -0400, George Koehler wrote: > Hello tech list, > > My CLOCK_MONOTONIC can jump backwards. I can reproduce it here. Very unsettling. > It looks like a problem with tk_generation in the user timekeep page. > If tk_offset_count and tk_offset change but