Re: switch: allow datapath_id and maxflow ioctls for non-root

2020-07-30 Thread Klemens Nanni
On Fri, Jul 31, 2020 at 06:28:32AM +0200, Klemens Nanni wrote: > ifconfig(8) detects switch(4) through its unique SIOCSWSDPID ioctl and > further does another switch specific ioctl for the default output > regardless of configuration and/or members: > > SIOCSWSDPID struct ifbrparam >

Re: pipex(4): kill pipexintr()

2020-07-30 Thread YASUOKA Masahiko
On Thu, 30 Jul 2020 22:43:10 +0300 Vitaliy Makkoveev wrote: > On Thu, Jul 30, 2020 at 10:05:13PM +0900, YASUOKA Masahiko wrote: >> On Thu, 30 Jul 2020 15:34:09 +0300 >> Vitaliy Makkoveev wrote: >> > On Thu, Jul 30, 2020 at 09:13:46PM +0900, YASUOKA Masahiko wrote: >> >> If the diff removes the

switch: allow datapath_id and maxflow ioctls for non-root

2020-07-30 Thread Klemens Nanni
ifconfig(8) detects switch(4) through its unique SIOCSWSDPID ioctl and further does another switch specific ioctl for the default output regardless of configuration and/or members: SIOCSWSDPID struct ifbrparam Set the datapath_id in the OpenFlow protocol of the switch

cat(1): add more restrictive pledge(2)

2020-07-30 Thread tempmail42
I have to say I'm only a beginner to C but hopefully my patch is good. This patch adds a second and more restrictive pledge (only "stdio" instead of "stdio rpath") after the getopt loop if there is no input file or if the input file is "-" (stdin) or a sequence of repeated instances of "-". It

Re: pipex(4): kill pipexintr()

2020-07-30 Thread YASUOKA Masahiko
On Thu, 30 Jul 2020 22:43:10 +0300 Vitaliy Makkoveev wrote: > On Thu, Jul 30, 2020 at 10:05:13PM +0900, YASUOKA Masahiko wrote: >> On Thu, 30 Jul 2020 15:34:09 +0300 >> Vitaliy Makkoveev wrote: >> > On Thu, Jul 30, 2020 at 09:13:46PM +0900, YASUOKA Masahiko wrote: >> >> Hi, >> >> >> >>

Re: pipex(4): kill pipexintr()

2020-07-30 Thread Vitaliy Makkoveev
On Thu, Jul 30, 2020 at 10:05:13PM +0900, YASUOKA Masahiko wrote: > On Thu, 30 Jul 2020 15:34:09 +0300 > Vitaliy Makkoveev wrote: > > On Thu, Jul 30, 2020 at 09:13:46PM +0900, YASUOKA Masahiko wrote: > >> Hi, > >> > >> sys/net/if_ethersubr.c: > >> 372 void > >> 373 ether_input(struct ifnet *ifp,

Re: Improve ure(4) performance

2020-07-30 Thread Mikolaj Kucharski
On Thu, Jul 30, 2020 at 07:58:23AM -0700, Jonathon Fletcher wrote: > > Mikolaj, > > I hope the patch has been stable for you. I do have an update - it appears > that a splx(s) got lost along the way (from the end of ure_txeof). This > patch adds that back in and has some minor cleanup (variable

Re: Improve ure(4) performance

2020-07-30 Thread Jonathon Fletcher
On Mon, Jul 27, 2020 at 07:13:33PM +, Mikolaj Kucharski wrote: > On Mon, Jul 27, 2020 at 11:58:02AM -0700, Jonathon Fletcher wrote: > > > > Are you ok using patch's -l option for this patch? > > > > Sure, can do. New kernel compiled, will switch my machine tonight. Will > let you know how

dhclient requested ip address in decline message

2020-07-30 Thread Schreilechner, Dominik
Hi, If the dhclient receives an OFFER or ACK, that does not contain all required parameters, a DECLINE is send. This DECLINE has the 'Requested IP Address' (DHO_DHCP_REQUESTET_ADDRESS) set to 0 instead of using the client IP address (yiaddr) from the packet. As far as I see it, the 'Requested

Re: pipex(4): kill pipexintr()

2020-07-30 Thread YASUOKA Masahiko
On Thu, 30 Jul 2020 15:34:09 +0300 Vitaliy Makkoveev wrote: > On Thu, Jul 30, 2020 at 09:13:46PM +0900, YASUOKA Masahiko wrote: >> Hi, >> >> sys/net/if_ethersubr.c: >> 372 void >> 373 ether_input(struct ifnet *ifp, struct mbuf *m) >> (snip) >> 519 #if NPPPOE > 0 || defined(PIPEX) >> 520

Re: pipex(4): kill pipexintr()

2020-07-30 Thread Vitaliy Makkoveev
On Thu, Jul 30, 2020 at 09:13:46PM +0900, YASUOKA Masahiko wrote: > Hi, > > sys/net/if_ethersubr.c: > 372 void > 373 ether_input(struct ifnet *ifp, struct mbuf *m) > (snip) > 519 #if NPPPOE > 0 || defined(PIPEX) > 520 case ETHERTYPE_PPPOEDISC: > 521 case ETHERTYPE_PPPOE: > 522

Re: pipex(4): kill pipexintr()

2020-07-30 Thread YASUOKA Masahiko
Hi, sys/net/if_ethersubr.c: 372 void 373 ether_input(struct ifnet *ifp, struct mbuf *m) (snip) 519 #if NPPPOE > 0 || defined(PIPEX) 520 case ETHERTYPE_PPPOEDISC: 521 case ETHERTYPE_PPPOE: 522 if (m->m_flags & (M_MCAST | M_BCAST)) 523 goto

Re: VFS vgone(l) manpage vs. code

2020-07-30 Thread Schreilechner, Dominik
> From: Jason McIntyre, Mittwoch, 29. Juli 2020 14:23 > > On Wed, Jul 29, 2020 at 11:37:03AM +, Schreilechner, Dominik wrote: > > Hi, > > > > I noticed, that the description of vgone/vgonel in the manpage does not > > match the \ > > code. The manpage (https://man.openbsd.org/vgone) states: >

Re: Add ability to set control values with video(1)

2020-07-30 Thread Marcus Glocker
Hi Laurie, Thanks for testing and feedback! On Thu, 30 Jul 2020 08:07:56 +0100 Laurence Tratt wrote: > On Wed, Jul 29, 2020 at 10:52:31PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > Slightly adapted diff; Negative numbers can happen on controls. > > This looks really good to me,

Re: pipex(4): kill pipexintr()

2020-07-30 Thread Martin Pieuchot
On 29/07/20(Wed) 23:04, Vitaliy Makkoveev wrote: > Now pipex(4) is fully covered by NET_LOCK() and this is documented. But > we still have an issue with pipex(4) session itself and I guess it's > time to fix it. > > We have `pipexinq' and `pipexoutq' mbuf(9) queues to store mbufs. Each > mbuf(9)

Re: rdomain.4: route -T takes an rtable, not rdomain

2020-07-30 Thread Remi Locherer
On Thu, Jul 30, 2020 at 04:08:01AM +0200, Klemens Nanni wrote: > Multiple rtables may exist in the default rdomain (0), that is their > corresponding rdomains/lo(4) interfaces do not have to exist. > > This demonstrates it; first, nothing but default, so route(8) fails: > > # netstat -R >

Re: Add ability to set control values with video(1)

2020-07-30 Thread Laurence Tratt
On Wed, Jul 29, 2020 at 10:52:31PM +0200, Marcus Glocker wrote: Hello Marcus, > Slightly adapted diff; Negative numbers can happen on controls. This looks really good to me, and a significant improvement on my original. I've tested everything I can think of and it all looks good, with one mild