process: annotate locking for setitimer(2) state

2020-08-08 Thread Scott Cheloha
Hi, I want to annotate the locking for the per-process interval timers. In the process struct, the ITIMER_REAL itimerspec and the ps_itimer_to timeout are protected by the kernel lock. These should be annotated with "K", right? Also in the process struct, the ITIMER_VIRTUAL and ITIMER_PROF

Re: describe 'idle-timeout' exception in npppd.conf man page

2020-08-08 Thread YASUOKA Masahiko
On Sat, 8 Aug 2020 16:01:59 +0300 Vitaliy Makkoveev wrote: > On Sat, Aug 08, 2020 at 08:49:24PM +0900, YASUOKA Masahiko wrote: >> On Fri, 7 Aug 2020 22:19:05 +0300 >> Vitaliy Makkoveev wrote: >> > Some times ago we disabled in-kernel timeout for pppx(4) related >> > pipex(4) sessions. We did

Re: vether(4): move `ifnet' out of KERNEL_LOCK()

2020-08-08 Thread Klemens Nanni
On Sun, Aug 09, 2020 at 03:16:50AM +0300, Vitaliy Makkoveev wrote: > vether(4) is pretty dummy. Nothing denies it to be `IFXF_MPSAFE'. OK kn

vether(4): move `ifnet' out of KERNEL_LOCK()

2020-08-08 Thread Vitaliy Makkoveev
vether(4) is pretty dummy. Nothing denies it to be `IFXF_MPSAFE'. Index: sys/net/if_vether.c === RCS file: /cvs/src/sys/net/if_vether.c,v retrieving revision 1.33 diff -u -p -r1.33 if_vether.c --- sys/net/if_vether.c 28 Jul 2020

Re: video -c: showing auto white balance temperature

2020-08-08 Thread Marcus Glocker
Hello Laurie, On Sat, 8 Aug 2020 21:56:08 +0100 Laurence Tratt wrote: > On Sat, Aug 08, 2020 at 09:30:18PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > >> I like your patch, which is better than my original! My only very > >> minor comment is whether we might want to document that it's

Re: video -c: showing auto white balance temperature

2020-08-08 Thread Laurence Tratt
On Sat, Aug 08, 2020 at 09:30:18PM +0200, Marcus Glocker wrote: Hello Marcus, >> I like your patch, which is better than my original! My only very minor >> comment is whether we might want to document that it's safe to put "0" in >> a "V4L2_CID_AUTO" settings, since the lowest value one of those

Re: pms(4): disable parity checking for specific elantech fw

2020-08-08 Thread Marcus Glocker
On Sat, 08 Aug 2020 17:08:01 +0200 sxv...@firemail.cc wrote: > So I recently installed OpenBSD on an EeePC 900HD with an Elantech v1 > touchpad (fw_version 0x20022). > This specific fw version for some reason sends inverted parity bits > on a cold boot, returning to normal after suspend & resume.

pms(4): disable parity checking for specific elantech fw

2020-08-08 Thread sxvghd
So I recently installed OpenBSD on an EeePC 900HD with an Elantech v1 touchpad (fw_version 0x20022). This specific fw version for some reason sends inverted parity bits on a cold boot, returning to normal after suspend & resume. That leads to a failed parity check, dropped packets and ultimately

Re: video -c: showing auto white balance temperature

2020-08-08 Thread Marcus Glocker
On Sat, 8 Aug 2020 15:13:47 +0100 Laurence Tratt wrote: > On Sat, Aug 08, 2020 at 02:45:16PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > For now how about adding the according auto control id to our > > dev_ctrls structure? In a next step we could change > >

Re: $pexp in re.subr(8)

2020-08-08 Thread _
Stuart Henderson writes: > This means that the regular expression must match the full process > string. Equivalent to providing an expression with ^ at the start and > $ at the end of the. I see, so the documentation is already correct, sorry, and thanks for the explanation.

Re: describe 'idle-timeout' exception in npppd.conf man page

2020-08-08 Thread Vitaliy Makkoveev
I did audit for "idle-timeout" option. On Sat, Aug 08, 2020 at 08:49:24PM +0900, YASUOKA Masahiko wrote: > On Fri, 7 Aug 2020 22:19:05 +0300 > Vitaliy Makkoveev wrote: > > Some times ago we disabled in-kernel timeout for pppx(4) related > > pipex(4) sessions. We did this for prevent use after

Re: video -c: showing auto white balance temperature

2020-08-08 Thread Laurence Tratt
On Sat, Aug 08, 2020 at 02:45:16PM +0200, Marcus Glocker wrote: Hello Marcus, > For now how about adding the according auto control id to our dev_ctrls > structure? In a next step we could change > dev_set_ctrl_auto_white_balance() to become a generic function > dev_set_ctrl_auto() available

Re: pppac(4) move ifnet out of KERNEL_LOCK()

2020-08-08 Thread Vitaliy Makkoveev
Another update. The whole "while ((m = ifq_dequeue(ifq)) != NULL)" wrapped by netlock as it was made for pppx(4). This is to exclude per-packet lock/unlock in output path. Index: sys/net/if_pppx.c === RCS file:

Re: describe 'idle-timeout' exception in npppd.conf man page

2020-08-08 Thread Vitaliy Makkoveev
On Sat, Aug 08, 2020 at 08:49:24PM +0900, YASUOKA Masahiko wrote: > On Fri, 7 Aug 2020 22:19:05 +0300 > Vitaliy Makkoveev wrote: > > Some times ago we disabled in-kernel timeout for pppx(4) related > > pipex(4) sessions. We did this for prevent use after free issue caused > > by pipex_timer [1].

Re: video -c: showing auto white balance temperature

2020-08-08 Thread Marcus Glocker
Hello Laurie, On Wed, 5 Aug 2020 21:42:18 +0100 Laurence Tratt wrote: > Following Marcus's commit of video(1) changes, the attached patch > crudely solves the "-c output is misleading for > white_balance_temperature" because we conflate > auto_white_balance_temperature and

Re: brconfig: strto*l -> strtonum()

2020-08-08 Thread Todd C . Miller
On Sat, 08 Aug 2020 05:09:22 +0200, Klemens Nanni wrote: > Alternatively, we can avoid duplicating the ioctl specific min/max > values in strtonum(3) calls, just use the struct member type's *_MAX > defines and rely on the kernel for appropiate boundary checks - this is > what the code does now.

Re: describe 'idle-timeout' exception in npppd.conf man page

2020-08-08 Thread YASUOKA Masahiko
On Fri, 7 Aug 2020 22:19:05 +0300 Vitaliy Makkoveev wrote: > Some times ago we disabled in-kernel timeout for pppx(4) related > pipex(4) sessions. We did this for prevent use after free issue caused > by pipex_timer [1]. By default "idle-timeout" is not set in > npppd.conf(5) and I guess this is

Re: allow TCP connections to IPv6 anycast addresses

2020-08-08 Thread Jeremie Courreges-Anglas
On Sat, Aug 08 2020, Florian Obser wrote: > On Fri, Aug 07, 2020 at 11:52:46PM +0200, Jeremie Courreges-Anglas wrote: >> If you don't want to remove M_ACAST from sys/mbuf.h, can you please at >> least change the comment? /* obsolete */ or something. > > Good point, I forgot to ask about what to

Re: allow TCP connections to IPv6 anycast addresses

2020-08-08 Thread Florian Obser
On Fri, Aug 07, 2020 at 11:52:46PM +0200, Jeremie Courreges-Anglas wrote: > If you don't want to remove M_ACAST from sys/mbuf.h, can you please at > least change the comment? /* obsolete */ or something. Good point, I forgot to ask about what to do with the flag. I think we can remove it, from