Re: Diff: Introductory Clause Comma Crap

2020-10-31 Thread VARIK VALEFOR
Mr. GUENTHER: > As a procedural side-note, I would like to suggest that before going on a > quest to make a change that touches so many files cross OpenBSD's code > base, that it would be wise to send out a diff with just a couple examples > and verify that the particular item of concern and the

Re: powerpc ld.lld fix

2020-10-31 Thread Mark Kettenis
> Date: Sat, 10 Oct 2020 23:19:19 +0200 (CEST) > From: Mark Kettenis > > On powerpc with the secure-plt ABI we need a .got section, even if the > _GLOBAL_OFFSET_TABLE_ symbol isn't referenced. This is needed because > the first three entries of the GOT are used by the dynamic linker. > > With

Diff: Introductory Clause Comma Crap

2020-10-31 Thread VARIK VALEFOR
Sir or Madam: This message contains even more grammatical fixes for the OpenBSD manual pages. To ensure that the changes which are proposed in this message can be justified, this message primarily fixes only a single type of error: the absence of commas after introductory clauses. Unless

Re: Diff: Introductory Clause Comma Crap

2020-10-31 Thread Jason McIntyre
On Sat, Oct 31, 2020 at 03:14:30PM -0400, VARIK VALEFOR wrote: > Sir or Madam: > > This message contains even more grammatical fixes for the OpenBSD > manual pages. To ensure that the changes which are proposed in this > message can be justified, this message primarily fixes only a single > type

Re: Diff: Introductory Clause Comma Crap

2020-10-31 Thread Philip Guenther
On Sat, Oct 31, 2020 at 10:19 AM VARIK VALEFOR wrote: > This message contains even more grammatical fixes for the OpenBSD > manual pages. To ensure that the changes which are proposed in this > message can be justified, this message primarily fixes only a single > type of error: the absence of

Fix ilogb(3)

2020-10-31 Thread Mark Kettenis
As reported on bugs@ our ilogb(3) implementation is somewhat buggy. There are several issues: - The amd64 and i386 assembler versions not only return results that don't match the FP_ILOGB0 and FP_ILOGBNAN defines in but ultimately return results that are incompatible with C99 and C11. -

Re: [PATCH] wireguard: release correct lock on exceptional case

2020-10-31 Thread Jasper Lievisse Adriaanse
On Sat, Oct 31, 2020 at 03:03:10PM +0100, Jason A. Donenfeld wrote: > Backtrace from Jesper: > > ddb{0}> show panic > noise_keypair: lock not held > ddb{0}> trace > db_enter() at db_enter+0x10 > panic(81db9b58) at panic+0x12a > rw_exit_write(8801ed10) at rw_exit_write+0xb5 >

[PATCH] wireguard: release correct lock on exceptional case

2020-10-31 Thread Jason A. Donenfeld
Backtrace from Jesper: ddb{0}> show panic noise_keypair: lock not held ddb{0}> trace db_enter() at db_enter+0x10 panic(81db9b58) at panic+0x12a rw_exit_write(8801ed10) at rw_exit_write+0xb5 noise_remote_begin_session(8801ec10) at noise_remote_begin_session+0x3c 1