Re: uvm_fault: Kill goto Case2

2020-11-13 Thread Theo Buehler
On Fri, Nov 13, 2020 at 12:04:23PM -0300, Martin Pieuchot wrote: > Another simple refactoring of uvm_fault() removing a goto, ok? ok tb

Re: uvm_pagealloc() & uvm.free accounting

2020-11-13 Thread Mark Kettenis
> Date: Fri, 13 Nov 2020 11:38:33 -0300 > From: Martin Pieuchot > > The uvmexp.free* variables are read in uvm_pagealloc() & uvm_pglistalloc() > before grabbing the `fpageqlock'. > > `uvmexp.free' is always modified by the pmemrange allocator under the > above motioned lock. To avoid races and

unwind(8): handle large answers differently

2020-11-13 Thread Florian Obser
The recent fix for handling large (about 16k) answers in unwind has the downside that we are now always copying at least 16k per answer between the resolver and frontend process. That seems wasteful. This re-arranges things to only copy what its needed. Tests, OKs? diff --git frontend.c

uvm_fault: Kill goto Case2

2020-11-13 Thread Martin Pieuchot
Another simple refactoring of uvm_fault() removing a goto, ok? Index: uvm/uvm_fault.c === RCS file: /cvs/src/sys/uvm/uvm_fault.c,v retrieving revision 1.106 diff -u -p -r1.106 uvm_fault.c --- uvm/uvm_fault.c 13 Nov 2020 14:18:25

uvm_pagealloc() & uvm.free accounting

2020-11-13 Thread Martin Pieuchot
The uvmexp.free* variables are read in uvm_pagealloc() & uvm_pglistalloc() before grabbing the `fpageqlock'. `uvmexp.free' is always modified by the pmemrange allocator under the above motioned lock. To avoid races and the chances of missing a wakeup, the diff below move the checks inside the

Re: uvm_fault: is there an anon?

2020-11-13 Thread Mark Kettenis
> Date: Fri, 13 Nov 2020 08:19:03 -0300 > From: Martin Pieuchot > > On 04/11/20(Wed) 11:04, Martin Pieuchot wrote: > > Diff below introduces a helper that looks for existing mapping. The > > value returned by this lookup function determines if there's an anon > > at the faulting address which

Re: Strange snmpd issue with 6.7

2020-11-13 Thread Stuart Henderson
Moving this to tech@. Not an answer but here's some more information. misc thread archived at https://marc.info/?t=16046954722=1=2 but I think the important bits are all in quotes in this mail anyway. On 2020/11/12 20:35, Winfred Harrelson wrote: > On Thu, Nov 12, 2020 at 09:51:46AM -,

Re: uvm_fault: is there an anon?

2020-11-13 Thread Jonathan Matthew
On Fri, Nov 13, 2020 at 12:17:04PM +0100, Theo Buehler wrote: > On Wed, Nov 04, 2020 at 11:04:12AM -0300, Martin Pieuchot wrote: > > Diff below introduces a helper that looks for existing mapping. The > > value returned by this lookup function determines if there's an anon > > at the faulting

Re: uvm_fault: is there an anon?

2020-11-13 Thread Martin Pieuchot
On 04/11/20(Wed) 11:04, Martin Pieuchot wrote: > Diff below introduces a helper that looks for existing mapping. The > value returned by this lookup function determines if there's an anon > at the faulting address which tells us if we're dealign with a fault > of type 1 or 2. > > This small

Re: uvm_fault: is there an anon?

2020-11-13 Thread Theo Buehler
On Wed, Nov 04, 2020 at 11:04:12AM -0300, Martin Pieuchot wrote: > Diff below introduces a helper that looks for existing mapping. The > value returned by this lookup function determines if there's an anon > at the faulting address which tells us if we're dealign with a fault > of type 1 or 2. >

[PATCH]: Clearer documentation when using EVFILT_EXCEPT

2020-11-13 Thread Emil Engler
Currently it isn't mentioned that a socket is required when using EVFILT_EXCEPT with NOTE_OOB. To some experienced users it might be clear that it must be a socket but I don't think an additional word would hurt anyone. Index: lib/libc/sys/kqueue.2