Re: bgpd pftable change

2020-11-14 Thread David Gwynne
I've been using this for a week or so now and it's been very boring, which is an improvement in my experience. I has my ok if that has any value. dlg > On 9 Nov 2020, at 8:16 pm, Claudio Jeker wrote: > > Hi bgpd and esp. bgpd-spamd users, > > Currently the pftable code does not keep track ho

Re: Convert sysctl_sysvsem to sysctl_bounded_args

2020-11-14 Thread Greg Steuck
Greg Steuck writes: > I went a tiny bit beyond pure textual conversion and moved a bit of > code. Testing log for giggles: % doas sysctl -w kern.seminfo.semmnu=30 kern.seminfo.semmnu: 30 -> 30 % doas sysctl -w kern.seminfo.semmnu=29 sysctl: kern.seminfo.semmnu: Invalid argument % doas sysctl -w

Convert sysctl_sysvsem to sysctl_bounded_args

2020-11-14 Thread Greg Steuck
I went a tiny bit beyond pure textual conversion and moved a bit of code. OK? >From d8ace6480e76e948631a40bcb8fa812366b82384 Mon Sep 17 00:00:00 2001 From: Greg Steuck Date: Sat, 14 Nov 2020 20:55:14 -0800 Subject: [PATCH 3/3] Convert sysctl_sysvsem to sysctl_bounded_args Used sysctl_int_bounde

Remove the cases folded into sysctl_bounded_args but left behind

2020-11-14 Thread Greg Steuck
This an "oops" moment... The code remained correct, but I forgot to remove junk after converting it. >From 68a12efd641c4fc5f75ac693bf7ed7487948e0dd Mon Sep 17 00:00:00 2001 From: Greg Steuck Date: Sat, 14 Nov 2020 16:12:50 -0800 Subject: [PATCH 2/3] Remove the cases folded into sysctl_bounded_arg

Convert fusefs_sysctl to sysctl_bounded_args

2020-11-14 Thread Greg Steuck
This is trivial more-of-the-same. If somebody spots a bug, do speak up. I feel pretty good about committing this promptly. >From f34f5853d7b8f58c677850766353fc72cb9ae5b8 Mon Sep 17 00:00:00 2001 From: Greg Steuck Date: Sat, 14 Nov 2020 16:00:53 -0800 Subject: [PATCH 1/3] Convert fusefs_sysctl to

Re: [PATCH] remove variable names from prototypes in sys_pipe.c

2020-11-14 Thread Sebastian Benoit
henkjan gersen(h.ger...@gmail.com) on 2020.11.14 19:00:15 +: > OK, no problem it just looked strange when reading the code as most > definitions in that file don't have them. > > btw) I'm by now way more puzzled why this file has a function to create a pipe > > struct pipe_pair *pipe_pair_cre

Re: [PATCH] remove variable names from prototypes in sys_pipe.c

2020-11-14 Thread henkjan gersen
OK, no problem it just looked strange when reading the code as most definitions in that file don't have them. btw) I'm by now way more puzzled why this file has a function to create a pipe struct pipe_pair *pipe_pair_create(void); but lacks a corresponding destroy function. This makes it look li

Re: [PATCH] remove variable names from prototypes in sys_pipe.c

2020-11-14 Thread Theo de Raadt
I don't see the point of this. Yes, style(9) says don't do that. It is because of cpp issues. It definately matters for userland-exposed definitions. But the kernel is largely immune to this concern, even in .h files Sice this is on one file, it matters even less since nothing in any .h file wil

[PATCH] remove variable names from prototypes in sys_pipe.c

2020-11-14 Thread henkjan gersen
Patch below removes a couple of variable names from function prototypes in sys_pipe.c to match style(9) --- diff --git sys/kern/sys_pipe.c sys/kern/sys_pipe.c index 04ec907d21f..85e69af7741 100644 --- sys/kern/sys_pipe.c +++ sys/kern/sys_pipe.c @@ -62,9 +62,9 @@ int pipe_read(struct file *, stru

[patch] remove if-clause that is always true from kern_time.c

2020-11-14 Thread henkjan gersen
kern_time.c contains an if-clause that also appears in the NetBSD source that is always true and hence has no effect. The patch below cleans this up assuming the wrap-around protection should remain in place (FreeBSD just wraps). The patch itself is purely cosmetic and shouldn't affect the compile

dt: add kernel function boundary tracing provider

2020-11-14 Thread Tom Rollet
Hi, Here is a diff for dynamic tracing of kernel's functions boundaries. It's implemented as one of the dt's provider on i386 and amd64. To activate it, DDBPROF and pseudo device dt must be activated on GENERIC. For now it's working like DTRACE fbt(function boundaries tracing). We replace the p

Re: [PATCH]: Clearer documentation when using EVFILT_EXCEPT

2020-11-14 Thread Jason McIntyre
On Fri, Nov 13, 2020 at 11:50:09AM +0100, Emil Engler wrote: > Currently it isn't mentioned that a socket is required when using > EVFILT_EXCEPT with NOTE_OOB. To some experienced users it might be clear > that it must be a socket but I don't think an additional word would hurt > anyone. > com