Re: pppoe: input without kernel lock

2021-01-03 Thread Klemens Nanni
On Wed, Dec 30, 2020 at 01:10:33AM +0300, Vitaliy Makkoveev wrote: > For me these if_{get,put}(9) dances are useless. This `ph_ifidx’ is > related to ethernet device and used to find pppoe(4) related software > context. pppoe_send_padt() will get this `ifp’ as `eth_if’ by itself > and correctly

Re: pf route-to issues

2021-01-03 Thread Alexander Bluhm
On Sun, Jan 03, 2021 at 06:56:20PM +0100, Alexander Bluhm wrote: > I am currently running a full regress to find more fallout. These regress tests fail: sys/net/pf_forward sys/net/pf_fragment sbin/pfctl The first two are easy to fix. That means my tests using route-to work fine with your diff.

Re: pf route-to issues

2021-01-03 Thread Alexander Bluhm
On Sun, Jan 03, 2021 at 02:00:00PM +1000, David Gwynne wrote: > On Tue, Oct 20, 2020 at 09:27:09AM +1000, David Gwynne wrote: > We've been running this diff in production for the last couple of > months, and it's been solid for us so far. Ignoring the fixes for > crashes, I personally find it a

Re: libc/regex: turn unsafe macros to inline functions

2021-01-03 Thread Theo Buehler
On Sun, Jan 03, 2021 at 04:45:30PM +, Miod Vallat wrote: > > Is there a reason not to do > > > > return (cs->ptr[(uch)c] & cs->mask) != 0; > > > > This would allow us to get rid of the !! construct in regcomp.c > > Why not. What about that? Thanks. Here's the diff rebased on top of

Re: acme-client(1): backup certs

2021-01-03 Thread Sebastian Benoit
ok Florian Obser(flor...@openbsd.org) on 2021.01.02 17:23:11 +0100: > > Create .1 backup files when acme-client is going to overwrite a > certificate file. > > This files are not terribly big and it's convenient to keep one > previous file around for example if one adds or removes domains to

Re: pipex(4): remove unused `pipex_iface_context' struct

2021-01-03 Thread Klemens Nanni
OK kn

Re: compress sparc64 bsd.rd

2021-01-03 Thread Kurt Mosiejczuk
On Wed, Dec 30, 2020 at 08:37:49PM +, Miod Vallat wrote: > Up until 6.5, sparc64 bsd.rd were gzipped kernels. This got lost during > the Great Installation Media Unification of the 6.6 release cycle, and > since then bsd.rd are uncompressed. > The following diff ought to fix this and bring

Re: libc/regex: safer pointer arithmetic

2021-01-03 Thread Miod Vallat
> regcomp.c uses the "start + count < end" idiom to check that there are > "count" bytes available in an array of char "start" and "end" both point > to. > > This is fine, unless "start + count" goes beyond the last element of the > array. In this case, pedantic interpretation of the C standard

Re: acme-client(1): backup certs

2021-01-03 Thread Chris Bennett
On Sun, Jan 03, 2021 at 11:16:00AM +, Stuart Henderson wrote: > What are you thinking would be stolen? The certificates themselves > are public knowledge anyway - they are sent in full whenever someone > connects to your TLS-based service and are available from Certificate > Transparency log

convert i386 fix_f00f() uvm_km_zalloc

2021-01-03 Thread Jonathan Matthew
I don't have a real 586, but I can tell qemu to pretend to be one, which at least executes this code. Using kd_waitok here seems suspect, because if we're out of memory this early I can't see anything else freeing any up, but uvm_km_zalloc() will also sleep rather than return failure. Should this

Re: convert i386 fix_f00f() uvm_km_zalloc

2021-01-03 Thread Alexander Bluhm
On Mon, Jan 04, 2021 at 10:00:25AM +1000, Jonathan Matthew wrote: > I don't have a real 586, but I can tell qemu to pretend to be one, > which at least executes this code. You can run regress/sys/arch/i386/f00f/ . > Using kd_waitok here seems suspect, because if we're out of memory > this early

Re: libc/regex: turn unsafe macros to inline functions

2021-01-03 Thread Miod Vallat
> Is there a reason not to do > > return (cs->ptr[(uch)c] & cs->mask) != 0; > > This would allow us to get rid of the !! construct in regcomp.c Why not. What about that? Index: regcomp.c === RCS file:

Re: libc/regex: turn unsafe macros to inline functions

2021-01-03 Thread Todd C . Miller
On Sun, 03 Jan 2021 17:51:56 +0100, Theo Buehler wrote: > Thanks. Here's the diff rebased on top of -current. This is > > ok tb OK millert@ as well if you'd like to do the honors. - todd

Re: compress sparc64 bsd.rd

2021-01-03 Thread Kurt Mosiejczuk
On Sun, Jan 03, 2021 at 07:19:51PM +, Miod Vallat wrote: > > Since this change went in, bsd.rd doesn't boot unless I uncompress it first. > > upgrade detected: switching to /bsd.upgrade > > Trying /bsd.upgrade... > > NOTE: random seed is being reused. > > Booting

Re: pppoe: input without kernel lock

2021-01-03 Thread Vitaliy Makkoveev
ok mvs@ > On 4 Jan 2021, at 00:23, Klemens Nanni wrote: > > On Wed, Dec 30, 2020 at 01:10:33AM +0300, Vitaliy Makkoveev wrote: >> For me these if_{get,put}(9) dances are useless. This `ph_ifidx’ is >> related to ethernet device and used to find pppoe(4) related software >> context.

libc/regex: drop debug helpers

2021-01-03 Thread Miod Vallat
regex(3) documents non-standard extensions REG_ITOA and REG_ATOI to regerror(). In the OpenBSD tree, the only use of them is by the regress test, so why not move that specific code to the regress test and shrink libc a bit - remember that this code is present in the installation media through

Re: compress sparc64 bsd.rd

2021-01-03 Thread Miod Vallat
> > Rebooting with command: boot bsd.rd.gz > > This is interesting. The change has it just being named bsd.rd, without the > .gz. That's just me testing a compressed bsd.rd.

Re: snmp - remove BER_TYPE_BOOLEAN

2021-01-03 Thread Martijn van Duren
ping On Mon, 2020-12-14 at 12:13 +0100, Martijn van Duren wrote: > I can't find any reference in RFC2578 for a boolean type, nor have I > seen it in the wild and the TruthValue diff I just committed give me a > strong indication that this was added without any real reason. > > OK to remove? > >

pipex(4): remove unused `pipex_iface_context' struct

2021-01-03 Thread Vitaliy Makkoveev
Index: sys/net/pipex.h === RCS file: /cvs/src/sys/net/pipex.h,v retrieving revision 1.29 diff -u -p -r1.29 pipex.h --- sys/net/pipex.h 2 Jan 2021 13:15:15 - 1.29 +++ sys/net/pipex.h 3 Jan 2021 20:10:47 - @@

Re: compress sparc64 bsd.rd

2021-01-03 Thread Miod Vallat
> Since this change went in, bsd.rd doesn't boot unless I uncompress it first. > > upgrade detected: switching to /bsd.upgrade > Trying /bsd.upgrade... > NOTE: random seed is being reused. > Booting /pci@400/pci@2/pci@0/pci@c/nvme@0/disk@1:a/bsd.upgrade >

Re: pppoe: input without kernel lock

2021-01-03 Thread Klemens Nanni
On Tue, Dec 29, 2020 at 11:18:26PM +0100, Claudio Jeker wrote: > Generally I would prefer to go for direct dispatch and not use netisr. > This removes a queue and a scheduling point and should help reduce the > latency in processing pppoe packages. > > This does not mean that I'm against this

Re: pf route-to issues

2021-01-03 Thread David Gwynne
On Sun, Jan 03, 2021 at 06:56:20PM +0100, Alexander Bluhm wrote: > On Sun, Jan 03, 2021 at 02:00:00PM +1000, David Gwynne wrote: > > On Tue, Oct 20, 2020 at 09:27:09AM +1000, David Gwynne wrote: > > We've been running this diff in production for the last couple of > > months, and it's been solid

Re: pf route-to issues

2021-01-03 Thread David Gwynne
On Mon, Jan 04, 2021 at 12:58:17AM +0100, Alexander Bluhm wrote: > On Sun, Jan 03, 2021 at 06:56:20PM +0100, Alexander Bluhm wrote: > > I am currently running a full regress to find more fallout. > > These regress tests fail: > > sys/net/pf_forward > sys/net/pf_fragment > sbin/pfctl > > The

Re: Port httpd(8) 'strip' directive to relayd(8)

2021-01-03 Thread Denis Fondras
Le Fri, Dec 11, 2020 at 10:53:56AM +, Olivier Cherrier a écrit : > > Hello tech@, > > Is there any interest for this feature to be commited? > I find it very useful. Thank you Denis! > Here is an up to date diff, looking for OKs. Index: parse.y

snmpd(8) make traphandler more secure

2021-01-03 Thread Martijn van Duren
Right now snmpd's traphandler_parse and traphandler_v1translate are just weird to me and do very little ASN1 checking. Since I want to remove the traphandler process anyway and the current code structue is in the way, this diff is a logical first step towards that goal. The new

Re: acme-client(1): backup certs

2021-01-03 Thread Stuart Henderson
On 2021/01/02 17:10, Chris Bennett wrote: > On Sat, Jan 02, 2021 at 05:23:11PM +0100, Florian Obser wrote: > > > > Create .1 backup files when acme-client is going to overwrite a > > certificate file. > > > > This files are not terribly big and it's convenient to keep one > > previous file

Re: [PATCH] faq13, Using a Webcam

2021-01-03 Thread Stefan Hagen
Stefan Hagen wrote: > If there are new developments, like a video group or a sysctl video.record > knob, I'll send delta patches to describe the behavior. I've updated the patch to cover the kern.video.record knob. I also used # instead of $ doas in code blocks. Index: faq/faq13.html

Re: Thread local data setup and destruct

2021-01-03 Thread Otto Moerbeek
On Thu, Dec 31, 2020 at 05:54:06PM +0100, Alexander Bluhm wrote: > On Tue, Dec 29, 2020 at 04:07:19PM +0100, Otto Moerbeek wrote: > > This workds better, checking the flags does not work if the thread is > > already on the road to desctruction. > > This diff survived a full regress run on amd64.