On Sat, Feb 06, 2021 at 08:26:35PM +1300, richard.n.proc...@gmail.com wrote:
> I'm ok with your latest diff as-is. I prefer a slightly different
> direction, see below, but not enough to object.
I have commited my diff as is. It is better if you expess your
arguments yourself in the comment
> On 6 Feb 2021, at 15:23, Alexander Bluhm wrote:
>
> On Sat, Feb 06, 2021 at 05:04:20PM +1000, David Gwynne wrote:
>> refcnt_init starts counting at 1, while the existing code starts at 0. Do
>> the crashes stop because we never fully release all the references and
>> never free it now?
>
>
On Sat, Feb 06, 2021 at 01:23:35AM +0100, Jeremie Courreges-Anglas wrote:
> On Fri, Jan 29 2021, Florian Obser wrote:
> > Last piece of the puzzle...
> >
> > Re-try to open DNSSEC trust anchor file if /var is not mounted yet.
> > With this we are able to start unwind before the network is up and
On Sat, Feb 06, 2021 at 05:04:20PM +1000, David Gwynne wrote:
> refcnt_init starts counting at 1, while the existing code starts at 0. Do
> the crashes stop because we never fully release all the references and
> never free it now?
You are absolutely right. I was too optimistic.
Correct diff is
On Sat, Feb 06, 2021 at 05:58:35PM +0300, Vitaliy Makkoveev wrote:
> I???m not sure it should be atomic. It seems groups require their own
> lock and this lock should be held while we perform if_addgroup() and
> if_delgroup().
I also think that atomic refcounting is not needed here. But it
does
On Sat, Feb 06, 2021 at 04:44:08PM +0100, Alexander Bluhm wrote:
> Or should we go with a self crafted ++ -- refcounting?
This would look like this, also fine with me. kasserts are also in
refcnt_... API.
ok?
bluhm
Index: net/if.c
Christian Weisgerber:
> Make use of getline(3) in ftp(1).
>
> Replace fparseln(3) with getline(3). This removes the only use
> of libutil.a(fparseln.o) from the ramdisk.
> Replace a complicated fgetln(3) idiom with the much simpler getline(3).
New diff that fixes a bug I introduced in cookie
I noticed that sometimes DNS64 detection is not working correctly on
boot. Eventually I tracked it down to this:
Feb 6 08:56:22 x1 unwind[7139]: check_dns64_done: bad packet: too short: -1
The problem is that we are checking for dns64 while we might not yet
have a route to the nameserver
On Sat, Feb 06 2021, Florian Obser wrote:
> On Sat, Feb 06, 2021 at 01:23:35AM +0100, Jeremie Courreges-Anglas wrote:
>> On Fri, Jan 29 2021, Florian Obser wrote:
>> > Last piece of the puzzle...
>> >
>> > Re-try to open DNSSEC trust anchor file if /var is not mounted yet.
>> > With this we are
