Re: iked(8): make proto option accept lists

2021-09-03 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2021.09.03 11:32:42 +0200: > On 2021-09-03 10:38 +02, Claudio Jeker wrote: > > On Fri, Sep 03, 2021 at 10:12:57AM +0200, Sebastian Benoit wrote: > >> Tobias Heider(tobias.hei...@stusta.de) on 2021.09.02 15:39:46 +0200: > >> > +; > >> > + > >>

mark getsubopt(3) as part of POSIX

2021-09-03 Thread Theo Buehler
Found this in my tree. Our version of getsubopt matches NetBSD's up to some DIAGASSERTs and they do mention POSIX in their manual, so I suspect we inherited the specified behavior. I copied the phrasing used for other functions, but haven't checked in detail. Index: stdlib/getsubopt.3

Re: riscv64 ptrace(2) tweaks

2021-09-03 Thread Jeremie Courreges-Anglas
On Fri, Sep 03 2021, Mark Kettenis wrote: >> From: Jeremie Courreges-Anglas >> Date: Fri, 03 Sep 2021 14:32:26 +0200 >> >> Two changes that would be useful: >> - enable PT_*FPREGS, Mark has already done the job. >> - hide PT_STEP since hardware support seems missing (the spec only talks >>

Re: mark getsubopt(3) as part of POSIX

2021-09-03 Thread Todd C . Miller
On Fri, 03 Sep 2021 14:40:34 +0200, Theo Buehler wrote: > Found this in my tree. Our version of getsubopt matches NetBSD's up to > some DIAGASSERTs and they do mention POSIX in their manual, so I suspect > we inherited the specified behavior. I copied the phrasing used for > other functions, but

Re: iked(8): make proto option accept lists

2021-09-03 Thread Tobias Heider
On Fri, Sep 03, 2021 at 10:12:57AM +0200, Sebastian Benoit wrote: > Tobias Heider(tobias.hei...@stusta.de) on 2021.09.02 15:39:46 +0200: > > The diff below makes iked accept a list of protocols for the "proto" config > > option in iked.conf(5). > > This would allow us to have a single policy with

Re: mark getsubopt(3) as part of POSIX

2021-09-03 Thread Jason McIntyre
On Fri, Sep 03, 2021 at 02:40:34PM +0200, Theo Buehler wrote: > Found this in my tree. Our version of getsubopt matches NetBSD's up to > some DIAGASSERTs and they do mention POSIX in their manual, so I suspect > we inherited the specified behavior. I copied the phrasing used for > other functions,

riscv64 ptrace(2) tweaks

2021-09-03 Thread Jeremie Courreges-Anglas
Two changes that would be useful: - enable PT_*FPREGS, Mark has already done the job. - hide PT_STEP since hardware support seems missing (the spec only talks about single stepping support in "Debug mode", which is not "Machine" or "Supervisor" mode). Since we don't emulate it (like mips64

remove libdmx from Xenocara?

2021-09-03 Thread Matthieu Herrb
Hi, is anyone here using libdmx from Xenocara? Afaict, with the help of sqlports no port/package is using it, and it's also not used by anything built in xenocara. libdmx is the client part of the Xdmx system (distributed multi-screen X server, that make it possible to create a huge screen out

Re: iwm/iwx suspend/resume improvement

2021-09-03 Thread Uwe Werler
On 02 Sep 15:26, Stefan Sperling wrote: > This patch fixes suspend/resume with an AX201 device for gnezdo@. > Tests on any iwm/iwx device would be apreciated. > > Before testing this make sure to update your tree to -current which contains > a very recent fix for a double-free in the resume path

Re: timeout: Prettify man page and usage

2021-09-03 Thread Jason McIntyre
On Fri, Sep 03, 2021 at 03:42:21PM +0200, Ingo Schwarze wrote: > Hi, > > Theo de Raadt wrote on Thu, Sep 02, 2021 at 09:57:11AM -0600: > > > I think we should list shorts, and longs which have no shorts. > > I agree, and i think we arrived at the same conclusion in the past. > > It applies to

riscv64/trap.c debug printfs

2021-09-03 Thread Jeremie Courreges-Anglas
This one is a bit too chatty whenever you run a program under egdb. But the other printfs in this file seem ok, thus I'm not touching them. ok? Index: trap.c === RCS file: /d/cvs/src/sys/arch/riscv64/riscv64/trap.c,v retrieving

Re: riscv64/trap.c debug printfs

2021-09-03 Thread Mike Larkin
On Fri, Sep 03, 2021 at 04:38:55PM +0200, Jeremie Courreges-Anglas wrote: > > This one is a bit too chatty whenever you run a program under egdb. > But the other printfs in this file seem ok, thus I'm not touching them. > > ok? > > > Index: trap.c >

syslogd NUL string

2021-09-03 Thread Alexander Bluhm
Hi, I could not convince myself that the strings passed to printline() and parsepriority() are always NUL terminated. Better safe than sorry and force a '\0' there. ok? bluhm Index: usr.sbin/syslogd/syslogd.c === RCS file:

new gpioleds driver

2021-09-03 Thread Klemens Nanni
Here is a tiny driver enabling machines such as the Pinebook Pro to indicate power, it is intentionally minimal and does not expose anything via sysctl(8)/sensorsd(8) or gpioctl(8). This is helpful for machines where graphics, keyboard and/or serial console have problems and people tend to debug

Re: riscv64 ptrace(2) tweaks

2021-09-03 Thread Mark Kettenis
> From: Jeremie Courreges-Anglas > Date: Fri, 03 Sep 2021 14:32:26 +0200 > > Two changes that would be useful: > - enable PT_*FPREGS, Mark has already done the job. > - hide PT_STEP since hardware support seems missing (the spec only talks > about single stepping support in "Debug mode", which

Re: timeout: Prettify man page and usage

2021-09-03 Thread Ingo Schwarze
Hi, Theo de Raadt wrote on Thu, Sep 02, 2021 at 09:57:11AM -0600: > I think we should list shorts, and longs which have no shorts. I agree, and i think we arrived at the same conclusion in the past. It applies to both usage() and SYNOPSIS, and ideally, both should match, except maybe in very

Re: mark getsubopt(3) as part of POSIX

2021-09-03 Thread Ingo Schwarze
Hi Theo, as you sent it, your patch is misleading since our manual page describes two features that are not required by POSIX. So i propose the larger patch shown below instead. While here, clarify what "null-terminated" means. It matters for this page in particular because the page talks

Re: new gpioleds driver

2021-09-03 Thread Tomasz Bielecki
On Fri, Sep 3, 2021 at 8:18 AM Klemens Nanni wrote: > > Here is a tiny driver enabling machines such as the Pinebook Pro to > indicate power, it is intentionally minimal and does not expose anything > via sysctl(8)/sensorsd(8) or gpioctl(8). > > This is helpful for machines where graphics,

Re: mark getsubopt(3) as part of POSIX

2021-09-03 Thread Todd C . Miller
On Fri, 03 Sep 2021 16:51:06 +0200, Ingo Schwarze wrote: > So i propose the larger patch shown below instead. Also OK millert@ - todd

syslogd iovcnt

2021-09-03 Thread Alexander Bluhm
Hi, Use a define for the iov array size in syslogd. This is better than passing the magic number 6 around and checking at runtime whether its fits. ok? bluhm Index: usr.sbin/syslogd/syslogd.c === RCS file:

Re: [Patch] Document /upgrade.site in sysupgrade(8) man page

2021-09-03 Thread Florian Obser
I'd like to see this documented, I didn't know about it and now I'm using it on all my systems. I don't have an opinion *where* it should be documented. On 2021-09-02 10:18 -05, Aaron Poffenberger wrote: > Any further thoughts on this patch to the man page? > > Cheers, > > --Aaron > > On

Re: mark getsubopt(3) as part of POSIX

2021-09-03 Thread Theo Buehler
On Fri, Sep 03, 2021 at 04:51:06PM +0200, Ingo Schwarze wrote: > Hi Theo, > > as you sent it, your patch is misleading since our manual page describes > two features that are not required by POSIX. > > So i propose the larger patch shown below instead. > > While here, clarify what

Re: syslogd iovcnt

2021-09-03 Thread Vitaliy Makkoveev
ok mvs@ > On 3 Sep 2021, at 19:04, Alexander Bluhm wrote: > > Hi, > > Use a define for the iov array size in syslogd. This is better > than passing the magic number 6 around and checking at runtime > whether its fits. > > ok? > > bluhm > > Index: usr.sbin/syslogd/syslogd.c >

syslogd iov output

2021-09-03 Thread Alexander Bluhm
Hi, When writing a message, syslogd did a combination of putting everything into an iov and do some sprintf() formating later. Better put evering into the iov upfront based on what the output methods need. Then either the full iov is written or a line is created by concatenating. This will

Re: new gpioleds driver

2021-09-03 Thread Klemens Nanni
On Fri, Sep 03, 2021 at 01:14:04PM -0700, Tomasz Bielecki wrote: > Just a quick confirmation that this works fine. I'm running -current > with a bunch of local patches to get the fb console, reset and power > off working on Pinebook Pro and with patched u-boot 2021.10-rc1 this > makes the led turn

Re: iked(8): make proto option accept lists

2021-09-03 Thread Sebastian Benoit
Tobias Heider(tobias.hei...@stusta.de) on 2021.09.02 15:39:46 +0200: > The diff below makes iked accept a list of protocols for the "proto" config > option in iked.conf(5). > This would allow us to have a single policy with "proto { ipencap, ipv6 }" > to secure a gif(4) tunnel, instead of

Re: iked(8): make proto option accept lists

2021-09-03 Thread Claudio Jeker
On Fri, Sep 03, 2021 at 10:12:57AM +0200, Sebastian Benoit wrote: > Tobias Heider(tobias.hei...@stusta.de) on 2021.09.02 15:39:46 +0200: > > The diff below makes iked accept a list of protocols for the "proto" config > > option in iked.conf(5). > > This would allow us to have a single policy with

Re: rm.1: remove extraneous word

2021-09-03 Thread Jason McIntyre
On Thu, Sep 02, 2021 at 11:10:54PM +0100, Jason McIntyre wrote: > On Thu, Sep 02, 2021 at 02:28:54PM -0700, Evan Silberman wrote: > > Speaking of the first sentence of rm(1): > > > > Remove extraneous word from command description > > > > "non-directory files" reads more naturally and means the

Re: rm.1: remove extraneous word

2021-09-03 Thread Theo de Raadt
Unix has these things called hard links. As such, rm deletes a directory entry pointing to an inode which stores a file, but other directory entries could point at the same file. Introducing people to this vaguely is nice, so I thikn this should keep saying 'directory entries'. >On Thu, Sep

Re: route(1): add an address family validation

2021-09-03 Thread morimoto
> I don't think the entry is pointless. There are setups where nexthop of > different address family do make sense. Things like rfc5549 can do > IPv4 over IPv6 Core. In some cases this is used for network autodiscovery > (using IPv6 link-local addresses as nexthops). I didn't understand them. As

Re: pmap & buffer cache dummy pagers

2021-09-03 Thread Mark Kettenis
> Date: Thu, 2 Sep 2021 22:16:52 +0200 > From: Martin Pieuchot > > Diff below introduces two dummy pagers for subsystem that manipulate UVM > objects that are 'special'. Those pagers will be used to enforce checks > in functions that expect a lock to be held, like: > > KASSERT(obj ==

Re: iked(8): make proto option accept lists

2021-09-03 Thread Florian Obser
On 2021-09-03 10:38 +02, Claudio Jeker wrote: > On Fri, Sep 03, 2021 at 10:12:57AM +0200, Sebastian Benoit wrote: >> Tobias Heider(tobias.hei...@stusta.de) on 2021.09.02 15:39:46 +0200: >> > + ; >> > + >> > +proto_list: protoval { $$ = $1; } >> > + |

Re: rm.1: remove extraneous word

2021-09-03 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Fri, Sep 03, 2021 at 07:47:19AM +0100: > On Thu, Sep 02, 2021 at 11:10:54PM +0100, Jason McIntyre wrote: >> i wonder if it was originally an attempt to not quote posix >> (or posix attempting to not quote bsd). posix refers to removing >> "directory entries",