Fix a race in uvm_pseg_release()

2022-08-18 Thread Martin Pieuchot
The lock must be grabbed before iterating on the global array, ok? Index: uvm/uvm_pager.c === RCS file: /cvs/src/sys/uvm/uvm_pager.c,v retrieving revision 1.88 diff -u -p -r1.88 uvm_pager.c --- uvm/uvm_pager.c 15 Aug 2022

Re: bgpd more kroute cleanup

2022-08-18 Thread Theo Buehler
On Thu, Aug 18, 2022 at 12:44:07PM +0200, Claudio Jeker wrote: > It makes no sense to pass the fd to send_rtmsg() as an argument. > The code just passes the fd from the global kr_state. It also makes the > code less portable because for linux an mnl handle needs to be passed. > By dropping this

installboot: clarify how -p only sets up the filesystem

2022-08-18 Thread Klemens Nanni
Contrary to the synopsis and verbose output, using -p Prepare filesystem. This will create a new filesystem on the partition reserved for the boot loader on architectures that require one. does only that: # installboot -nvp vnd0 Using / as

Re: pcidevs: PM991_NVME: add 980 name

2022-08-18 Thread Mark Kettenis
My understanding is that for the Samsung SSDs there are internal part numbers (PMxxx) and marketing names (SSD 980). So far we've used the internal part numbers in pcidevs, partly because not all parts show up as retails SSDs. Given that a 980 reference shows up in the firmware name that we

bgpd more kroute cleanup

2022-08-18 Thread Claudio Jeker
It makes no sense to pass the fd to send_rtmsg() as an argument. The code just passes the fd from the global kr_state. It also makes the code less portable because for linux an mnl handle needs to be passed. By dropping this the code becomes simpler. -- :wq Claudio Index: kroute.c

Re: Race in disk_attach_callback?

2022-08-18 Thread Klemens Nanni
On Tue, Aug 16, 2022 at 09:03:55PM +, Miod Vallat wrote: > > after a prompt from stsp@ and florian@, reporting that newfs_msdos > > fails when given an $duid.i argument, I set down to see what could be > > going on. My test using an USB stick failed to reprdouce the problem. > > Then I started

Simplify locking code in pdaemon

2022-08-18 Thread Martin Pieuchot
Use a "slock" variable as done in multiple places to simplify the code. The locking stay the same. This is just a first step to simplify this mess. Also get rid of the return value of the function, it is never checked. ok? Index: uvm/uvm_pdaemon.c

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-18 Thread Visa Hankala
On Wed, Aug 17, 2022 at 11:42:50AM -0500, Scott Cheloha wrote: > On Wed, Aug 17, 2022 at 01:30:29PM +, Visa Hankala wrote: > > On Tue, Aug 09, 2022 at 09:54:02AM -0500, Scott Cheloha wrote: > > > On Tue, Aug 09, 2022 at 02:03:31PM +, Visa Hankala wrote: > > > > On Mon, Aug 08, 2022 at

Re: rpki-client: disallow inherit in ROA EE IP Resources extension

2022-08-18 Thread Job Snijders
On Sat, Aug 13, 2022 at 04:51:05PM +0200, Theo Buehler wrote: > job mentioned that it might be preferable to do the validation in > parse_{roa,rsc,aspa}(). So here's a diff that does this. It reworks > valid_{roa,rsc}() to compare only against the EE cert's resources > since it doesn't really make

bgpd, uninitalised check in kroute_insert()

2022-08-18 Thread Claudio Jeker
Noticed while compling with gcc. In kroute_insert() the check for possible multipath routes is: if (krm == NULL) kr_redistribute(IMSG_NETWORK_ADD, kt, kf); The problem is krm is only set in the IPv4 path but not in the IPv6 one. The diff below fixes this by using a new

Re: installboot: clarify how -p only sets up the filesystem

2022-08-18 Thread Todd C . Miller
On Thu, 18 Aug 2022 11:51:19 -, Klemens Nanni wrote: > I've checked all usage combination of flags and arguments, the new code > does what the new synopsis says. I agree with the general direction but have one concern. See inline. - todd > Index: installboot.c >

Re: Fix a race in uvm_pseg_release()

2022-08-18 Thread Mike Larkin
On Thu, Aug 18, 2022 at 12:39:58PM +0200, Martin Pieuchot wrote: > The lock must be grabbed before iterating on the global array, ok? > > Index: uvm/uvm_pager.c > === > RCS file: /cvs/src/sys/uvm/uvm_pager.c,v > retrieving revision

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-18 Thread Visa Hankala
On Thu, Aug 18, 2022 at 02:33:55PM +, Miod Vallat wrote: > > After about 92 hours, one machine showed cp0_raise_calls=622486 and > > another 695892. cp0_raise_miss was zero on both of them. On two other > > machines I had forgotten to allow ddb access from console and could > > not check the

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-18 Thread Miod Vallat
> After about 92 hours, one machine showed cp0_raise_calls=622486 and > another 695892. cp0_raise_miss was zero on both of them. On two other > machines I had forgotten to allow ddb access from console and could > not check the values. Put kern.allowkmem=1 in /etc/sysctl.conf, and then you can do

Re: bgpd, uninitalised check in kroute_insert()

2022-08-18 Thread Theo Buehler
On Thu, Aug 18, 2022 at 03:22:50PM +0200, Claudio Jeker wrote: > Noticed while compling with gcc. In kroute_insert() the check for possible > multipath routes is: > if (krm == NULL) > kr_redistribute(IMSG_NETWORK_ADD, kt, kf); > > The problem is krm is only set in the IPv4

Re: [RFC] acpi: add acpitimer_delay(), acpihpet_delay()

2022-08-18 Thread Mike Larkin
On Wed, Aug 17, 2022 at 09:00:12PM +1000, Jonathan Gray wrote: > On Wed, Aug 17, 2022 at 04:53:20PM +1000, Jonathan Gray wrote: > > > > It seems to me it would be cleaner if the decision of what to use for > > delay could be moved into an md file. > > > > Or abstract it by having a numeric weight

dhcpleased.8: add lease files to FILES

2022-08-18 Thread Klemens Nanni
There is dhcpleasectl(8) -l but that only works for currently configured leases/interfaces and does not print all information contained in the lease file (mostly tailored to fit the installer's needs). Feedback? OK? Index: dhcpleased.8

Re: dhcpleased.8: add lease files to FILES

2022-08-18 Thread Jason McIntyre
On Thu, Aug 18, 2022 at 08:34:56PM +, Klemens Nanni wrote: > On Thu, Aug 18, 2022 at 08:53:51PM +0100, Jason McIntyre wrote: > > On Thu, Aug 18, 2022 at 07:29:42PM +, Klemens Nanni wrote: > > > There is dhcpleasectl(8) -l but that only works for currently > > > configured leases/interfaces

Re: installboot: clarify how -p only sets up the filesystem

2022-08-18 Thread Todd C . Miller
On Thu, 18 Aug 2022 18:53:41 -, Klemens Nanni wrote: > root is now initalised before the verbose check so it is independent of > -v usage and happens after prepare code, indicating that -p does not > care about -r. OK millert@ - todd

Re: dhcpleased.8: add lease files to FILES

2022-08-18 Thread Klemens Nanni
On Thu, Aug 18, 2022 at 08:53:51PM +0100, Jason McIntyre wrote: > On Thu, Aug 18, 2022 at 07:29:42PM +, Klemens Nanni wrote: > > There is dhcpleasectl(8) -l but that only works for currently > > configured leases/interfaces and does not print all information > > contained in the lease file

Re: ifconfig, wireguard output less verbose, unless -A or

2022-08-18 Thread Hrvoje Popovski
On 14.7.2022. 11:37, Mikolaj Kucharski wrote: > Hi, > > Per other thread, Theo expressed dissatisfaction with long ifconfig(8) > for wg(4) interface. Stuart Henderson pointed me at direction, which > below diff makes it work. > > I guess to questions are: > > - Does the behaviour of ifconfig(8)

Re: dhcpleased.8: add lease files to FILES

2022-08-18 Thread Jason McIntyre
On Thu, Aug 18, 2022 at 07:29:42PM +, Klemens Nanni wrote: > There is dhcpleasectl(8) -l but that only works for currently > configured leases/interfaces and does not print all information > contained in the lease file (mostly tailored to fit the installer's > needs). > > Feedback? OK? >

all architectures: put clockframe definition in frame.h?

2022-08-18 Thread Scott Cheloha
Hi, clockframe is sometimes defined in cpu.h, sometimes in frame.h, and sometimes defined once each in both header files. Can we put the clockframe definitions in frame.h? Always? It is, at least ostensibly, a "frame". I do not want to consolidate the clockframe definitions in cpu.h because

Re: Fix a race in uvm_pseg_release()

2022-08-18 Thread Jonathan Gray
On Thu, Aug 18, 2022 at 12:39:58PM +0200, Martin Pieuchot wrote: > The lock must be grabbed before iterating on the global array, ok? ok jsg@ > > Index: uvm/uvm_pager.c > === > RCS file: /cvs/src/sys/uvm/uvm_pager.c,v > retrieving

Re: installboot: clarify how -p only sets up the filesystem

2022-08-18 Thread Klemens Nanni
On Thu, Aug 18, 2022 at 11:05:52AM -0600, Todd C. Miller wrote: > On Thu, 18 Aug 2022 11:51:19 -, Klemens Nanni wrote: > > > I've checked all usage combination of flags and arguments, the new code > > does what the new synopsis says. > > I agree with the general direction but have one

Re: Race in disk_attach_callback?

2022-08-18 Thread Klemens Nanni
On Wed, Aug 17, 2022 at 07:03:50AM +, Miod Vallat wrote: > > What is the result if root runs disklabel, and forces it to all zeros? > > If the root duid is all zeroes, then the only way to refer to the root > disk is to use its /dev/{s,w}d* device name, as zero duids are ignored. I like