Attending Gitex ?

2022-10-27 Thread einvoicing
Dear Valued customer, I’ve been speaking to a lot of our customers and something I’ve been hearing consistently is that manual and paper-based processes continue to limit cost optimization efforts, decrease team productivity, and hold back growth. That’s why this Gitex, we’re partnering with

Re: [Patch] add minor clarification to Wireless in faq/faq6.html

2022-10-27 Thread tux2bsd
> On Thu, Oct 27, 2022 at 08:09:17AM +, tux2bsd wrote: > > > This patch is to add a brief note that 'nwid' > > & 'join' serve different purposes and which > > man page to consult. > > Stefan Sperling wrote: > The FAQ exists for people who want to read a > distilled version of the most

Re: Replace audio(9) get_props() with duplex check in open() for play-only drivers

2022-10-27 Thread Mark Kettenis
> Date: Thu, 27 Oct 2022 13:27:43 + > From: Klemens Nanni > > Make drivers which do *not* adverise AUDIO_PROP_FULLDPLEX return ENXIO > in their open() if full-duplex mode was requested. > > This way, sys/dev/audio.c:audio_open() will fail immediately rather than > later through the

Re: bgplgd show pid in more debug messages

2022-10-27 Thread Theo Buehler
On Thu, Oct 27, 2022 at 03:11:11PM +0200, Claudio Jeker wrote: > Trying to figure out why bgplgd terminates sometimes. > Since there is a timeout firing at an unexpected time I want some extra > info to figure out what kind of race this is. Sure, ok > > -- > :wq Claudio > > Index: slowcgi.c >

Re: Replace audio(9) get_props() with duplex check in open() in partial-duplex drivers

2022-10-27 Thread Klemens Nanni
27 Oct 2022 17:31:45 Miod Vallat : > Wait, this is wrong. All your > >     (flags & (FWRITE | FREAD)) > > comparisons must be > >     ((flags & (FWRITE | FREAD)) == (FWRITE | FREAD)) > > in order to truly catch full-duplex opens. Otherwise the condition will > always be satisfied since one

Replace audio(9) get_props() with duplex check in open() for play-only drivers

2022-10-27 Thread Klemens Nanni
Make drivers which do *not* adverise AUDIO_PROP_FULLDPLEX return ENXIO in their open() if full-duplex mode was requested. This way, sys/dev/audio.c:audio_open() will fail immediately rather than later through the to-be-removed get_props() check. These are all drivers which simply don't support

Re: Replace audio(9) get_props() with duplex check in open() for record-only drivers

2022-10-27 Thread Alexandre Ratchov
On Thu, Oct 27, 2022 at 01:09:57PM +, Klemens Nanni wrote: > @@ -1859,6 +1857,9 @@ utvfu_audio_open(void *v, int flags) > if (usbd_is_dying(sc->sc_udev)) > return (EIO); > > + if ((flags & (FWRITE | FREAD))) > + return (ENXIO); > + > if ((flags &

Re: Replace audio(9) get_props() with duplex check in open() in partial-duplex drivers

2022-10-27 Thread Alexandre Ratchov
On Thu, Oct 27, 2022 at 01:08:57PM +, Klemens Nanni wrote: > @@ -1040,6 +1041,9 @@ ad1848_open(void *addr, int flags) > > DPRINTF(("ad1848_open: sc=%p\n", sc)); > > + if ((flags & (FWRITE | FREAD)) && sc->mode != 2) > + return ENXIO; > + > sc->sc_pintr =

Re: Replace audio(9) get_props() with duplex check in open() for play-only drivers

2022-10-27 Thread Alexandre Ratchov
On Thu, Oct 27, 2022 at 01:27:43PM +, Klemens Nanni wrote: > Make drivers which do *not* adverise AUDIO_PROP_FULLDPLEX return ENXIO > in their open() if full-duplex mode was requested. > > This way, sys/dev/audio.c:audio_open() will fail immediately rather than > later through the

Re: bgplgd timeout race

2022-10-27 Thread Theo Buehler
On Thu, Oct 27, 2022 at 04:13:24PM +0200, Claudio Jeker wrote: > So the timeout for each request is started when the command is accepted > but the actual fork and exec of bgpctl happens later. So command_pid can > be 0 when the timeout fires. In that case do not kill ourself but instead > just

Re: [acpi] patch to run _INI methods before table devices attach

2022-10-27 Thread Mikhail
On Sat, Oct 22, 2022 at 01:41:23PM +0200, Mark Kettenis wrote: > Identifying which of the "table-driven" device attachments is the > culprit here might help. I have following tables: acpi0: tables DSDT FACP UEFI SSDT SSDT SSDT SSDT SSDT SSDT TPM2 MSDM NHLT SSDT LPIT WSMT SSDT SSDT DBGP DBG2

Replace audio(9) get_props() with duplex check in open() in partial-duplex drivers

2022-10-27 Thread Klemens Nanni
Make drivers which do *not* adverise AUDIO_PROP_FULLDPLEX return ENXIO in their open() if full-duplex mode was requested. This way, sys/dev/audio.c:audio_open() will fail immediately rather than later through the to-be-removed get_props() check. This is the first round for drivers with logic in

Replace audio(9) get_props() with duplex check in open() for record-only drivers

2022-10-27 Thread Klemens Nanni
Make drivers which do *not* adverise AUDIO_PROP_FULLDPLEX return ENXIO in their open() if full-duplex mode was requested. This way, sys/dev/audio.c:audio_open() will fail immediately rather than later through the to-be-removed get_props() check. utvfu(4) seems to be the only driver that

bgplgd timeout race

2022-10-27 Thread Claudio Jeker
So the timeout for each request is started when the command is accepted but the actual fork and exec of bgpctl happens later. So command_pid can be 0 when the timeout fires. In that case do not kill ourself but instead just abort this command. I think this is the proper way to do this dance. Not

bgplgd show pid in more debug messages

2022-10-27 Thread Claudio Jeker
Trying to figure out why bgplgd terminates sometimes. Since there is a timeout firing at an unexpected time I want some extra info to figure out what kind of race this is. -- :wq Claudio Index: slowcgi.c === RCS file:

Re: usbdevs(8) getopt tweak

2022-10-27 Thread Todd C . Miller
On Fri, 28 Oct 2022 12:03:15 +1000, David Gwynne wrote: > usbdevs has "?" in the optstring is passes to getopt, but doesn't handle > it specially. this is unnecessarily different to everything else in the > tree, so i want to remove it. ok? Sure, OK millert@ - todd

ssh internal refactor

2022-10-27 Thread Damien Miller
Hi, I just committed a fairly large refactoring of openssh's key handling code. It *should* be completely invisible, but if you notice any new problems then please let open...@openssh.com know. Thanks, Damien

Re: vmd: remove the user quota tracking

2022-10-27 Thread Matthew Martin
On Wed, Oct 12, 2022 at 09:20:06AM -0400, Dave Voutila wrote: > > 1 week bump for the below. If you use this feature or currently hacking > on it, speak up by end of week. I'm sharpening my axes. Are the axes sharp? > > diff refs/heads/master refs/heads/vmd-user > > commit -

usbdevs(8) getopt tweak

2022-10-27 Thread David Gwynne
usbdevs has "?" in the optstring is passes to getopt, but doesn't handle it specially. this is unnecessarily different to everything else in the tree, so i want to remove it. ok? Index: usbdevs.c === RCS file:

Re: usbdevs(8) getopt tweak

2022-10-27 Thread Theo de Raadt
David Gwynne wrote: > usbdevs has "?" in the optstring is passes to getopt, but doesn't handle > it specially. this is unnecessarily different to everything else in the > tree, so i want to remove it. ok? > > Index: usbdevs.c > ===

Re: Replace audio(9) get_props() with duplex check in open() for record-only drivers

2022-10-27 Thread Klemens Nanni
On Thu, Oct 27, 2022 at 03:49:55PM +0200, Alexandre Ratchov wrote: > On Thu, Oct 27, 2022 at 01:09:57PM +, Klemens Nanni wrote: > > @@ -1859,6 +1857,9 @@ utvfu_audio_open(void *v, int flags) > > if (usbd_is_dying(sc->sc_udev)) > > return (EIO); > > > > + if ((flags &

[PATCH 3/4] Replace audio(9) get_props() with duplex check in open() for non-duplex drivers

2022-10-27 Thread Klemens Nanni
On Thu, Oct 27, 2022 at 03:51:45PM +0200, Alexandre Ratchov wrote: > IMO, for play-only drivers, the check should be: > > if (flags & FREAD) > return ENXIO; > > which will reject record-only and full-duplex. My mistake when typing things down: those are drivers not

Re: Replace audio(9) get_props() with duplex check in open() in partial-duplex drivers

2022-10-27 Thread Alexandre Ratchov
On Thu, Oct 27, 2022 at 08:35:31PM +, Klemens Nanni wrote: > On Thu, Oct 27, 2022 at 03:51:05PM +0200, Alexandre Ratchov wrote: > > On Thu, Oct 27, 2022 at 01:08:57PM +, Klemens Nanni wrote: > > > @@ -1040,6 +1041,9 @@ ad1848_open(void *addr, int flags) > > > > > >

Re: Replace audio(9) get_props() with duplex check in open() in partial-duplex drivers

2022-10-27 Thread Klemens Nanni
On Thu, Oct 27, 2022 at 03:51:05PM +0200, Alexandre Ratchov wrote: > On Thu, Oct 27, 2022 at 01:08:57PM +, Klemens Nanni wrote: > > @@ -1040,6 +1041,9 @@ ad1848_open(void *addr, int flags) > > > > DPRINTF(("ad1848_open: sc=%p\n", sc)); > > > > + if ((flags & (FWRITE | FREAD)) &&

Re: Replace audio(9) get_props() with duplex check in open() for record-only drivers

2022-10-27 Thread Alexandre Ratchov
On Thu, Oct 27, 2022 at 08:28:53PM +, Klemens Nanni wrote: > On Thu, Oct 27, 2022 at 03:49:55PM +0200, Alexandre Ratchov wrote: > > On Thu, Oct 27, 2022 at 01:09:57PM +, Klemens Nanni wrote: > > > @@ -1859,6 +1857,9 @@ utvfu_audio_open(void *v, int flags) > > > if

Remove unused audio(9) get_props()/AUDIO_PROP_*

2022-10-27 Thread Klemens Nanni
After converting all drivers to play/record/duplex checks in their open() handler, those bits are no longer used and can go. OK once the other diffs are in? --- share/man/man9/audio.9 | 5 - sys/dev/audio.c| 9 - sys/dev/audio_if.h | 7 --- 3 files changed, 21

nd6_timer: remove kernel lock

2022-10-27 Thread Klemens Nanni
The kernel lock was added back when there was a single sofnet task queue: sys/net/nd6.c revision 1.213 date: 2017/08/06 12:53:30; author: mpi; state: Exp; lines: +15 -21; Reduce contention on the NET_LOCK() by moving the nd6 address expiration task to the

Re: [Patch] add minor clarification to Wireless in faq/faq6.html

2022-10-27 Thread tux2bsd
Stefan Sperling wrote: > A better way to improve this page for newcomers > would be to add a more examples. "A better way" stems from a this-or-that mindset. I like my proposed addition, I would have found it useful and it is why I scratched that itch. I also like your additional examples,

[Patch] add minor clarification to Wireless in faq/faq6.html

2022-10-27 Thread tux2bsd
This patch is to add a brief note that 'nwid' & 'join' serve different purposes and which man page to consult. $ git config diff.noprefix true $ git diff --relative . diff --git faq/faq6.html faq/faq6.html index 08343df0c..52770af6e 100644 --- faq/faq6.html +++ faq/faq6.html @@ -398,7 +398,8