GPROF: sleep_state: disable _mcount() across suspend/resume

2023-07-09 Thread Scott Cheloha
This patch fixes resume/unhibernate on GPROF kernels where kgmon(8) has activated kernel profiling. I think the problem is that code called from cpu_hatch() does not play nicely with _mcount(), so GPROF kernels crash during resume. I can't point you to which code in particular, but keeping all

Re: GPROF: sleep_state: disable _mcount() across suspend/resume

2023-07-09 Thread Claudio Jeker
On Sun, Jul 09, 2023 at 12:52:20PM -0500, Scott Cheloha wrote: > This patch fixes resume/unhibernate on GPROF kernels where kgmon(8) > has activated kernel profiling. > > I think the problem is that code called from cpu_hatch() does not play > nicely with _mcount(), so GPROF kernels crash during

make mbstat smaller (was Re: make mstat smaller)

2023-07-09 Thread YASUOKA Masahiko
On Sat, 08 Jul 2023 21:58:30 +0300 (EEST) YASUOKA Masahiko wrote: > The diff makes the mbstat be the same size which is actually used. > Also revert the previous that the mbstat is located on the stack. The userland program also needed to be changed. ok? Index: sys/kern/kern_sysctl.c

route leak nd6 detach

2023-07-09 Thread Alexander Bluhm
Hi, While testing my ART reference couting fix, I discovered a rtentry leak that is triggered by regress/sbin/route and detected with btrace(8) refcnt. The reference returned by rtalloc() must be freed with rtfree() in all cases. ok? bluhm Index: netinet6/in6_ifattach.c

Re: route leak nd6 detach

2023-07-09 Thread Vitaliy Makkoveev
> On 9 Jul 2023, at 15:15, Alexander Bluhm wrote: > > Hi, > > While testing my ART reference couting fix, I discovered a rtentry > leak that is triggered by regress/sbin/route and detected with > btrace(8) refcnt. > > The reference returned by rtalloc() must be freed with rtfree() in > all

Re: make mbstat smaller (was Re: make mstat smaller)

2023-07-09 Thread Claudio Jeker
On Sun, Jul 09, 2023 at 10:25:46AM +0300, YASUOKA Masahiko wrote: > On Sat, 08 Jul 2023 21:58:30 +0300 (EEST) > YASUOKA Masahiko wrote: > > The diff makes the mbstat be the same size which is actually used. > > Also revert the previous that the mbstat is located on the stack. > > The userland

Re: OpenBSD::MkTemp vs Devel::Cover

2023-07-09 Thread Andrew Hewus Fresh
On Sat, Jul 08, 2023 at 12:09:01PM -0700, Andrew Hewus Fresh wrote: > On Sat, Jul 08, 2023 at 11:18:00AM +0200, Marc Espie wrote: > > Hey, Philip, you wrote this a long time ago. > > > > Now, I'm trying to get some coverage out of Devel::Cover on pkg_add, > > and somehow, it gets in the way. > >

Re: GPROF: sleep_state: disable _mcount() across suspend/resume

2023-07-09 Thread Scott Cheloha
On Sun, Jul 09, 2023 at 05:24:43PM -0500, Scott Cheloha wrote: > On Sun, Jul 09, 2023 at 08:11:43PM +0200, Claudio Jeker wrote: > > On Sun, Jul 09, 2023 at 12:52:20PM -0500, Scott Cheloha wrote: > > > This patch fixes resume/unhibernate on GPROF kernels where kgmon(8) > > > has activated kernel

Re: OpenBSD::MkTemp vs Devel::Cover

2023-07-09 Thread Philip Guenther
Yeah, I don't really get what's going on here that Devel::Cover is unhappy about. Maybe it's something about how my mkstemps_real() implementation creates the filehandle that it returns. I see perlxstut(1) now talks about {Input,InOut,Output}Stream and PerlIO* in the typemap, so maybe I should

Re: pax(1): Don't open files that will be skipped

2023-07-09 Thread Theo Buehler
On Fri, Jul 07, 2023 at 12:40:55AM +, Jeremy Evans wrote: > On 12/23 08:36, Jeremy Evans wrote: > > On 11/22 11:15, Jeremy Evans wrote: > > > On 10/19 09:34, Jeremy Evans wrote: > > > > Currently, when creating an archive file with pax(1), pax will attempt > > > > to open a file even if the

Re: GPROF: sleep_state: disable _mcount() across suspend/resume

2023-07-09 Thread Scott Cheloha
On Sun, Jul 09, 2023 at 08:11:43PM +0200, Claudio Jeker wrote: > On Sun, Jul 09, 2023 at 12:52:20PM -0500, Scott Cheloha wrote: > > This patch fixes resume/unhibernate on GPROF kernels where kgmon(8) > > has activated kernel profiling. > > > > I think the problem is that code called from

Stop using direct syscall(2) from perl(1)

2023-07-09 Thread Andrew Hewus Fresh
Here is a patch to replace perl(1)'s use of syscall(2) with a dispatcher that will call the libc function instead. I have to do some work on style before this is ready to commit, but it should be ready for some testing. I don't currently plan on committing syscall_emulator.c because we need to