Re: Logitech Dual Action USB

2011-04-04 Thread Stanley Lieber
>From an old thread on misc@, circa Jun 17, 2008: > >> Re: usb gamepads >> So I ended up bying a Logitech Dual Action for $15 at a local store. >> This is what shows up in dmesg: >> >> uhidev2 at uhub1 port 2 configuration 1 interface 0 "Logitech Logitech Dual >> Action" rev 1.10/3.00 addr

Re: Use km_alloc instead of the single page allocator

2011-04-04 Thread Ariane van der Steldt
On Mon, Apr 04, 2011 at 03:54:32PM -0600, Artur Grabowski wrote: > First proper use of the new km_alloc. > > - Change pool constraints to use kmem_pa_mode instead of uvm_constraint_range > - Use km_alloc for all backend allocations in pools. > - Use km_alloc for the emergmency kentry allocation

Logitech Dual Action USB

2011-04-04 Thread Stanley Lieber
>From an old thread on misc@, circa Jun 17, 2008: > Re: usb gamepads > So I ended up bying a Logitech Dual Action for $15 at a local store. > This is what shows up in dmesg: > > uhidev2 at uhub1 port 2 configuration 1 interface 0 "Logitech Logitech Dual > Action" rev 1.10/3.00 addr 2 > uhid

isprint() needs setlocale(); for usr.bin

2011-04-04 Thread Stefan Sperling
For isprint() to work correctly in a UTF-8 locale applications must set up the LC_CTYPE locale before using isprint(). As done for hexdump and tcpdump already. This diff covers all offenders in usr.bin. Index: bc/bc.y === RCS file:

Use km_alloc instead of the single page allocator

2011-04-04 Thread Artur Grabowski
First proper use of the new km_alloc. - Change pool constraints to use kmem_pa_mode instead of uvm_constraint_range - Use km_alloc for all backend allocations in pools. - Use km_alloc for the emergmency kentry allocations in uvm_mapent_alloc - Garbage collect uvm_km_getpage, uvm_km_getpage_pla

Re: Compiling the kernel with pcc

2011-04-04 Thread Amit Kulkarni
On Mon, 4 Apr 2011, Alexander Bluhm wrote: > On Mon, Apr 04, 2011 at 08:06:57PM +0200, Pascal Stumpf wrote: > > net/pf.c: pf_addr_compare (was probably ok before r1.729) > > The current implementation has been discussed. See also: > http://www.greenend.org.uk/rjk/2003/03/inline.html > > The f

Re: tun(4) man page - missing includes

2011-04-04 Thread Jason McIntyre
On Fri, Mar 25, 2011 at 10:40:38PM +0100, Martin Pelikan wrote: > Hi list, > if anyone tries to develop an application using tun(4), the manpage > misses some includes neccesary for IFT_* and IFF_* constants. > If you switch the order of sys/types.h and sys/socket.h, your program > won't compile (i

fix mbuf leak in sogetopt()

2011-04-04 Thread Claudio Jeker
The implementation of SO_PEERCRED is leaking mbufs. > netstat -m 5292 mbufs in use: 46 mbufs allocated to data 4 mbufs allocated to packet headers 43 mbufs allocated to socket names and addresses 5199 mbufs allocated to socket options and quite a few over some time >

Re: softraid iopoolification

2011-04-04 Thread Kenneth R Westerback
On Mon, Apr 04, 2011 at 10:47:37AM -0400, Kenneth R Westerback wrote: > On Sun, Apr 03, 2011 at 07:01:04PM -0400, Kenneth R Westerback wrote: > > Works on my crypto volume. People with other volume types would be nice > > to hear from. > > > > Ken > > v2. Use scsi_io_[get|put](), stop trying

disgusting routing/network macro cleanup...now with booting kernels

2011-04-04 Thread Bret S. Lambert
Cleanup of some horrible macros pulled into the network code from the horrible radix code. Now boots and runs! And sends email! Hi, otto@! Index: net/radix.c === RCS file: /cvs/src/sys/net/radix.c,v retrieving revision 1.28 diff -u

Re: wcwidth() fixes in libedit

2011-04-04 Thread Nicholas Marriott
Hi This is fine with me. On Mon, Apr 04, 2011 at 09:04:26PM +0200, Stefan Sperling wrote: > On Mon, Apr 04, 2011 at 06:44:10PM +, Miod Vallat wrote: > > > > Would it be better maybe to do the check in the Width() macro itself? > > > > > > Yes indeed. New diff below. > > > > > -#define Widt

Re: drop ICMP redirects if ipforwaring = 1

2011-04-04 Thread Thordur Bjornsson
On Mon, Apr 04, 2011 at 08:24:38PM +0200, Claudio Jeker wrote: > On Mon, Apr 04, 2011 at 10:10:49AM -0700, Matthew Dempsky wrote: > > On Mon, Apr 4, 2011 at 9:11 AM, Claudio Jeker > > wrote: > > > + if (icmp_rediraccept == 0 || ipforwarding == 1) > > > > Would "ipforwarding != 0" be

Re: drop ICMP redirects if ipforwaring = 1

2011-04-04 Thread Matthew Dempsky
On Mon, Apr 4, 2011 at 11:24 AM, Claudio Jeker wrote: > Yes, ipforwarding == 2 is legitimate but IMO it is not a full router when > forwarding is only done when an IPsec flow is used. I have the feeling > that IPsec may need some redirects. This is why I choosed the == 1 check. Got it, makes sens

Re: AI_FQDN diff, now with man page bits

2011-04-04 Thread Matthew Dempsky
This of course needs a libc minor bump too. On Mon, Apr 04, 2011 at 11:10:54AM -0700, Matthew Dempsky wrote: > I haven't heard any objections to my initial AI_FQDN diff, so here's > the diff again with updated man page bits. See the original thread > for a proof-of-concept diff from djm@ to use t

AI_FQDN diff, now with man page bits

2011-04-04 Thread Matthew Dempsky
I haven't heard any objections to my initial AI_FQDN diff, so here's the diff again with updated man page bits. See the original thread for a proof-of-concept diff from djm@ to use this in OpenSSH. The man page mostly only uses "hostname" when referring to the formal argument, so I changed the AI

Re: Compiling the kernel with pcc

2011-04-04 Thread Philip Guenther
On Mon, Apr 4, 2011 at 11:06 AM, Pascal Stumpf wrote: > pcc currently only chokes on some inline functions that need external > linkage. gcc isn't pesky about that, but pcc and clang are (rightfully, > imo). It's completely legal and defined (by the standard and not just gcc!) for a function to b

Re: Compiling the kernel with pcc

2011-04-04 Thread Alexander Bluhm
On Mon, Apr 04, 2011 at 08:06:57PM +0200, Pascal Stumpf wrote: > net/pf.c: pf_addr_compare (was probably ok before r1.729) The current implementation has been discussed. See also: http://www.greenend.org.uk/rjk/2003/03/inline.html The function should be inline within pf.c and callable from p

Re: wcwidth() fixes in libedit

2011-04-04 Thread Stefan Sperling
On Mon, Apr 04, 2011 at 06:44:10PM +, Miod Vallat wrote: > > > Would it be better maybe to do the check in the Width() macro itself? > > > > Yes indeed. New diff below. > > > -#define Width(c) wcwidth(c) > > +#define Width(c) (wcwidth(c) == -1 ? 0 : wcwidth(c)) > > But this calls wcwidth

Re: Compiling the kernel with pcc

2011-04-04 Thread Jonathan Gray
On Mon, Apr 04, 2011 at 08:06:57PM +0200, Pascal Stumpf wrote: > pcc currently only chokes on some inline functions that need external > linkage. gcc isn't pesky about that, but pcc and clang are (rightfully, > imo). Anyway, the functions in question are: > > net/pf.c: pf_addr_compare (was pro

Re: wcwidth() fixes in libedit

2011-04-04 Thread Miod Vallat
> > Would it be better maybe to do the check in the Width() macro itself? > > Yes indeed. New diff below. > -#define Width(c) wcwidth(c) > +#define Width(c) (wcwidth(c) == -1 ? 0 : wcwidth(c)) But this calls wcwidth() to be invoked twice, which is ugly. As a minimum, make this an inline

Re: wcwidth() fixes in libedit

2011-04-04 Thread Nicholas Marriott
This is ok nicm I wouldn't be surprised if WIDECHAR build of libedit has other issues, getting it going is still on my list of things to do :-). On Mon, Apr 04, 2011 at 08:30:42PM +0200, Stefan Sperling wrote: > On Sun, Apr 03, 2011 at 11:26:52PM +0100, Nicholas Marriott wrote: > > Hi > > > > W

Re: wcwidth() fixes in libedit

2011-04-04 Thread Stefan Sperling
On Sun, Apr 03, 2011 at 11:26:52PM +0100, Nicholas Marriott wrote: > Hi > > We don't currently build a wide char libedit but comments inline: > > On Sun, Apr 03, 2011 at 11:46:24PM +0200, Stefan Sperling wrote: > > These callers in libedit might get confused if wcwidth() returns -1. > > > > Note

Re: drop ICMP redirects if ipforwaring = 1

2011-04-04 Thread Claudio Jeker
On Mon, Apr 04, 2011 at 10:10:49AM -0700, Matthew Dempsky wrote: > On Mon, Apr 4, 2011 at 9:11 AM, Claudio Jeker > wrote: > > + if (icmp_rediraccept == 0 || ipforwarding == 1) > > Would "ipforwarding != 0" be more appropriate here? According to > sysctl(3), ipforwarding == 2 is a l

Re: wcwidth() fix in libform

2011-04-04 Thread Stefan Sperling
On Sun, Apr 03, 2011 at 11:41:47PM +0100, Nicholas Marriott wrote: > Again so it is a cchar_t so I'm not sure it is valid for it to be > nonprintable but this doesn't do any harm. > > Might want to run this stuff past upstream first though? It is better if > we stay in sync if they do want to take

Re: wcwidth() fixes in libcurses

2011-04-04 Thread Stefan Sperling
On Sun, Apr 03, 2011 at 11:21:35PM +0100, Nicholas Marriott wrote: > > - if (x + len - 1 <= win->_maxx) { > > + if (len >= 0 && x + len - 1 <= win->_maxx) { > > Not sure this is required, astr is a cchar_t * which will come from > setcchar. Right. That already makes sure the string cannot co

Re: drop ICMP redirects if ipforwaring = 1

2011-04-04 Thread Matthew Dempsky
On Mon, Apr 4, 2011 at 9:11 AM, Claudio Jeker wrote: > + if (icmp_rediraccept == 0 || ipforwarding == 1) Would "ipforwarding != 0" be more appropriate here? According to sysctl(3), ipforwarding == 2 is a legitimate configuration setting.

Compiling the kernel with pcc

2011-04-04 Thread Pascal Stumpf
pcc currently only chokes on some inline functions that need external linkage. gcc isn't pesky about that, but pcc and clang are (rightfully, imo). Anyway, the functions in question are: net/pf.c: pf_addr_compare (was probably ok before r1.729) arch/{amd64,i386}/isa/clock.c: mc146818_read

Re: horribly slow fsck_ffs pass1 performance

2011-04-04 Thread Tobias Weingartner
On Saturday, April 2, Amit Kulkarni wrote: > > FreeBSD which is the origin of FFS does a > background fsck, and if Kirk McCusick feels so strongly I will do it > too. FreeBSD was not the origin of the FFS code. Background fsck in freebsd is mainly meant to reduce the amount of time it takes to g

drop ICMP redirects if ipforwaring = 1

2011-04-04 Thread Claudio Jeker
Routers need to ingore ICMP redirects in anycase so it would make sense to disable ICMP redirects as soon as ipforwarding is set to 1. The IPv6 counterpart already does this. OK? -- :wq Claudio Index: netinet/ip_icmp.c === RCS file:

Re: softraid iopoolification

2011-04-04 Thread David Gwynne
this reads fine by me, except for one thing. i worry that it looks like wu's get lists of ccbs attached to them that are released when the wu is released. before iopools there was a wu per call to softraids scsi_cmd handler, but now the same wu can be given to scsi_cmd multiple times. sr_scsi_done

Re: softraid iopoolification

2011-04-04 Thread Kenneth R Westerback
On Sun, Apr 03, 2011 at 07:01:04PM -0400, Kenneth R Westerback wrote: > Works on my crypto volume. People with other volume types would be nice > to hear from. > > Ken v2. Use scsi_io_[get|put](), stop trying so hard to avoid calling scsi_done() at SPLBIO as this is nice but not necessary, r

Najniže cene fitnesa - poslednje količine

2011-04-04 Thread Top Shop
Velika fitnes akcija! Ne propustite, poslednje koliD ine fitnesa opreme PO NAJNIE=IM CENAMA do sada! Ova posebna ponuda traje do 15. maja 2011! Ne gubite vreme, koliD ine su ograniD ene! Kliknite i poruD ite; Najbolja forma uz najbolje ponude Najbolji fitnes po najniE>im cenama - poslednje ko

Re: Disable BSD4.3 COMPAT

2011-04-04 Thread Ted Unangst
On Mon, Apr 4, 2011 at 7:51 AM, Thordur Bjornsson wrote: > tiny tedu moment of mine, disable COMPAT_43 and keep > it so for a few releases and if noone complains, nuke it. > > OK/Thoughts ? I think this is ok. I looked at a few of the uses, and we seem to be using the linux compat where needed.

Re: uvm_map diff - testing required

2011-04-04 Thread Ariane van der Steldt
On Mon, Apr 04, 2011 at 03:00:43PM +0200, Ariane van der Steldt wrote: > Please test this diff to uvm_map on as many architectures as possible. > Contains a number of fixes and a better algorithm. It makes sure random address space allocations happen (and enables it in the kernel) without causing

pmemrange fix

2011-04-04 Thread Ariane van der Steldt
Hi, Test the iterated range, instead of the range chosen to not meet the assert. This has been broken for a long time, but apparently no-one hit it so far. While here, change the KASSERT to a KDASSERT, as it is a validation of internal state of pmemrange. Ok? -- Ariane Index: uvm_pmemrange.c =

tweak for mount.h

2011-04-04 Thread Thordur Bjornsson
o Collapse a few _KERNEL's and move some definitions to allow this. o Expose a few NFSMOUNT stuffs (one I will remove, the other I'm going to use later anyways). o Kill a protection for a forward decleration o Kill __STDC__ protection (which is under _KERNEL). OK ? Index: sys/mount.h

Re: pool_debug is good, but also bad

2011-04-04 Thread Thordur Bjornsson
On Sun, Apr 03, 2011 at 06:38:51PM -0600, Theo de Raadt wrote: > based on a conversation at the bar. > > POOL_DEBUG is expensive. But we really want it because it finds bugs > before they hurt us. The solution to this is to make it simpler to > turn off. > > This diff starts the kernel with pool

Re: bye bye o43statfs

2011-04-04 Thread Philip Guenther
On Mon, Apr 4, 2011 at 3:29 AM, Thordur Bjornsson wrote: > this one is unused. > > OK ? I love the smell of burning bits in the morning. ok guenther

Disable BSD4.3 COMPAT

2011-04-04 Thread Thordur Bjornsson
tiny tedu moment of mine, disable COMPAT_43 and keep it so for a few releases and if noone complains, nuke it. OK/Thoughts ? Index: conf/GENERIC === RCS file: /var/cvs/src/sys/conf/GENERIC,v retrieving revision 1.172 diff -u -p -r1.1

Re: no swapping to vnds

2011-04-04 Thread David Gwynne
On 04/04/2011, at 8:43 PM, Thordur Bjornsson wrote: > On Mon, Apr 04, 2011 at 12:34:17PM +0200, Otto Moerbeek wrote: >> On Mon, Apr 04, 2011 at 09:22:41AM +, Thordur Bjornsson wrote: >> >>> Hi, >>> >>> 1) Swapping to svnds has issues (pagedaemon deadlocks) and has been >>> broken since forev

Re: no swapping to vnds

2011-04-04 Thread Thordur Bjornsson
On Mon, Apr 04, 2011 at 12:34:17PM +0200, Otto Moerbeek wrote: > On Mon, Apr 04, 2011 at 09:22:41AM +, Thordur Bjornsson wrote: > > > Hi, > > > > 1) Swapping to svnds has issues (pagedaemon deadlocks) and has been > >broken since forever. > > 2) Swapping to vnds makes no sense, why add an

bye bye o43statfs

2011-04-04 Thread Thordur Bjornsson
this one is unused. OK ? Index: sys/mount.h === RCS file: /var/cvs/src/sys/sys/mount.h,v retrieving revision 1.100 diff -u -p -r1.100 mount.h --- sys/mount.h 29 Jun 2010 04:09:32 - 1.100 +++ sys/mount.h 4 Apr 2011 10:28:59

Re: softraid iopoolification

2011-04-04 Thread David Gwynne
comments inline... On 04/04/2011, at 9:01 AM, Kenneth R Westerback wrote: > Works on my crypto volume. People with other volume types would be nice > to hear from. > > Ken > > Index: softraid.c > === > RCS file: /cvs/src/sys/dev

Re: no swapping to vnds

2011-04-04 Thread Mark Kettenis
> Date: Mon, 4 Apr 2011 09:22:41 + > From: Thordur Bjornsson > > Hi, > > 1) Swapping to svnds has issues (pagedaemon deadlocks) and has been >broken since forever. > 2) Swapping to vnds makes no sense, why add another layer when you >can just swap to a regular file instead ? > > so

Re: no swapping to vnds

2011-04-04 Thread Kenneth R Westerback
On Mon, Apr 04, 2011 at 09:22:41AM +, Thordur Bjornsson wrote: > Hi, > > 1) Swapping to svnds has issues (pagedaemon deadlocks) and has been >broken since forever. > 2) Swapping to vnds makes no sense, why add another layer when you >can just swap to a regular file instead ? > > so st

Re: no swapping to vnds

2011-04-04 Thread Otto Moerbeek
On Mon, Apr 04, 2011 at 09:22:41AM +, Thordur Bjornsson wrote: > Hi, > > 1) Swapping to svnds has issues (pagedaemon deadlocks) and has been >broken since forever. > 2) Swapping to vnds makes no sense, why add another layer when you >can just swap to a regular file instead ? > > so s

no swapping to vnds

2011-04-04 Thread Thordur Bjornsson
Hi, 1) Swapping to svnds has issues (pagedaemon deadlocks) and has been broken since forever. 2) Swapping to vnds makes no sense, why add another layer when you can just swap to a regular file instead ? so stop supporting swapping to vnds. If this turns out to be kosher I have a diff tested

Re: fix wcwidth (was: Re: ls(1) multibyte support)

2011-04-04 Thread Christian Weisgerber
Stefan Sperling wrote: > Change number 2 is the only one that hasn't been committed yet. > According to > http://pubs.opengroup.org/onlinepubs/009695399/functions/wcwidth.html > wcwidth() should return -1 for non-printable characters. > So this change looks good to me. Anyone want to ok it? FWIW

From now on ETHNOPLUS!

2011-04-04 Thread National Bank of Greece
) 2011

Re: pool_debug is good, but also bad

2011-04-04 Thread Mark Kettenis
> Date: Sun, 03 Apr 2011 18:38:51 -0600 > From: Theo de Raadt > > based on a conversation at the bar. > > POOL_DEBUG is expensive. But we really want it because it finds bugs > before they hurt us. The solution to this is to make it simpler to > turn off. > > This diff starts the kernel with p