Fixes for re(4) chip identification.

2011-06-22 Thread Brad
Some fixes for re(4) chipset identification.. - Rename 8168 revision entries to 8168B to reflect proper naming. From FreeBSD - Change 8168C_SPIN2 rev string to differentiate from the first rev. - Change 8169SBL ident string to also mention the 8110 chipset so the naming is consistent with the s

phantasia(6) remove unused code

2011-06-22 Thread Daniel Dickman
I guess the intent was to get a custom message at build time which would be shown when phantasia starts up. But -- (1) That would make the build interactive. (2) _PATH_PHANTDIR is not defined anywhere so this won't compile. (3) As the ifdef macro says, this can be done from the Makefile if n

Re: ansi some files in dev

2011-06-22 Thread David Gwynne
ok On 23/06/2011, at 3:06 AM, Ted Unangst wrote: > checked with md5, before line folding caused differences. > > > Index: cninit.c > === > RCS file: /home/tedu/cvs/src/sys/dev/cninit.c,v > retrieving revision 1.10 > diff -u -r1.10 cn

Re: two minor carp and pfsync fixes

2011-06-22 Thread David Gwynne
On 22/06/2011, at 3:52 AM, Stefan Rinkes wrote: > Hi, > > while playing around with carp and pfsync I spotted > two minor bugs. > > 1. Not all pfstate flags are synced, cause pfsync uses >u_int8_t, while pf uses u_int16_t for state_flags. >Currently that means PFSTATE_SCRUB_TCP flags don't

Re: Identifying disks by name

2011-06-22 Thread Thordur Bjornsson
On Wed, Jun 22, 2011 at 09:54:07PM +0200, Janjaap van Velthooven wrote: > Thordur Bjornsson wrote and mailed: > > On Wed, Jun 22, 2011 at 09:34:55PM +0200, Janjaap van Velthooven wrote: > > > Just a vague idea for the moment; > > > > > > How aboot some mechanism that can do number lookups by name

Re: two minor carp and pfsync fixes

2011-06-22 Thread Tobias Weingartner
I'm sure you did. Did you test it with one patched and one not? -Toby. On Wed, Jun 22, 2011 at 1:37 AM, Stefan Rinkes wrote: > On Tue, Jun 21, 2011 at 9:42 PM, Tobias Weingartner wrote: >> On Tue, Jun 21, 2011 at 11:52 AM, Stefan Rinkes >> wrote: >>> >>> while playing around with carp and pfs

Re: Identifying disks by name

2011-06-22 Thread roberth
On Wed, 22 Jun 2011 21:07:41 +0200 Wouter Coene wrote: > mount 1234567890abcdef.a /mnt > mount backups.a /mnt # export backups=1234567890abcdef # mount $backups.a /mnt I myself prefere to include the slice, less to remember/look up.

Re: Identifying disks by name

2011-06-22 Thread Thordur Bjornsson
On Wed, Jun 22, 2011 at 09:34:55PM +0200, Janjaap van Velthooven wrote: > On Wed, Jun 22, 2011 at 08:12:28PM +0100, Stuart Henderson wrote: > > On 2011/06/22 21:07, Wouter Coene wrote: > > > Also, this is certainly not useless if you have more than a handfull of > > > disks > > > or SAN volumes, o

Re: Identifying disks by name

2011-06-22 Thread Janjaap van Velthooven
On Wed, Jun 22, 2011 at 08:12:28PM +0100, Stuart Henderson wrote: > On 2011/06/22 21:07, Wouter Coene wrote: > > Also, this is certainly not useless if you have more than a handfull of > > disks > > or SAN volumes, or for removable media. Which of the following is more > > readable? > > > > m

Re: bus_dmamem_map fix (test+ok)

2011-06-22 Thread Ariane van der Steldt
On Tue, Jun 21, 2011 at 09:00:49PM +0200, Ariane van der Steldt wrote: > Bus_dmamem_map has a bug in its error path, where it frees the wrong > memory in the wrong way. After some discussion on icb, the comments and the pmap_remove can go too. The pmap_remove is executed by uvm_km_free() at uvm_un

Re: Identifying disks by name

2011-06-22 Thread Thordur Bjornsson
On Wed, Jun 22, 2011 at 09:07:41PM +0200, Wouter Coene wrote: > On 22 jun 2011, at 20:53, Kenneth R Westerback wrote: > > On Wed, Jun 22, 2011 at 06:48:14PM +0200, Wouter Coene wrote: > >> The patch below builds on the disk UID code to implement disk names. Disk > >> names must match [a-zA-Z0-9_]{1

Re: Identifying disks by name

2011-06-22 Thread Stuart Henderson
On 2011/06/22 21:07, Wouter Coene wrote: > > Also, this is certainly not useless if you have more than a handfull of disks > or SAN volumes, or for removable media. Which of the following is more > readable? > > mount 1234567890abcdef.a /mnt > mount backups.a /mnt mount bac00

Re: Identifying disks by name

2011-06-22 Thread Wouter Coene
On 22 jun 2011, at 20:53, Kenneth R Westerback wrote: > On Wed, Jun 22, 2011 at 06:48:14PM +0200, Wouter Coene wrote: >> The patch below builds on the disk UID code to implement disk names. Disk >> names must match [a-zA-Z0-9_]{1,10} and are stored encoded as 6 bits per >> character into the diskla

Re: ansi some files in dev

2011-06-22 Thread Kenneth R Westerback
sure. ok krw@ Ken On Wed, Jun 22, 2011 at 01:06:49PM -0400, Ted Unangst wrote: > checked with md5, before line folding caused differences. > > > Index: cninit.c > === > RCS file: /home/tedu/cvs/src/sys/dev/cninit.c,v > retriev

Re: Identifying disks by name

2011-06-22 Thread Kenneth R Westerback
On Wed, Jun 22, 2011 at 06:48:14PM +0200, Wouter Coene wrote: > Hi all, > > The patch below builds on the disk UID code to implement disk names. Disk > names must match [a-zA-Z0-9_]{1,10} and are stored encoded as 6 bits per > character into the disklabel UID field. With this patch, you can use di

disable altq functions

2011-06-22 Thread Ted Unangst
Does anybody use altq cdnr or rio? Do they work? Why do we have them, but not enabled? The last function commit to cdnr was over 8 years ago, and says it's still not ready for pf. So that seems really dead. rio may work, but what good are disabled options? RIO is documented in options(4),

Re: fix a few uvm includes

2011-06-22 Thread Ted Unangst
On Mon, 20 Jun 2011, Miod Vallat wrote: > > uvm_extern.h is the header people should be consuming. change a few uvm.h > > to uvm_extern.h. > > This is not what, say, kern_fork.c does. If you include , you > don't need any other , and definitely not > . > > > also, simplify and move the bufcach

ansi some files in dev

2011-06-22 Thread Ted Unangst
checked with md5, before line folding caused differences. Index: cninit.c === RCS file: /home/tedu/cvs/src/sys/dev/cninit.c,v retrieving revision 1.10 diff -u -r1.10 cninit.c --- cninit.c26 Jun 2010 23:24:44 - 1.10 +++ c

Identifying disks by name

2011-06-22 Thread Wouter Coene
Hi all, The patch below builds on the disk UID code to implement disk names. Disk names must match [a-zA-Z0-9_]{1,10} and are stored encoded as 6 bits per character into the disklabel UID field. With this patch, you can use disk names in /etc/fstab: bootdisk.a / ffs rw 1 1 And with every

macppc: CUDA, adb(4) controller, rewrite

2011-06-22 Thread Martin Pieuchot
The following diff is a partial rewrite of the actual adb(4) driver. It only applies to CUDA-based machines: $ dmesg |grep via-cuda && echo "Test this diff" I tried to separate as much as possible the code responsible for the CUDA chip, more or less like it is done for the PMU. It's a first step

Re: wol for xl(4)

2011-06-22 Thread Thomas Gerlach
> Stefan Sperling stsp.name> writes: > > Index: xl.c > > === > > RCS file: /cvs/src/sys/dev/ic/xl.c,v > > retrieving revision 1.101 > > diff -u -p -r1.101 xl.c > > --- xl.c17 Apr 2011 20:52:43 - 1.101 > > +++ xl.c22 J

Re: wol for xl(4)

2011-06-22 Thread Thomas Gerlach
Stefan Sperling stsp.name> writes: > > On Wed, Jun 22, 2011 at 11:43:27AM +, Thomas Gerlach wrote: > > ...crap! sorry, something went wrong here. :( > > I'm not sure what you mean went wrong. > > But in an effort to try to wrap this up, can you please try -current > with just this diff and

Re: wol for xl(4)

2011-06-22 Thread Stefan Sperling
On Wed, Jun 22, 2011 at 11:43:27AM +, Thomas Gerlach wrote: > ...crap! sorry, something went wrong here. :( I'm not sure what you mean went wrong. But in an effort to try to wrap this up, can you please try -current with just this diff and report back if that works? Thanks! Index: xl.c =

Re: bridge diff needs testing

2011-06-22 Thread Bret S. Lambert
On Wed, Jun 22, 2011 at 01:21:28PM +0200, Camiel Dobbelaar wrote: > > Hi Bret, > > one comment from inspection, is the part below related to the RB tree? > Or a seperate optimization? > > On 22-6-2011 12:21, Bret S. Lambert wrote: > > > @@ -1109,33 +1119,12 @@ bridge_output(struct ifnet *ifp, s

Re: wol for xl(4)

2011-06-22 Thread Thomas Gerlach
...crap! sorry, something went wrong here. :(

Re: wol for xl(4)

2011-06-22 Thread t . m . gerlach
> - > > On Wed, Jun 22, 2011 at 10:02:42AM +, Thomas Gerlach wrote: > > as for the "pulling toghether", i would suggest something like this > (draft, > > patches against latest -current files, _without_ stefan's recent > patches): > > > +#if 1 > > #ifndef SMALL_KERNEL > > > #

Re: wol for xl(4)

2011-06-22 Thread Thomas Gerlach
Stefan Sperling stsp.name> writes: > > Can you please clarify with which code exactly you're seeing this problem? > What are you running? > Does it happens with the if_xl_pci.c hunk of my proposed diff, or without it? > Or does it always happen even in plain -current? > ok, of course. 1) every

pf ip reassembly test awesomization

2011-06-22 Thread Bret S. Lambert
There's no need to walk the entire fragment list to determine if we have all the bytes of the unfragmented packet if we keep a running count on how much we've seen already. Please to be testing as we need to make sure that our userbase remains unmolested. - Bert Index: pf_norm.c

Re: wol for xl(4)

2011-06-22 Thread Stefan Sperling
On Wed, Jun 22, 2011 at 10:02:42AM +, Thomas Gerlach wrote: > as for the "pulling toghether", i would suggest something like this (draft, > patches against latest -current files, _without_ stefan's recent patches): > +#if 1 > #ifndef SMALL_KERNEL > #endif > +#endif Huh? > @@ -367,6 +365,2

Re: wol for xl(4)

2011-06-22 Thread Stefan Sperling
On Wed, Jun 22, 2011 at 09:54:07AM +, Thomas Gerlach wrote: > For me it works as well. :) > > Just two more little flaws: > > 1) If you configure WOL inside /etc/hostname., then you get the following > error message during booting: > > "xl0: command never completed!" > "xl0: transmission err

bridge diff needs testing

2011-06-22 Thread Bret S. Lambert
The following diff replaces the existing hash table with a red black tree, to the acclaim of network hackers worldwide. This has already received some testing, but needs some more shakedown in order to make sure that nobody gets hosed by this. Folks with more esoteric (read: vether and/or gif) set

Re: wol for xl(4)

2011-06-22 Thread Thomas Gerlach
as for the "pulling toghether", i would suggest something like this (draft, patches against latest -current files, _without_ stefan's recent patches): # diff -u xl.c.orig xl.c > xl.c.patch1 --- xl.c.orig Sun Apr 17 22:52:43 2011 +++ xl.cWed Jun 22 11:53:45 2011 @@ -2373,8 +2373,9 @@

Re: wol for xl(4)

2011-06-22 Thread Thomas Gerlach
For me it works as well. :) Just two more little flaws: 1) If you configure WOL inside /etc/hostname., then you get the following error message during booting: "xl0: command never completed!" "xl0: transmission error: ff" and you're not able to login. the problem is: "xl_init" is called first,

Re: two minor carp and pfsync fixes

2011-06-22 Thread Otto Moerbeek
On Wed, Jun 22, 2011 at 09:37:58AM +0200, Stefan Rinkes wrote: > On Tue, Jun 21, 2011 at 9:42 PM, Tobias Weingartner > wrote: > > On Tue, Jun 21, 2011 at 11:52 AM, Stefan Rinkes > > wrote: > >> > >> while playing around with carp and pfsync I spotted > >> two minor bugs. > >> > >> 1. Not all pfs

Re: two minor carp and pfsync fixes

2011-06-22 Thread Stefan Rinkes
On Tue, Jun 21, 2011 at 9:42 PM, Tobias Weingartner wrote: > On Tue, Jun 21, 2011 at 11:52 AM, Stefan Rinkes > wrote: >> >> while playing around with carp and pfsync I spotted >> two minor bugs. >> >> 1. Not all pfstate flags are synced, cause pfsync uses >>u_int8_t, while pf uses u_int16_t f