Re: Need testers for mg dired diff

2011-07-31 Thread Loganaden Velvindron
This is what you're talking about. C-n & C-p warp the dot on the filename. I've overwritten the default forwline() and backline() functions. I like this. If others don't find it annoying, we can go forward. I'll look at another issue that Mark brought up when I'll be done with work. Index: dire

Re: Need testers for mg dired diff

2011-07-31 Thread Nima Hoda
On Sun, Jul 31, 2011 at 11:40:43PM +0400, Loganaden Velvindron wrote: > As for the key-bindings, I picked the one which were un-used in > dired, as this seems to be practice that were used by some of the > previous diffs committed by kjell. Those keybinds apply to dired > mode only. > > Overall,

Re: Need testers for mg dired diff

2011-07-31 Thread Nima Hoda
On Sun, Jul 31, 2011 at 11:59:41PM +0400, Loganaden Velvindron wrote: > C-N and C-P are already assigned to forward-line and backward-line > in dired.c I don't think it's a good idea to remap existing > key-bindings... Well, if you were going to reassign C-n and C-p to next page and previous page

Re: Need testers for mg dired diff

2011-07-31 Thread Loganaden Velvindron
C-N and C-P are already assigned to forward-line and backward-line in dired.c I don't think it's a good idea to remap existing key-bindings... On Sun, Jul 31, 2011 at 11:32 PM, Nima Hoda wrote: > On Sun, Jul 31, 2011 at 12:15:56PM -0600, Theo de Raadt wrote: > > > I tested the patch briefly an

Re: Need testers for mg dired diff

2011-07-31 Thread Loganaden Velvindron
When I first talked to kjell about this, he suggested building wrappers around the basic functions in dired as dired was designed to be an optional module. As for the key-bindings, I picked the one which were un-used in dired, as this seems to be practice that were used by some of the previous dif

Re: Need testers for mg dired diff

2011-07-31 Thread Nima Hoda
On Sun, Jul 31, 2011 at 12:15:56PM -0600, Theo de Raadt wrote: > > I tested the patch briefly and it seems to work fine BUT I'm not sure > > why this is a good idea. You're mapping keys that do other things in > > Emacs (esp. C-o but also C-t and even C-w which can be used if the > > dired buffer

Re: Need testers for mg dired diff

2011-07-31 Thread Theo de Raadt
> I tested the patch briefly and it seems to work fine BUT I'm not sure > why this is a good idea. You're mapping keys that do other things in > Emacs (esp. C-o but also C-t and even C-w which can be used if the > dired buffer is made non-read-only in Emacs). When the change is simple, mg should

Re: Need testers for mg dired diff

2011-07-31 Thread Nima Hoda
On Sun, Jul 31, 2011 at 09:23:29PM +0400, Loganaden Velvindron wrote: > You can check our mg from current, it should compile fine. > > Here's the diff: > > http://marc.info/?l=openbsd-tech&m=131160869319297&w=2 > > Explanation Here: > > http://marc.info/?l=openbsd-tech&m=131161031221785&w=2 CC

softraid detach routine

2011-07-31 Thread Alexander Polakov
sr_detach() returns garbage if (sc->sc_scsibus == NULL). Can this happen? I don't know. But it's better to be clear, isn't it? Index: softraid.c === RCS file: /cvs/src/sys/dev/softraid.c,v retrieving revision 1.245 diff -u -p -r1.245

Re: [Patch] ffclose() in mg

2011-07-31 Thread Loganaden Velvindron
Shouldn't we account for errors when fclose() is called ?

Add support for Ricoh 5U823 SD/MMC to sdhc(4)

2011-07-31 Thread Mark Kettenis
This controller doesn't claim to be SD Host Controller compliant, but it almost is. The only thing missing seems to be the capabilities register. The following diff, inspired by the Linux code, makes the controller in my new x220 work. You'll need my last commit to pcidevs for this to compile.

Re: [Patch] ffclose() in mg

2011-07-31 Thread Ted Unangst
On Sun, Jul 31, 2011, Loganaden Velvindron wrote: > This diff uses void for ffclose() when > return values are not needed. > > Additionally, Instead of ignoring the output > it also returns error codes when fclose() fails > in ffclose(). This seems silly. ffclose should probably be void itself.

[Patch] ffclose() in mg

2011-07-31 Thread Loganaden Velvindron
This diff uses void for ffclose() when return values are not needed. Additionally, Instead of ignoring the output it also returns error codes when fclose() fails in ffclose(). Lastly, an error is shown in case of write problems instead of silently completing. Index: file.c ==

Re: recent change of nat-to behavior

2011-07-31 Thread Ryan McBride
On Sun, Jul 31, 2011 at 02:30:05PM +0200, Peter N. M. Hansteen wrote: > Ryan McBride writes: > > The interface may have more than one address... > > That's probably just me not noticing, but the odd part is that while > this interface has several addresses, it only has one IPv4 address: The poin

Re: recent change of nat-to behavior

2011-07-31 Thread Peter N. M. Hansteen
Ryan McBride writes: >> match out log on xl0 inet all nat-to (xl0) round-robin > > This part of the behaviour is normal and has not changed (since the > commit below, I believe). On 4.9 I get the following: > > i386-49$ echo "pass out on egress nat-to (egress)" | pfctl -vnf - > pass out on egress

Re: recent change of nat-to behavior

2011-07-31 Thread Ryan McBride
On Sun, Jul 31, 2011 at 02:04:35PM +0200, Peter N. M. Hansteen wrote: > Ryan McBride writes: > > Please try a newer snapshot, this bug was fixed in the following commit: > > Latest snapshot (date Jul 31) still loads > > match out log on $ext_if inet nat-to ($ext_if) > > as > > match out log o

Re: recent change of nat-to behavior

2011-07-31 Thread Peter N. M. Hansteen
Ryan McBride writes: > Please try a newer snapshot, this bug was fixed in the following commit: Latest snapshot (date Jul 31) still loads match out log on $ext_if inet nat-to ($ext_if) as match out log on xl0 inet all nat-to (xl0) round-robin but NATed traffic is handled correctly AFAICS.