Re: bge(4): enable TCP/UDP checksum offload

2012-11-03 Thread Christian Weisgerber
Brad Smith: > Here is another revision but disabling the UDP checksum offload. > There is a bug that results in some UDP packets having a 0 checksum. Oh, right. I assume you are referencing this FreeBSD commit? http://svnweb.freebsd.org/base/head/sys/dev/bge/if_bge.c?r1=211595&r2=211596&diff_for

Re: bge(4): enable TCP/UDP checksum offload

2012-11-03 Thread Brad Smith
On Sat, Nov 03, 2012 at 09:41:08PM +, Christian Weisgerber wrote: > Previously, we couldn't enable TCP/UDP transmit checksum offload > on chipsets that require the checksum field to be initialized with > the pseudo-header checksum because this would break rdr-to 127.0.0.1. > > Henning's epic r

Re: bge(4): enable TCP/UDP checksum offload

2012-11-03 Thread Christiano F. Haesbaert
On 03/11/2012, Christian Weisgerber wrote: > Previously, we couldn't enable TCP/UDP transmit checksum offload > on chipsets that require the checksum field to be initialized with > the pseudo-header checksum because this would break rdr-to 127.0.0.1. > > Henning's epic rewrite of the checksum hand

em(4): enable TCP/UDP checksum offload

2012-11-03 Thread Christian Weisgerber
Like bge(4), we previously couldn't enable TCP/UDP transmit checksum offload on em(4). We can now. Works fine here on em0 at pci1 dev 1 function 0 "Intel PRO/1000MT (82540EM)" rev 0x02 and with VLAN on em0 at pci5 dev 0 function 0 "Intel PRO/1000 MT (82574L)" rev 0x00 Does anybody see any va

bge(4): enable TCP/UDP checksum offload

2012-11-03 Thread Christian Weisgerber
Previously, we couldn't enable TCP/UDP transmit checksum offload on chipsets that require the checksum field to be initialized with the pseudo-header checksum because this would break rdr-to 127.0.0.1. Henning's epic rewrite of the checksum handling has fixed this problem, so let's enable TCP/UDP

pflogd(8): two if_exists() fixes

2012-11-03 Thread Lawrence Teo
Quick background: In pflogd(8), the if_exists() function tests if a given pflogX interface exists. It returns 1 (if it exists) or 0 (if not). This diff fixes two issues with if_exists(): 1. if_exists() opens a socket to test the pflogX interface exists. If the interface does not exist, the f

mg: remove b_undopos

2012-11-03 Thread Florian Obser
Found while investigating a llvm report. Since this doesn't actually do anything, the dot handling of undo (i.e. move dot to where an undo is happening) is fine afaic, I'd like to remove this. Unless someone has a diff to make this useful... Also note the rather elaborate way an int is set to zero

Re: Goodbye to you my file descriptor

2012-11-03 Thread Loganaden Velvindron
Thanks for fixing my mistake :-) On Sat, Nov 3, 2012 at 6:57 PM, Christiano F. Haesbaert wrote: > On Tue, Oct 30, 2012 at 04:44:36PM +0100, rustyBSD wrote: >> Le 30/10/2012 15:32, Christiano F. Haesbaert a ?crit : >> > That should be an access(2) call. >> Yes.Something like this - also moved len

Re: Goodbye to you my file descriptor

2012-11-03 Thread Christiano F. Haesbaert
On Tue, Oct 30, 2012 at 04:44:36PM +0100, rustyBSD wrote: > Le 30/10/2012 15:32, Christiano F. Haesbaert a ?crit : > > That should be an access(2) call. > Yes.Something like this - also moved len to size_t, > as strlen() is size_t: > > > --- dired.cWed Mar 14 14:56:35 2012 > +++ dired.cTu

softraid_crypto.c and bioctl.c: select encryption algorithm and parameters

2012-11-03 Thread Thiebaud Weksteen
Hi all, Here is a patch I've made to select the algorithm and its parameters used for a softraid encryption. I added an extra field to the kdfinfo structure to retrieve the algorithm type from userland (This structure may need to be renamed in the future). I also modified bioctl to allow this extr