tmux leaving zombie behind

2013-07-04 Thread patrick keshishian
Hi, Back in 2010 (Apri-ish according to google) I reported that tmux left a zombie process behind on initial launch. If user detached and reattached, the zombie process cleared. I even provided a patch, which I believe was accepted, but then replaced with a slightly different version. However,

smtpd: if?

2013-07-04 Thread Maxime Villard
Hi, - - - src/usr.sbin/smtpd/smtpd.c l.1326 if (! bsnprintf(key, sizeof key, profiling.imsg.%s.%s.%s, proc_name(smtpd_process), proc_name(p-proc), imsg_to_str(imsg-hdr.type)));-- ';' stat_set(key,

Re: smtpd: if?

2013-07-04 Thread Gilles Chehade
On Thu, Jul 04, 2013 at 08:48:16AM +0200, Maxime Villard wrote: Hi, - - - src/usr.sbin/smtpd/smtpd.c l.1326 if (! bsnprintf(key, sizeof key, profiling.imsg.%s.%s.%s, proc_name(smtpd_process), proc_name(p-proc),

old unused leftover

2013-07-04 Thread Artturi Alm
Hi, old has been old and unused for some time already. - Artturi Index: kern_timeout.c === RCS file: /cvs/src/sys/kern/kern_timeout.c,v retrieving revision 1.35 diff -u -p -u -p -r1.35 kern_timeout.c --- kern_timeout.c2 Jun

Re: libc malloc poison

2013-07-04 Thread Theo de Raadt
On Wed, Jul 03, 2013 at 17:21, Theo de Raadt wrote: + int pval = 0xd0d0caca; Can you explain the choice of this? I thought it sounded clever. Ok, because there's more to the picture. Inside the kernel, we tend to use 0xdeadbeef, or the DEADBEEF0/DEADBEEF1 values. Reason for the

Re: libc malloc poison

2013-07-04 Thread Mark Kettenis
From: Theo de Raadt dera...@cvs.openbsd.org Date: Thu, 04 Jul 2013 09:04:54 -0600 I suspect the best approach would be a hybrid value. The upper half of the address should try to land in an unmapped zone, or into the zero page, or into some address space hole, ir into super high memory

Re: libc malloc poison

2013-07-04 Thread Theo de Raadt
From: Theo de Raadt dera...@cvs.openbsd.org Date: Thu, 04 Jul 2013 09:04:54 -0600 I suspect the best approach would be a hybrid value. The upper half of the address should try to land in an unmapped zone, or into the zero page, or into some address space hole, ir into super high

Removing -Wno-format from kernel makefiles, 06/16

2013-07-04 Thread Stefan Fritsch
Use %z* for size_t while there, fix a few %d into %u --- sys/arch/i386/pci/pcibios.c |2 +- sys/dev/ic/bwi.c|4 ++-- sys/dev/ic/pgt.c|6 +++--- sys/dev/ic/ti.c |4 ++-- sys/dev/pci/amdiic.c|4 ++-- sys/dev/pci/amdpm.c |

Re: Removing -Wno-format from kernel makefiles, 3/16

2013-07-04 Thread Stefan Fritsch
On Wed, 3 Jul 2013, Mark Kettenis wrote: diff --git sys/arch/i386/i386/db_interface.c sys/arch/i386/i386/db_interface.c index 85c1ff5..c75fd89 100644 --- sys/arch/i386/i386/db_interface.c +++ sys/arch/i386/i386/db_interface.c @@ -197,11 +197,11 @@ db_sysregs_cmd(db_expr_t addr, int

Re: Removing -Wno-format from kernel makefiles, 4/16

2013-07-04 Thread Stefan Fritsch
On Wed, 3 Jul 2013, Mark Kettenis wrote: diff --git sys/arch/i386/i386/esm.c sys/arch/i386/i386/esm.c index c90b2c4..3dff69e 100644 --- sys/arch/i386/i386/esm.c +++ sys/arch/i386/i386/esm.c @@ -880,7 +880,7 @@ esm_make_sensors(struct esm_softc *sc, struct esm_devmap *devmap,

Removing -Wno-format from kernel makefiles, 07/16

2013-07-04 Thread Stefan Fritsch
fix: %x instead of %p for int --- sys/dev/pci/musycc_obsd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git sys/dev/pci/musycc_obsd.c sys/dev/pci/musycc_obsd.c index 25a58d8..0844136 100644 --- sys/dev/pci/musycc_obsd.c +++ sys/dev/pci/musycc_obsd.c @@ -215,7 +215,7 @@

Removing -Wno-format from kernel makefiles, 10/16

2013-07-04 Thread Stefan Fritsch
fix: pointer to long --- sys/arch/i386/pci/pci_addr_fixup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git sys/arch/i386/pci/pci_addr_fixup.c sys/arch/i386/pci/pci_addr_fixup.c index 59880eb..40f7918 100644 --- sys/arch/i386/pci/pci_addr_fixup.c +++

Removing -Wno-format from kernel makefiles, 09/16

2013-07-04 Thread Stefan Fritsch
paddr_t is long --- sys/arch/i386/i386/machdep.c |4 ++-- sys/arch/i386/pci/pci_addr_fixup.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git sys/arch/i386/i386/machdep.c sys/arch/i386/i386/machdep.c index 7924386..1a26e7d 100644 --- sys/arch/i386/i386/machdep.c

Removing -Wno-format from kernel makefiles, 08/16

2013-07-04 Thread Stefan Fritsch
%hu/%hd for uint16_t, %u/%d/%x for uint32_t despite the name, ntohl returns uint32_t also fix some %d into %u --- sys/arch/i386/i386/bios.c|4 ++-- sys/arch/i386/i386/ioapic.c |2 +- sys/arch/i386/pci/pcibios.c |4 ++-- sys/kern/vfs_cluster.c |2 +-

Re: Removing -Wno-format from kernel makefiles, V2

2013-07-04 Thread Stefan Fritsch
On Wednesday 03 July 2013, Stefan Fritsch wrote: I haven't done any signedness fixes so far, only the size fixes. But I will look over the patches again and try to fix the signedness issues in the touched code lines, too. There are quite a few I guess. For people prefering to review by source

Re: Removing -Wno-format from kernel makefiles, 07/16

2013-07-04 Thread Franco Fichtner
On Jul 4, 2013, at 6:43 PM, Stefan Fritsch s...@sfritsch.de wrote: fix: %x instead of %p for int --- sys/dev/pci/musycc_obsd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git sys/dev/pci/musycc_obsd.c sys/dev/pci/musycc_obsd.c index 25a58d8..0844136 100644 ---

Re: Removing -Wno-format from kernel makefiles, 3/16

2013-07-04 Thread Mark Kettenis
Date: Thu, 4 Jul 2013 18:41:30 +0200 (CEST) From: Stefan Fritsch s...@sfritsch.de On Wed, 3 Jul 2013, Mark Kettenis wrote: diff --git sys/arch/i386/i386/db_interface.c sys/arch/i386/i386/db_interface.c index 85c1ff5..c75fd89 100644 --- sys/arch/i386/i386/db_interface.c +++

Re: Removing -Wno-format from kernel makefiles, 4/16

2013-07-04 Thread Mark Kettenis
Date: Thu, 4 Jul 2013 18:42:50 +0200 (CEST) From: Stefan Fritsch s...@sfritsch.de On Wed, 3 Jul 2013, Mark Kettenis wrote: diff --git sys/arch/i386/i386/esm.c sys/arch/i386/i386/esm.c index c90b2c4..3dff69e 100644 --- sys/arch/i386/i386/esm.c +++ sys/arch/i386/i386/esm.c @@

Re: Removing -Wno-format from kernel makefiles, 06/16

2013-07-04 Thread Alexander Bluhm
On Thu, Jul 04, 2013 at 06:39:03PM +0200, Stefan Fritsch wrote: diff --git sys/netinet/ip_output.c sys/netinet/ip_output.c index b59accf..43a0551 100644 --- sys/netinet/ip_output.c +++ sys/netinet/ip_output.c @@ -267,7 +267,7 @@ reroute: if (mtag != NULL) { #ifdef DIAGNOSTIC