Re: new login style: yubikey-and-pwd

2014-01-05 Thread Remi Locherer
On Sun, Jan 05, 2014 at 06:44:22PM -0600, Kent R. Spillner wrote: > Still haven't tested, but I also saw: > > > +password_pwd = malloc(password_pwd_len + 1); /* +1 for \0 */ > > + > > +/* extract the password */ > > +for ( cnt = 0 ; cnt < password_pwd_len ; cnt++ ) > > +passwor

provide etext symbol on sparc64

2014-01-05 Thread Tobias Ulmer
Profiling on sparc64 is broken because e(nd of)text is missing. Once fixed, profiling works just fine on a Blade 1500. Am I missing something? OK? Index: arch/sparc64/conf/ld.script === RCS file: /home/vcs/cvs/openbsd/src/sys/arch/sp

Re: new login style: yubikey-and-pwd

2014-01-05 Thread Kent R. Spillner
> +/* the string generated by yubikey is 44 bytes long */ > +password_pwd_len = strlen(password) - 44, cnt; Haven't tested your latest diff, but I think you have a copy-pasto here (", cnt").

Re: new login style: yubikey-and-pwd

2014-01-05 Thread Kent R. Spillner
Still haven't tested, but I also saw: > +password_pwd = malloc(password_pwd_len + 1); /* +1 for \0 */ > + > +/* extract the password */ > +for ( cnt = 0 ; cnt < password_pwd_len ; cnt++ ) > +password_pwd[cnt] = password[cnt]; > +password_pwd[password_pwd_len] = '\0'; Use

Re: new login style: yubikey-and-pwd

2014-01-05 Thread Remi Locherer
On Sun, Jan 05, 2014 at 12:26:05PM +, Stuart Henderson wrote: > On 2014/01/05 13:10, Remi Locherer wrote: > > + /* only test the password if yubikey auth was successful */ > > This should be done even if Yubikey auth fails, to avoid disclosing > information due to timing. Good point! I chan

Re: new login style: yubikey-and-pwd

2014-01-05 Thread Remi Locherer
On Sun, Jan 05, 2014 at 09:15:21PM +0900, Ryan McBride wrote: > My wish is for something with this user functionality, but use the > password to encrypt/decrypt the user.key file, via pbkdf2-ish function > (like bioctl/softraid_crypto), to avoid having the key in plaintext on > the disk. It's a bit

Re: new login style: yubikey-and-pwd

2014-01-05 Thread Stuart Henderson
On 2014/01/05 13:10, Remi Locherer wrote: > + /* only test the password if yubikey auth was successful */ This should be done even if Yubikey auth fails, to avoid disclosing information due to timing.

Re: new login style: yubikey-and-pwd

2014-01-05 Thread Remi Locherer
On Sat, Jan 04, 2014 at 10:55:39AM +0100, Remi Locherer wrote: > This patch privides a new login style: yubikey-and-pwd. The idea is from > login_totp-and-pwd from the login_oath port. > > I tried to keep the patch small and not touch to many things. But probably > it would be bette to chang more

patch to test: simplify pkg addition

2014-01-05 Thread Marc Espie
The following patch "removes" pure package additions in pkg_add: instead of having separate code paths for "normal" installs and for "updates" (with extract then install), everything follows the extract then install road. There are several reasons behind this patch: first, it simplifies the code,

Re: sha256 cksums for amd64 snapshot

2014-01-05 Thread Scott McEachern
On 01/05/14 00:42, Andrew Ngo wrote: I was trying to retrieve the "03-Jan-2014 09:31" amd64 snapshot: bsd.rd has the correct checksum, but other files do not. (At the very least, bsd and bsd.mp don't.) SHA256 (bsd.rd) = d7ace3a649d18d660ca64da9f7563e976a5480c3c463a99c796d40c17b209322 SHA256 (bsd