[patch] OpenCVS: Handle ends of revision chains properly

2014-04-04 Thread Visa Hankala
Hello, OpenCVS fails to retrieve deltas at ends of revision chains. Because of this, a checkout of revision 1.1 or the last revision of a branch tends to give wrong data or crash the program. This issue has been around several years, and many have reported it in the mailing lists. The following

Re: pax / tar exit code on truncated input

2014-04-04 Thread Marco Pfatschbacher
On Thu, Apr 03, 2014 at 05:19:45PM -0600, Theo de Raadt wrote: Interesting. Can we take bath approaches? I don't see why we should not. Is there a reason to not expose either error? I thought it might break some legacy stuff regarding tapes and such. But since no one spoke up... OK?

Re: pax / tar exit code on truncated input

2014-04-04 Thread Philip Guenther
On Fri, Apr 4, 2014 at 11:42 AM, Philip Guenther guent...@gmail.com wrote: /* Do not exit before child to ensure data integrity */ - if (zpid 0) + if (zpid 0) { waitpid(zpid, status, 0); + if (WIFEXITED(status) WEXITSTATUS(status)) +

Re: pax / tar exit code on truncated input

2014-04-04 Thread Andres Perera
On Fri, Apr 4, 2014 at 2:12 PM, Philip Guenther guent...@gmail.com wrote: On Fri, Apr 4, 2014 at 11:27 AM, Marco Pfatschbacher m...@mailq.de wrote: On Thu, Apr 03, 2014 at 05:19:45PM -0600, Theo de Raadt wrote: Interesting. Can we take bath approaches? I don't see why we should not. Is

Re: pax / tar exit code on truncated input

2014-04-04 Thread Philip Guenther
On Fri, Apr 4, 2014 at 4:44 PM, Andres Perera andre...@zoho.com wrote: On Fri, Apr 4, 2014 at 2:12 PM, Philip Guenther guent...@gmail.com wrote: On Fri, Apr 4, 2014 at 11:27 AM, Marco Pfatschbacher m...@mailq.de wrote: On Thu, Apr 03, 2014 at 05:19:45PM -0600, Theo de Raadt wrote: Interesting.