Re: uchcom(4) did not work

2014-05-14 Thread Martin Pieuchot
On 13/05/14(Tue) 21:24, Mike Larkin wrote: On Wed, May 14, 2014 at 11:02:49AM +0900, SASANO Takayoshi wrote: Hi, Simply magic values are rewrited with #define. If these values need to be disassembled, please take a while... I think we need to understand what those values mean. When

Re: uchcom(4) did not work

2014-05-14 Thread Mark Kettenis
Date: Wed, 14 May 2014 11:04:56 +0200 From: Martin Pieuchot mpieuc...@nolizard.org On 13/05/14(Tue) 21:24, Mike Larkin wrote: On Wed, May 14, 2014 at 11:02:49AM +0900, SASANO Takayoshi wrote: Hi, Simply magic values are rewrited with #define. If these values need to be

Re: Big routing table diff

2014-05-14 Thread Martin Pieuchot
On 13/05/14(Tue) 19:25, Claudio Jeker wrote: The last three hackathons I got sucked into one ugly dark corner of the network stack. Our radix tree implementation one one particular bug in it that caused bgpd and ospfd to freak out on semi regular basis. Do you know why they would freak out?

Re: uchcom(4) did not work

2014-05-14 Thread Creamy
/* * XXX: it is difficult to handle the line control appropriately: -* - CS8, !CSTOPB and any parity mode seems ok, but -* - the chip doesn't have the function to calculate parity -* in !CS8 mode. -* - it is

cleanup wsmoused 1

2014-05-14 Thread Alexandr Shadchin
wsmoused() called if cmd == WSDISPLAYIO_WSMOUSED only, don't need check cmd twice Comment ? OK ? note: diff cteated with 'cvs diff -w' for simplicity -- Alexandr Shadchin Index: wsdisplay.c === RCS file:

cleanup wsmoused 2

2014-05-14 Thread Alexandr Shadchin
Remove unused variables. OK ? -- Alexandr Shadchin Index: wsmoused.c === RCS file: /cvs/src/usr.sbin/wsmoused/wsmoused.c,v retrieving revision 1.29 diff -u -p -r1.29 wsmoused.c --- wsmoused.c 24 Nov 2013 01:06:19 - 1.29

cleanup wsmoused 3

2014-05-14 Thread Alexandr Shadchin
Remove unused code. OK ? -- Alexandr Shadchin Index: mouse_protocols.c === RCS file: /cvs/src/usr.sbin/wsmoused/mouse_protocols.c,v retrieving revision 1.13 diff -u -p -r1.13 mouse_protocols.c --- mouse_protocols.c 5 Jun 2009

Re: Big routing table diff

2014-05-14 Thread Claudio Jeker
On Wed, May 14, 2014 at 12:11:30PM +0200, Martin Pieuchot wrote: On 13/05/14(Tue) 19:25, Claudio Jeker wrote: The last three hackathons I got sucked into one ugly dark corner of the network stack. Our radix tree implementation one one particular bug in it that caused bgpd and ospfd to freak

cleanup wsmoused 4

2014-05-14 Thread Alexandr Shadchin
Remove mouse.baudrate, it is always 1200. OK ? -- Alexandr Shadchin diff --git mouse_protocols.c mouse_protocols.c index b250f65..9ee1039 100644 --- mouse_protocols.c +++ mouse_protocols.c @@ -635,16 +635,15 @@ mouse_init(void) * The baud rate selection command must be sent at

cleanup wsmoused 5

2014-05-14 Thread Alexandr Shadchin
Remove second arg in SetMouseSpeed(), it is always 1200. OK ? -- Alexandr Shadchin diff --git mouse_protocols.c mouse_protocols.c index 9ee1039..a41d618 100644 --- mouse_protocols.c +++ mouse_protocols.c @@ -184,7 +184,7 @@ mouse_name(int type) } void -SetMouseSpeed(int old, int new,

[PATCH] login_yubikey.c with optional PIN

2014-05-14 Thread Jeff Clement
Hi everyone, Sorry for the repeat post.  I originally sent this 2014-05-05 and I think it slipped under the radar. Here is an updated version with a properly produced diff and without the attachment. - I'd like to propose an addition to

recvmsg, fd passing and soreceive

2014-05-14 Thread Jérémie Courrèges-Anglas
Hi, Initially, I just wanted to try the examples in CMSG_DATA(3). They are a bit incomplete, so I had to guess a few things. This is the result of my tests: #include sys/types.h #include sys/socket.h #include sys/uio.h #include sys/wait.h #include err.h #include errno.h #include limits.h

Re: rtadvd prints error on receiving RA with Route Information

2014-05-14 Thread Jérémie Courrèges-Anglas
Redirecting this to tech@ Consus has confirmed this fixed his issue. I plan to commit it this week-end if I hear no objection. j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: Thanks for the detailed report. This diff makes rtadvd aware of route info messages on the listening side, no

Re: recvmsg, fd passing and soreceive

2014-05-14 Thread Matthew Dempsky
On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas j...@wxcvbn.org wrote: if (cmsg-cmsg_len == CMSG_LEN(sizeof(int)) cmsg-cmsg_level == SOL_SOCKET cmsg-cmsg_type == SCM_RIGHTS) {

Re: UPDATE: xf86-input-synaptics 1.8.0

2014-05-14 Thread Claudio Jeker
On Tue, May 13, 2014 at 02:03:57PM +0600, Alexandr Shadchin wrote: Hi, This diff updates xf86-input-synaptics to the latest release 1.8.0. Comments ? OK ? Running with this on a Thinkpad X240 and it works for me just fine. Using the following config: Section InputClass Identifier

better free checking

2014-05-14 Thread Ted Unangst
As I learned the hard way not long ago, free() doesn't detect all errors because of the delay mechanism. We can make two improvements. 1. Perform the sanity checking from free_bytes before we insert something into the delay array. This detects many kinds of badness much sooner. 2. Check that the

Re: fun with smtpd, (two bugs)

2014-05-14 Thread Frank Brodbeck
Hi, here's a new version for the manpage bug Creamy mentioned. Frank. Index: usr.sbin/smtpd/smtpd.conf.5 === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v retrieving revision 1.117 diff -u -r1.117 smtpd.conf.5 ---

libcrypto: stop some ASN.1 bleeding

2014-05-14 Thread Miod Vallat
... or, in other words, try to fix most memory leak upon failure. This kind of change is difficult to test, the more eyes reviewing it, the better. Miod Index: a_gentm.c === RCS file: /cvs/src/lib/libssl/src/crypto/asn1/a_gentm.c,v

NOINET6 by default

2014-05-14 Thread Henning Brauer
so as discussed recently having the inet6 link-local addrs on every interface by default is stupid and a security risk. this diff fixes that. well, really two independent parts. one: set the NOINET6 flag by default on each and every interface. two: implement ifconfig if +inet6 to turn inet6 on

Re: rtadvd prints error on receiving RA with Route Information

2014-05-14 Thread Alexander Bluhm
On Wed, May 14, 2014 at 07:55:44PM +0200, J??r??mie Courr??ges-Anglas wrote: Redirecting this to tech@ Consus has confirmed this fixed his issue. I plan to commit it this week-end if I hear no objection. j...@wxcvbn.org (J??r??mie Courr??ges-Anglas) writes: Thanks for the detailed

IFT_L2VLAN is unused

2014-05-14 Thread Henning Brauer
don't kill the define, since this is userland visible, but there is never ever an interface in our kernel with if_type == IFT_L2VLAN - see my commit from 2 weeks ago or so. To clarify this once again, I didn't remove the L2VLAN use, it was never really used. ok? Index: net/if.c

Re: NOINET6 by default

2014-05-14 Thread Paul de Weerd
Hi Henning, Thanks, I really like this. On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote: | the only use case that needs config adoption: people ONLY using | link-local, they will need to put +inet6 in the corresponding | hostname.if file. People that set

[PATCH] rcs regression tests

2014-05-14 Thread Fritjof Bornebusch
Hi tech, I added some missing ; to the rlog out files, to make sure these tests don't fail. fritjof Index: rlog-rflag2.out === RCS file: /cvs/src/regress/usr.bin/rcs/rlog-rflag2.out,v retrieving revision 1.1 diff -u -p -r1.1

Re: NOINET6 by default

2014-05-14 Thread Stuart Henderson
On 2014/05/15 00:02, Paul de Weerd wrote: Hi Henning, Thanks, I really like this. On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote: | the only use case that needs config adoption: people ONLY using | link-local, they will need to put +inet6 in the corresponding |

Re: NOINET6 by default

2014-05-14 Thread Mark Kettenis
Date: Wed, 14 May 2014 23:29:20 +0200 From: Henning Brauer lists-openbsdt...@bsws.de this diff fixes that. well, really two independent parts. one: set the NOINET6 flag by default on each and every interface. ok on that bit two: implement ifconfig if +inet6 to turn inet6 on and assign the

Re: fun with smtpd, (two bugs)

2014-05-14 Thread Jason McIntyre
On Wed, May 14, 2014 at 11:10:03PM +0200, Frank Brodbeck wrote: Hi, here's a new version for the manpage bug Creamy mentioned. Frank. it's still missing some . also i think we can wholly simplify the auth/auth-optional line. how's this? jmc Index: smtpd.conf.5

Re: IFT_L2VLAN is unused

2014-05-14 Thread Alexander Bluhm
On Wed, May 14, 2014 at 11:51:13PM +0200, Henning Brauer wrote: don't kill the define, since this is userland visible, but there is never ever an interface in our kernel with if_type == IFT_L2VLAN - see my commit from 2 weeks ago or so. To clarify this once again, I didn't remove the L2VLAN

Re: NOINET6 by default

2014-05-14 Thread Ted Unangst
On Thu, May 15, 2014 at 00:14, Alexander Bluhm wrote: On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote: so as discussed recently having the inet6 link-local addrs on every interface by default is stupid and a security risk. Connecting a computer to the internet is a security

Re: NOINET6 by default

2014-05-14 Thread Kenneth Westerback
On 14 May 2014 18:14, Alexander Bluhm alexander.bl...@gmx.net wrote: On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote: so as discussed recently having the inet6 link-local addrs on every interface by default is stupid and a security risk. Connecting a computer to the internet is

Re: NOINET6 by default

2014-05-14 Thread Henning Brauer
* Mark Kettenis mark.kette...@xs4all.nl [2014-05-15 00:15]: I don't think this is a good idea; didn't we establish the other day that ifconfig if eui64 already did what your +inet6 does? almost, it's ifconfig if inet6 eui64 - but that isn't all THAT intuitive. I like +inet6 as the opposite of

Re: NOINET6 by default

2014-05-14 Thread Stuart Henderson
On 2014/05/15 00:13, Mark Kettenis wrote: Date: Wed, 14 May 2014 23:29:20 +0200 From: Henning Brauer lists-openbsdt...@bsws.de this diff fixes that. well, really two independent parts. one: set the NOINET6 flag by default on each and every interface. ok on that bit two: implement

Re: NOINET6 by default

2014-05-14 Thread Henning Brauer
* Alexander Bluhm alexander.bl...@gmx.net [2014-05-15 00:15]: On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote: so as discussed recently having the inet6 link-local addrs on every interface by default is stupid and a security risk. Connecting a computer to the internet is a

Re: What platforms grow the stack upwards?

2014-05-14 Thread Stuart Henderson
On 2014/05/15 00:47, Juan Francisco Cantero Hurtado wrote: I have not found a complete list with this information. Can someone tell me what OpenBSD platforms grow the stack upwards? hppa

Re: NOINET6 by default

2014-05-14 Thread Reyk Flöter
On 15.05.2014, at 00:46, Henning Brauer lists-openbsdt...@bsws.de wrote: * Mark Kettenis mark.kette...@xs4all.nl [2014-05-15 00:15]: I don't think this is a good idea; didn't we establish the other day that ifconfig if eui64 already did what your +inet6 does? almost, it's ifconfig if

Re: NOINET6 by default

2014-05-14 Thread Alexander Hall
On 05/15/14 00:48, Henning Brauer wrote: * Alexander Bluhm alexander.bl...@gmx.net [2014-05-15 00:15]: On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote: so as discussed recently having the inet6 link-local addrs on every interface by default is stupid and a security risk.

Re: NOINET6 by default

2014-05-14 Thread Stuart Henderson
On 2014/05/14 23:47, Stuart Henderson wrote: On 2014/05/15 00:13, Mark Kettenis wrote: Date: Wed, 14 May 2014 23:29:20 +0200 From: Henning Brauer lists-openbsdt...@bsws.de this diff fixes that. well, really two independent parts. one: set the NOINET6 flag by default on each and

Re: libcrypto: stop some ASN.1 bleeding

2014-05-14 Thread macdonellba
Miod Vallat m...@online.fr writes: ... or, in other words, try to fix most memory leak upon failure. This kind of change is difficult to test, the more eyes reviewing it, the better. Well, I'll try to take a stab at it then. Miod Index: a_gentm.c

Re: NOINET6 by default

2014-05-14 Thread Henning Brauer
* Reyk Flöter reyk.floe...@googlemail.com [2014-05-15 01:04]: On 15.05.2014, at 00:46, Henning Brauer lists-openbsdt...@bsws.de wrote: * Mark Kettenis mark.kette...@xs4all.nl [2014-05-15 00:15]: I don't think this is a good idea; didn't we establish the other day that ifconfig if eui64

Re: What platforms grow the stack upwards?

2014-05-14 Thread Miod Vallat
I have not found a complete list with this information. Can someone tell me what OpenBSD platforms grow the stack upwards? grep MACHINE_STACK_GROWS_UP /usr/src/sys/arch/*/include/param.h

Re: NOINET6 by default

2014-05-14 Thread Todd T. Fries
Penned by Henning Brauer on 20140514 22:48.16, we have: | * Reyk Flöter reyk.floe...@googlemail.com [2014-05-15 01:04]: | On 15.05.2014, at 00:46, Henning Brauer lists-openbsdt...@bsws.de wrote: | * Mark Kettenis mark.kette...@xs4all.nl [2014-05-15 00:15]: | I don't think this is a good idea

Re: recvmsg, fd passing and soreceive

2014-05-14 Thread Jérémie Courrèges-Anglas
Matthew Dempsky matt...@dempsky.org writes: On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas j...@wxcvbn.org wrote: if (cmsg-cmsg_len == CMSG_LEN(sizeof(int)) cmsg-cmsg_level == SOL_SOCKET

Re: libcrypto: stop some ASN.1 bleeding

2014-05-14 Thread Miod Vallat
... or, in other words, try to fix most memory leak upon failure. This kind of change is difficult to test, the more eyes reviewing it, the better. Well, I'll try to take a stab at it then. You might be able to use ASN1_STRING_set(ret, NULL, len) to handle resizing / allocating the

Re: NOINET6 by default

2014-05-14 Thread Jérémie Courrèges-Anglas
Paul de Weerd we...@weirdnet.nl writes: [...] This makes a whole lot of sense to me. Please make OpenBSD the first OS to do (this part of) v6 in a sensible way. Actually that makes me laugh. Sensible, weeeh. Let's protect our users from the dangers of IPv6 link-local addresses! Wait, what

Re: recvmsg, fd passing and soreceive

2014-05-14 Thread Philip Guenther
On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas j...@wxcvbn.orgwrote: ... So here's the diff I came up with: - set MSG_TRUNC for atomic protocols only if there is actually a data loss - drop the remaining mbuf(s) if the protocol is atomic *or* it is an empty message I'm

Re: recvmsg, fd passing and soreceive

2014-05-14 Thread Philip Guenther
On Wed, May 14, 2014 at 10:02 PM, Philip Guenther guent...@gmail.comwrote: On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas j...@wxcvbn.orgwrote: ... So here's the diff I came up with: - set MSG_TRUNC for atomic protocols only if there is actually a data loss - drop the

libedit patch

2014-05-14 Thread Eitan Adler
Hi all, The following patch has been committed in various forms to NetBSD and FreeBSD. I ported it to OpenBSD and 'mildly' tested it. I'm hoping someone on this list could pick this patch up, make sure it fully conforms to OpenBSD style, and commits it. For additional context: this patch