Re: divert(4) without mbuf tags

2014-07-09 Thread Alexander Bluhm
On Tue, Jul 08, 2014 at 11:39:12PM -0400, Lawrence Teo wrote: #ifdef INET6 case AF_INET6: - if (divert6_packet(pd.m, pd.dir) == 0) + if (!divert6_packet(pd.m, pd.dir, r-divert_packet.port)) *m0 = NULL;

uninitialized memory smtpd table_api.c

2014-07-09 Thread Martijn van Duren
Hello tech@, I send this patch in to m...@opensmtpd.org a couple of days ago, but since there is a hackathon ongoing I thought I might send it here as well. When running against the sqlite backend I noticed that multiple chained aliases/virtual users I would receive an invalid user. This turned

Re: divert(4) without mbuf tags

2014-07-09 Thread Reyk Floeter
On Tue, Jul 08, 2014 at 11:39:12PM -0400, Lawrence Teo wrote: The current divert(4) implementation allocates an mbuf tag in pf_test() to store the divert port specified by a divert-packet PF rule. The divert_packet() function then looks up that mbuf tag to retrieve the divert port number

Re: divert(4) without mbuf tags

2014-07-09 Thread Henning Brauer
* Reyk Floeter r...@openbsd.org [2014-07-09 11:21]: Nice one. indeed. Does anyone have an idea why the mbuf tag was added in the first place? Maybe henning's PF shuffling removed the need for it. while not impossible, I doubt it. looks like a copy paste issue. ok -- Henning Brauer,

kill unused shutdown hook pointers

2014-07-09 Thread Martin Pieuchot
ok? Index: dev/ata/wdvar.h === RCS file: /cvs/src/sys/dev/ata/wdvar.h,v retrieving revision 1.20 diff -u -p -r1.20 wdvar.h --- dev/ata/wdvar.h 11 Jun 2013 16:42:14 - 1.20 +++ dev/ata/wdvar.h 9 Jul 2014 10:52:35 -

Re: diff: Option to use duids in /etc/dumpdates

2014-07-09 Thread Alexander Hall
On 07/08/14 19:36, Maximilian Fillinger wrote: Hi! This diff adds a -U flag to dump that allows using disklabel UIDs in /etc/dumpdates. That makes incremental dumps possible when a disk is roaming between device files. I like the idea. I would have liked to read an explanation for the

diff: dhcpd on DLT_LOOP interfaces

2014-07-09 Thread YASUOKA Masahiko
Hi, Some users of npppd(8) want to use dhcpd(8) on tunneling interface to provide additional routing entries and so on to VPN clients. So I'd like to make the dhcpd work on the DLT_LOOP interfaces. comment or ok? Make dhcpd(8) work on the DLT_LOOP interfaces. worked with Yuuichi Someya

diff: fix dhcpinform to work without lease

2014-07-09 Thread YASUOKA Masahiko
This diff fixes dhcpinform to work without lease. ok? Fix dhcpinform to work without lease. Diff from Yuuichi Someya. Index: usr.sbin/dhcpd/dhcp.c === RCS file: /disk/cvs/openbsd/src/usr.sbin/dhcpd/dhcp.c,v retrieving revision

Kill unused (cached) routes

2014-07-09 Thread Martin Pieuchot
While looking at route refcounting issues I found some unused fields... Ok to kill them? Index: net/if_gif.h === RCS file: /cvs/src/sys/net/if_gif.h,v retrieving revision 1.10 diff -u -p -r1.10 if_gif.h --- net/if_gif.h21

Re: Kill unused (cached) routes

2014-07-09 Thread Bret Lambert
On Wed, Jul 09, 2014 at 04:52:06PM +0200, Martin Pieuchot wrote: While looking at route refcounting issues I found some unused fields... Ok to kill them? These appear to have been part of a plan of deep and evil magic; the diff appears okay to me on purely visual inspection, at least.

Re: Kill unused (cached) routes

2014-07-09 Thread Claudio Jeker
On Wed, Jul 09, 2014 at 04:56:13PM +0200, Bret Lambert wrote: On Wed, Jul 09, 2014 at 04:52:06PM +0200, Martin Pieuchot wrote: While looking at route refcounting issues I found some unused fields... Ok to kill them? These appear to have been part of a plan of deep and evil magic; the

Re: increase netcat's buffer...

2014-07-09 Thread Arne Becker
Hi. -err(1, bind failed); +errx(1, bind failed: %s, strerror(errno)); freeaddrinfo(ares); This doesn't seem necessary, or correct. Indeed. New patch below. @@ -640,7 +648,7 @@ timeout_connect(int s, const struct sock if (timeout !=

Re: increase netcat's buffer...

2014-07-09 Thread Ted Unangst
On Wed, Jul 09, 2014 at 18:33, Arne Becker wrote: atelnet uses atomicio, which depends on blocking sockets. Since we call atelnet from readwrite, the sockets are likely non-blocking. If we enter the for()-loop in atelnet, we set the sockets to blocking and remember that, so we do it only once.

new relayd(8) filter rules

2014-07-09 Thread Reyk Floeter
Hi, I just committed a big change to relayd: the new filtering language. tl;dr - I need your help! Please test the new filter rules in relayd -current to eliminate any remaining issues in the new implementation. When I wrote the HTTP support in relayd, I needed a way to filter and manipulate

Re: diff: fix dhcpinform to work without lease

2014-07-09 Thread YASUOKA Masahiko
On Wed, 9 Jul 2014 19:08:09 +0200 Kenneth Westerback kwesterb...@gmail.com wrote: On 9 July 2014 16:26, YASUOKA Masahiko yasu...@yasuoka.net wrote: This diff fixes dhcpinform to work without lease. ok? Fix dhcpinform to work without lease. Diff from Yuuichi Someya. This seems to be a

Re: diff: Option to use duids in /etc/dumpdates

2014-07-09 Thread Maximilian Fillinger
Thanks for your feedback! I like the idea. I would have liked to read an explanation for the selected solution though, or a brief description of it. I'll add a description below for the benefit of other readers. I think adding a check to make sure there is a nonzero duid [...] is

Re: Paravirtualized optimizations for KVM

2014-07-09 Thread Stefan Fritsch
On Tuesday 08 July 2014 23:53:21, Mark Kettenis wrote: Are these paravirtualization APIs stable? Are they (properly) documented somewhere? Mostly. So far, I am using three things: 1) the paravirtualized EOI. Documented in Documentation/virtual/kvm/msr.txt in linux source. 2) the MSR to write

asn1 free null

2014-07-09 Thread Ted Unangst
just like libc free(), asn1_string_free can cope with null. so don't bother with polluting the callers with such tests. Index: asn1/a_bytes.c === RCS file: /cvs/src/lib/libssl/src/crypto/asn1/a_bytes.c,v retrieving revision 1.14 diff

pcidevs: add devices for Vortex86EX SoC

2014-07-09 Thread SASANO Takayoshi
Hello, here is device list for DMP Vortex86EX SoC. ok? Index: pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1730 diff -u -p -r1.1730 pcidevs --- pcidevs 8 Jul 2014 08:55:33 - 1.1730 +++

Re: diff: Option to use duids in /etc/dumpdates

2014-07-09 Thread Alexander Hall
On 07/09/14 21:13, Maximilian Fillinger wrote: Thanks for your feedback! I like the idea. I would have liked to read an explanation for the selected solution though, or a brief description of it. I'll add a description below for the benefit of other readers. I think adding a check to make

bpf_mtap_stripvlan

2014-07-09 Thread Henning Brauer
so dlg noticed that tcpdump on vlan is now somewhat busted, specifically dhc* don't work on the any more. the reason is that bpf now sees the ether_vlan_header instead of the ether_header. only visible if your NIC does NOT have hw vlan tagging. reason: while we previously would prepend an ethernet

ppb driver not configured

2014-07-09 Thread sven falempin
Dear tech@, Running a somewhat recent snapshot the pericom device behave differently, as the dmesg say : ppb5 at pci5 dev 0 function 0 vendor Pericom, unknown product 0xe111 rev 0x02: not configured by system firmware instead of ppb5 at pci5 dev 0 function 0 vendor Pericom, unknown product 0xe111

divert(4) checksum offload

2014-07-09 Thread Lawrence Teo
Packets that are reinjected via a divert(4) socket will have their IP and protocol checksums recalculated, since the userspace application could have modified them. Currently, these checksums are manually recalculated by divert_output(). But now that the new checksum offloading system is in

Re: ftp(1) User-Agent

2014-07-09 Thread Lawrence Teo
About a month ago, I sent a diff that allows ftp(1) to set its User-Agent. Based on feedback from halex@ and deraadt@, I have changed it so that the User-Agent can be set via a -U command-line option instead of an environment variable. I have also fixed a conflict with guenther@'s recent fetch.c

sk(4): jumbo mbufs and rxring accounting

2014-07-09 Thread David Gwynne
this is an update of if_sk.c r1.151, which tried to introduce mclgeti. it updates it to use the if_rxring accounting. does anyone have one they can test this on? it also saves about 2k on amd64. Index: if_sk.c === RCS file: