Re: ldattach -t for msts line discipline

2014-08-02 Thread Maurice Janssen
On Fri, Aug 01, 2014 at 01:26:46PM +0200, Maurice Janssen wrote: Hi, I have a time receiver that sends time information in MSTS format to the serial port of an OpenBSD system. The receiver sends 1 PPS pulses on the DCD pin and I'm trying to use these pulses to increase the accuracy (not that a

Re: [PATCH]unused NULL check before calling free

2014-08-02 Thread Fritjof Bornebusch
On Fri, Aug 01, 2014 at 08:03:58AM -0400, Ted Unangst wrote: Half true. :) The behavior is intended. I don't really know why they care about freeing null, but the intention is clearly to check for it; otherwise they would just call free() in the first place. (actually, i think the rationale

Re: [PATCH] Better overflow handling in rcstime.c

2014-08-02 Thread Fritjof Bornebusch
On Wed, Jul 30, 2014 at 09:26:54PM +0100, Dimitris Papastamos wrote: On Wed, Jul 30, 2014 at 10:19:19PM +0200, Fritjof Bornebusch wrote: + tzone = (int)strtonum(h, -23, 23, errstr); The explicit cast is not needed here. That's maybe true, but I don't like implicit casts. :)