Re: syslog over TLS

2015-01-16 Thread Reyk Floeter
On Fri, Jan 16, 2015 at 01:46:09AM +0100, Alexander Bluhm wrote: Hi, This diff enables sending syslog messages over TLS. To implement the buffer layer, I have copied evbuffer.c from libevent and changed TCP to TLS where necessary. This way I made a buffertls wrapper around bufferevent.

Re: syslog over TLS

2015-01-16 Thread Nicholas Marriott
Hi WRT libevent - we have already added some ASR functions to libevent for smtpd, I'd say libevent 1.4 is pretty much closed for new development upstream - there won't be much to sync - and we have a port of 2.x for ports to use. So I don't think there are strong reasons not to change our

Re: syslog over TLS

2015-01-16 Thread Reyk Floeter
On Fri, Jan 16, 2015 at 09:11:47AM +, Nicholas Marriott wrote: Hi WRT libevent - we have already added some ASR functions to libevent for smtpd, I'd say libevent 1.4 is pretty much closed for new development upstream - there won't be much to sync - and we have a port of 2.x for ports to

Document the special case pid=0 in kill(1)

2015-01-16 Thread Theo Buehler
POSIX says: If process number 0 is specified, all processes in the current process group shall be signaled. Add the corresponding line from kill.2 to document this case. Index: kill.1 === RCS file: /cvs/src/bin/kill/kill.1,v

Re: syslog over TLS

2015-01-16 Thread Dongsheng Song
On Fri, Jan 16, 2015 at 8:46 AM, Alexander Bluhm alexander.bl...@gmx.net wrote: - Wrong format. The TLS RFC requires length-message encoding, I use message-newline inherited from TCP. Transmission of Syslog Messages over TCP (RFC 6587) prefer use 'octet-counting', not

[patch] siphash static functions

2015-01-16 Thread Fritjof Bornebusch
Hi tech@, aren't these functions supposed to be static? fritjof Index: siphash.c === RCS file: /cvs/src/sys/crypto/siphash.c,v retrieving revision 1.1 diff -u -p -r1.1 siphash.c --- siphash.c 4 Nov 2014 03:01:14 - 1.1

Re: syslog over TLS

2015-01-16 Thread Alexander Bluhm
On Fri, Jan 16, 2015 at 06:17:01PM +0800, Dongsheng Song wrote: On Fri, Jan 16, 2015 at 8:46 AM, Alexander Bluhm alexander.bl...@gmx.net wrote: - Wrong format. The TLS RFC requires length-message encoding, I use message-newline inherited from TCP. Transmission of Syslog Messages over

Re: syslog over TLS

2015-01-16 Thread Alexander Bluhm
On Fri, Jan 16, 2015 at 01:46:09AM +0100, Alexander Bluhm wrote: This diff enables sending syslog messages over TLS. Updated diff after sys/param.h commit. Only some context changed. bluhm Index: usr.sbin/syslogd/Makefile === RCS

recognise 'F'/'f' suffix in indent

2015-01-16 Thread Jonathan Gray
Floating point constants default to double precision and can be made single precision with a 'f' or 'F' suffix or long double precision with 'l' or 'L'. It turns out indent only knows about 'u'/'U' and 'l'/'L' suffixes and will add a space between floating point constants and the suffix if 'f' or

Re: syslog over TLS

2015-01-16 Thread Theo de Raadt
I just don't think that adding a specific dependency for libtls/libssl/libcrypto to libevent is the right direction. Let's not get hung up on how this code will fit into the libtls picture yet. It is very valuable that Alexander can get it the async tls case perfected for the syslogd case,

Re: syslog over TLS

2015-01-16 Thread Reyk Floeter
On Fri, Jan 16, 2015 at 12:56:45PM +0100, Alexander Bluhm wrote: On Fri, Jan 16, 2015 at 01:46:09AM +0100, Alexander Bluhm wrote: This diff enables sending syslog messages over TLS. Updated diff after sys/param.h commit. Only some context changed. bluhm Despite my scepticism about

[patch] remove atoi(3) from keynote

2015-01-16 Thread Fritjof Bornebusch
Hi tech@, this diff removes the atoi(3) call from keynote(1). fritjof Index: keynote-keygen.c === RCS file: /cvs/src/lib/libkeynote/keynote-keygen.c,v retrieving revision 1.21 diff -u -p -r1.21 keynote-keygen.c ---

Re: recognise 'F'/'f' suffix in indent

2015-01-16 Thread Miod Vallat
Floating point constants default to double precision and can be made single precision with a 'f' or 'F' suffix or long double precision with 'l' or 'L'. It turns out indent only knows about 'u'/'U' and 'l'/'L' suffixes and will add a space between floating point constants and the suffix if

Re: recognise 'F'/'f' suffix in indent

2015-01-16 Thread Ted Unangst
On Fri, Jan 16, 2015 at 21:43, Miod Vallat wrote: Floating point constants default to double precision and can be made single precision with a 'f' or 'F' suffix or long double precision with 'l' or 'L'. It turns out indent only knows about 'u'/'U' and 'l'/'L' suffixes and will add a space

improve wording in alloca

2015-01-16 Thread Ted Unangst
Improve wording in alloca. 1. it's not a bug; it's a caveat. 2. slightly unsafe gives me the willies. 3. nobody knows what large unbounded allocations are. 4. one .Xr to malloc should suffice Index: alloca.3 === RCS file:

Re: improve wording in alloca

2015-01-16 Thread Theo de Raadt
@@ -51,9 +51,7 @@ function returns a pointer to the beginn .Sh SEE ALSO .Xr pagesize 1 , .Xr brk 2 , -.Xr calloc 3 , -.Xr malloc 3 , -.Xr realloc 3 +.Xr malloc 3 This is good. It has no relationship to callor or realloc. -.Sh BUGS +.Sh CAVEATS OK. The .Fn alloca -function is

Re: massage volume control task

2015-01-16 Thread Jim Smith
On 2 Jan 2015, at 4:15 pm, David Gwynne da...@gwynne.id.au wrote: can someone test this? it allocates storage for the volume change details rather than cast arguments to a single global task. adds some safety while there if audio0 is a hotplug device. ok? The keyboard audio controls

Re: recognise 'F'/'f' suffix in indent

2015-01-16 Thread Jonathan Gray
On Fri, Jan 16, 2015 at 09:43:36PM +, Miod Vallat wrote: Floating point constants default to double precision and can be made single precision with a 'f' or 'F' suffix or long double precision with 'l' or 'L'. It turns out indent only knows about 'u'/'U' and 'l'/'L' suffixes and

[patch] panic on boot when compiling kernel with option VFSLCKDEBUG

2015-01-16 Thread Helg
While troubleshooting a deadlock problem I compiled the kernel with option VFSLCKDEBUG and found that the if statement in the assert macro is missing braces. The includes seem to have changed since 5.6 as well as it was missing the declaration for the panic function. Index: kern/vfs_vops.c

tiny ftp cleanup

2015-01-16 Thread Ted Unangst
Remember to set tenex mode when transferring binary files from this machine. Just a little cleanup. Unfortunately, my TOPS20 system isn't running at the moment, so I wasn't able to fully test this... bonus: this diff also removes references to ebcdic. Index: cmds.c