Re: libtls manpage diff

2015-04-01 Thread Joel Sing
On Tuesday 31 March 2015, Tim van der Molen wrote: > - Correct title. > - tls_accept_socket() also may return TLS_{READ,WRITE}_AGAIN. I've committed a slightly different version of this and fixed the title - thanks for the diff. > Index: tls_init.3 > =

Re: add m_defrag to pcn driver

2015-04-01 Thread David Gwynne
SSH is usually pretty good at it, but dropping the tx dmamap segments helps a lot as Kim said. On 2 Apr 2015 9:45 am, "Kimberley Manning" wrote: > On 02/04/15 07:51, Stefan Fritsch wrote: > >> On Wednesday 01 April 2015 12:46:47, Kimberley Manning wrote: >> >>> This diff makes the pcn driver use

Re: add support for "crc_enabled" Elantech v3 touchpads

2015-04-01 Thread Fasse
On Wed, 01 Apr 2015 21:23:15 +0200 Ulf Brosziewski wrote: > Yes, without some refactoring there won't be an elegant way. > pms_sync_elantech_v2 encodes some sync state in the 'flags' field > (ELANTECH_F_2FINGER_PACKET), but doing the same in the v3/CRC case might > be ugly. Admittedly I am biased

Re: Use LIST for upd(4) sensors

2015-04-01 Thread David Higgs
On Apr 1, 2015, at 9:23 AM, David Higgs wrote: > On Wed, Apr 1, 2015 at 7:52 AM, Martin Pieuchot wrote: > On 31/03/15(Tue) 23:06, David Higgs wrote: > > This was much more straightforward than expected. > > > > - Replace an array with a LIST of allocated sensors. > > - Remove or rescope variable

Re: add m_defrag to pcn driver

2015-04-01 Thread Kimberley Manning
On 02/04/15 07:51, Stefan Fritsch wrote: On Wednesday 01 April 2015 12:46:47, Kimberley Manning wrote: This diff makes the pcn driver use m_defrag for fragmented mbuf chains,> I like this kind of cleanups. As for vio(4) could you try the diff or are you looking for testers? Thanks. I've tri

Re: add m_defrag to pcn driver

2015-04-01 Thread Stefan Fritsch
On Wednesday 01 April 2015 12:46:47, Kimberley Manning wrote: > > > This diff makes the pcn driver use m_defrag for fragmented mbuf > > > chains,> > > > > > > I like this kind of cleanups. As for vio(4) could you try the > > diff or are you looking for testers? > > Thanks. I've tried both the vi

Re: add support for "crc_enabled" Elantech v3 touchpads

2015-04-01 Thread Ulf Brosziewski
On 04/01/2015 08:46 PM, Fasse wrote: On Wed, 01 Apr 2015 20:05:46 +0200 Ulf Brosziewski wrote: Hi, there might be a problem. The Linux driver for that touchpad type also accepts "debounce packets", which have the same format as for the non-crc version. I have no idea whether that is correct a

Re: sort: another mkstemp use case

2015-04-01 Thread Todd C. Miller
On Wed, 01 Apr 2015 21:55:14 +0200, Tobias Stoeckmann wrote: > When creating a new temporary file name, use mkstemp instead of just > taking a rather predictable path, which could even be a symlink by > a malicious user (granted, that is very unlikely). Heh, you beat me to that one. I'm going to

sort: another mkstemp use case

2015-04-01 Thread Tobias Stoeckmann
When creating a new temporary file name, use mkstemp instead of just taking a rather predictable path, which could even be a symlink by a malicious user (granted, that is very unlikely). Index: file.c === RCS file: /cvs/src/usr.bin/so

Re: add support for "crc_enabled" Elantech v3 touchpads

2015-04-01 Thread Fasse
On Wed, 01 Apr 2015 20:05:46 +0200 Ulf Brosziewski wrote: > Hi, > > there might be a problem. The Linux driver for that touchpad type also > accepts "debounce packets", which have the same format as for the > non-crc version. I have no idea whether that is correct and if those > packets do occur

Re: add support for "crc_enabled" Elantech v3 touchpads

2015-04-01 Thread Ulf Brosziewski
Hi, there might be a problem. The Linux driver for that touchpad type also accepts "debounce packets", which have the same format as for the non-crc version. I have no idea whether that is correct and if those packets do occur in practice, but if they do they wouldn't pass this version of sync()

if_input() design and next step

2015-04-01 Thread Martin Pieuchot
One of the interesting things we've done during s2k15 was to redesign ether_input(). The name of this function is clearly misleading. Back in the old days [0] it was simply used to put a packet on a protocol queue. Today ether_input() still does that, but before it does a lot of different hacks

Re: add support for "crc_enabled" Elantech v3 touchpads

2015-04-01 Thread Fasse
On Wed, 1 Apr 2015 18:02:59 +0200 Stefan Sperling wrote: > Interesting, thanks. > > If you don't hear from anyone else about this please ask me again in > a week from now. I can test on v3 hardware by then but not any earlier. > > Please write this as if-else instead of switch: > > > @@ -2271,1

Re: add support for "crc_enabled" Elantech v3 touchpads

2015-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2015 at 05:44:16PM +0200, Fasse wrote: > This diff adds support for Elantech v3 touchpads using the "crc_enabled" > integrity check. I tested this patch with my Elantech v3 touchpad using > firmware version 0x454f00, it now works correctly. > Other hardware versions should not be a

add support for "crc_enabled" Elantech v3 touchpads

2015-04-01 Thread Fasse
This diff adds support for Elantech v3 touchpads using the "crc_enabled" integrity check. I tested this patch with my Elantech v3 touchpad using firmware version 0x454f00, it now works correctly. Other hardware versions should not be affected by this change. I could not check if this introduces re

if_input() and `rcvif`

2015-04-01 Thread Martin Pieuchot
When if_input_process() will pass a mbuf to pseudo-interface handlers, they will change the `rcvif` pointer in the packet header. That's why we should not pass a ifp pointer to the handlers and instead let them look at the value of `rcvif`. Diff below change if_input() and ether_input() to no lon

Re: Use LIST for upd(4) sensors

2015-04-01 Thread David Higgs
On Wed, Apr 1, 2015 at 7:52 AM, Martin Pieuchot wrote: > On 31/03/15(Tue) 23:06, David Higgs wrote: > > This was much more straightforward than expected. > > > > - Replace an array with a LIST of allocated sensors. > > - Remove or rescope variables counting sensors. > > - Allocated sensors are al

Re: add m_defrag to pcn driver

2015-04-01 Thread Kimberley Manning
Martin Pieuchot openbsd.org> writes: > On 31/03/15(Tue) 21:56, Kimberley Manning wrote: > > Hi, > > > > This diff makes the pcn driver use m_defrag for fragmented mbuf chains, > > I like this kind of cleanups. As for vio(4) could you try the diff or > are you looking for testers? Thanks. I've

kernel with gif(4)

2015-04-01 Thread Martin Pieuchot
I'd like to be able to easily identify how deep are the tentacles of a pseudo-driver in your network stack. This diff takes the example of gif(4) and move all the remaining blocks checking for "IFT_GIF" under the appropriate #ifdef dance. The #ifdef I'm adding below are not strictly needed to com

Re: Use LIST for upd(4) sensors

2015-04-01 Thread Martin Pieuchot
On 31/03/15(Tue) 23:06, David Higgs wrote: > This was much more straightforward than expected. > > - Replace an array with a LIST of allocated sensors. > - Remove or rescope variables counting sensors. > - Allocated sensors are always attached. > - Drop an unnecessary size calculation. Do you nee

Re: add m_defrag to pcn driver

2015-04-01 Thread Martin Pieuchot
On 31/03/15(Tue) 21:56, Kimberley Manning wrote: > Hi, > > This diff makes the pcn driver use m_defrag for fragmented mbuf chains, I like this kind of cleanups. As for vio(4) could you try the diff or are you looking for testers? Are you after something specific or are you changing the drivers