Re: iwm(4) fix

2015-05-21 Thread Claudio Jeker
On Fri, May 22, 2015 at 12:39:20AM +0200, Mark Kettenis wrote: > The Tx descriptors have 20 "scatter-gather" slots, but two of those > are used to transfer the command, so only 18 remain for the actual > packet data. So limit the number of dma segments to IWM_NUM_OF_TBS - 2. > We use the same appr

Re: ftp(1) rewrite

2015-05-21 Thread Ted Unangst
Sunil Nimmagadda wrote: > Hi, > > The idea is to start with the subset of ftp(1) functionality needed > by pkg_add(1): > > ftp [-o output] url ... > > i.e., should be able to download files over HTTP(S) and FTP. > > This implementation works as FETCH_CMD for pkg_add(1) over HTTP(S). > > FTP is

iwm(4) fix

2015-05-21 Thread Mark Kettenis
The Tx descriptors have 20 "scatter-gather" slots, but two of those are used to transfer the command, so only 18 remain for the actual packet data. So limit the number of dma segments to IWM_NUM_OF_TBS - 2. We use the same approach in iwn(4), except that there only one slot is used for the command

Re: mismatch for ICMP state created by inound response

2015-05-21 Thread Alexandr Nedvedicky
Hello, > > Well, not entirely (: I did it while exploring the code and sent > out to provoke further discussion. Today I've talked to reyk@ and > we think that it's better to go down a different road: make sure we > don't create states on reply packets in the first place. > that's actually ver

ftp(1) rewrite

2015-05-21 Thread Sunil Nimmagadda
Hi, The idea is to start with the subset of ftp(1) functionality needed by pkg_add(1): ftp [-o output] url ... i.e., should be able to download files over HTTP(S) and FTP. This implementation works as FETCH_CMD for pkg_add(1) over HTTP(S). FTP is not yet done, but thinking of implementing just

Re: pf_create_state() is sometimes better to use pf_unlink_state()

2015-05-21 Thread Alexandr Nedvedicky
Hello, On Thu, May 21, 2015 at 07:43:51PM +0200, Mike Belopuhov wrote: > On Thu, May 21, 2015 at 17:34 +0200, Alexandr Nedvedicky wrote: > > Hello, > > > > Hi, > > > snippet below comes from pf_create_state(): > > > >3559 if (pf_state_insert(BOUND_IFACE(r, pd->kif), skw, sks, s)) {

Re: pf_create_state() is sometimes better to use pf_unlink_state()

2015-05-21 Thread Mike Belopuhov
On Thu, May 21, 2015 at 17:34 +0200, Alexandr Nedvedicky wrote: > Hello, > Hi, > snippet below comes from pf_create_state(): > >3559 if (pf_state_insert(BOUND_IFACE(r, pd->kif), skw, sks, s)) { >3560 pf_state_key_detach(s, PF_SK_STACK); >3561 p

Re: mismatch for ICMP state created by inound response

2015-05-21 Thread Mike Belopuhov
On Thu, May 21, 2015 at 11:07 +0200, Alexandr Nedvedicky wrote: > Hello, > > > On Tue, May 19, 2015 at 14:07 +0200, Alexandr Nedvedicky wrote: > > > Hello Mike, > > > > > > I've reworked patch from yesterday. I've done some quick testing > > > to see if it fixes problem. It looks like it works. I

pf_create_state() is sometimes better to use pf_unlink_state()

2015-05-21 Thread Alexandr Nedvedicky
Hello, snippet below comes from pf_create_state(): 3559 if (pf_state_insert(BOUND_IFACE(r, pd->kif), skw, sks, s)) { 3560 pf_state_key_detach(s, PF_SK_STACK); 3561 pf_state_key_detach(s, PF_SK_WIRE); 3562 *sks = *skw = NULL; 3

pf.conf from/to negation homogeneous behavior

2015-05-21 Thread sven falempin
Dear Tech, I propose Index: pfctl/parse.y === RCS file: /cvs/src/sbin/pfctl/parse.y,v retrieving revision 1.648 diff -u -p -r1.648 parse.y --- pfctl/parse.y 21 Apr 2015 16:34:59 - 1.648 +++ pfctl/parse.y 21 May 2

Re: More if_output()

2015-05-21 Thread sven falempin
On Tue, May 19, 2015 at 6:49 AM, Martin Pieuchot wrote: > On 15/05/15(Fri) 15:53, Martin Pieuchot wrote: > > Some more if_output() conversion. The xl bits are here because I'd > > like to reduce the number of places where IFQ_ENQUEUE() is used. > > > > After applying this diff you should only ha

Pf bikeshedding diff #2: cut down on those ifs

2015-05-21 Thread Mike Belopuhov
Like really! OK? Sanity checked by blambert. diff --git sys/net/pf.c sys/net/pf.c index d4cb67c..2ba04d5 100644 --- sys/net/pf.c +++ sys/net/pf.c @@ -4488,21 +4488,16 @@ pf_test_state_icmp(struct pf_pdesc *pd, struct pf_state **state, * Search for an ICMP state.

Pf bikeshedding diff #1: PF_ICMP_MULTI_LINK is just a flag

2015-05-21 Thread Mike Belopuhov
While looking into Alexandr's report I made a few nits that I consider worth getting in. This is the first one. multi is just a flag these days (for better or worse), so having a enum and a store in pf_icmp_mapping is pointless since the usage is always the same: try looking up an ICMP state usin

Re: mismatch for ICMP state created by inound response

2015-05-21 Thread Alexandr Nedvedicky
Hello, > On Tue, May 19, 2015 at 14:07 +0200, Alexandr Nedvedicky wrote: > > Hello Mike, > > > > I've reworked patch from yesterday. I've done some quick testing > > to see if it fixes problem. It looks like it works. I have not > > tested NAT-64 yet. Also I'd like to come up with test case, whic

Re: ospfd announces carp interface with physical link down

2015-05-21 Thread Martin Pieuchot
On 20/05/15(Wed) 14:14, Johan Ymerson wrote: > [...] > The patch did not apply cleanly to OPENBSD_5_7, I rewrote the patch a > bit: Thanks, I committed my diff to -current. > With this patch everything (almost) work. At least as good as my patch > did. OSPFd still does something wrong with the li