[patch]diff: xstrdup wrappes strdup(3)

Hi tech@, as requested by nicm@, xstrdup calls strdup(3) now. Regards, --F. Index: xmalloc.c === RCS file: /cvs/src/usr.bin/diff/xmalloc.c,v retrieving revision 1.6 diff -u -p -r1.6 xmalloc.c --- xmalloc.c 29 Apr 2015 04:00:25

Re: [patch]file: xstrdup just wrappes strdup(3)

+ err(1, xstrdup); slight tweak, usually the err output is: err(1, strdup)

[patch]diff: uninitialized values

Hi tech@, *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. Regards, --F. Index: diffdir.c === RCS file: /cvs/src/usr.bin/diff/diffdir.c,v retrieving revision 1.43 diff -u -p -r1.43 diffdir.c ---

Re: [patch]diff: uninitialized values

On Wed, Jun 17, 2015 at 08:53:57PM +0200, Fritjof Bornebusch wrote: Hi tech@, *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. Such initializers hiding a false positive, cause the compiler does not understand this case can never happen. - warning: 'edp1' may be

Re: [patch]diff: xstrdup wrappes strdup(3)

Any ok for this, and the same for rcs? (And ssh?) On Wed, Jun 17, 2015 at 08:42:04PM +0200, Fritjof Bornebusch wrote: Hi tech@, as requested by nicm@, xstrdup calls strdup(3) now. Regards, --F. Index: xmalloc.c ===

[patch]file: xstrdup just wrappes strdup(3)

Hi tech@, as requested by nicm@, xstrdup calls strdup(3) now. Regards, --F. Index: xmalloc.c === RCS file: /cvs/src/usr.bin/file/xmalloc.c,v retrieving revision 1.1 diff -u -p -r1.1 xmalloc.c --- xmalloc.c 24 Apr 2015 16:24:11

[patch]ssh: xstrdup wrappes strdup(3)

Hi tech@, as requested by nicm@, xstrdup just wrappes strdup(3). Regards, --F. Index: xmalloc.c === RCS file: /cvs/src/usr.bin/ssh/xmalloc.c,v retrieving revision 1.32 diff -u -p -r1.32 xmalloc.c --- xmalloc.c 24 Apr 2015

snapshots

Snapshots will be in disarray for the next day or two as I move everything from 5.7 to 5.8-beta.

Chromium package is recording you?

Hi, On Debian lists was been reported a new version of chromium have a closed source module that activate the audio recording without the user concern. Since the chromium package are in ftp and (I think) on CD, should OpenBSD Project remove it? Here is the report:

Re: bridge_output() without m_buf_tag

On 08/06/15(Mon) 15:58, Martin Pieuchot wrote: Diff below moves bridge_output() to if_output(). It fixes the case I already described some weeks ago where you have a physical interface in a bridge and a vlan on top of it which is not in the bridge. It also change the loop prevention code to

Re: Conver bridge(4) to if_input()

On 08/06/15(Mon) 16:11, Martin Pieuchot wrote: This is the last pseudo-driver conversion. The idea is to run bridge_input() *before* any ifih on an interface. Doing so allow us to remove the hack between vlan(4) and bridge(4) and simplify the logic for stacked ifih. With that

Re: [patch]rcs: xstrdup just wrappes strdup

On Mon, Jun 15, 2015 at 10:22:27AM +0100, Nicholas Marriott wrote: What about diff and ssh and file? They all use the a copy of the same xmalloc.c. Personally, I would recommend that xstrdup just calls strdup(3), as Theo said: it's 100.00% portable. But I don't think I'm the right person

bridge(4) local broadcast fix

It makes sense to not retransmit a packet on the interface it was received from but we should still call bridge_localbroadcast() on this interface otherwise the network stack never see this packet. This fix the configuration where you have a vlan(4) on top of an interface in a bridge(4) and the

Re: [patch]rcs: no null check before free(3)

Fixed, thanks On Wed, Jun 17, 2015 at 09:51:38AM +0200, Fritjof Bornebusch wrote: Hi tech@, just saw I missed removing the null check before calling free(3), sorry. Regards, --F. Index: ci.c === RCS file:

[patch]rcs: no null check before free(3)

Hi tech@, just saw I missed removing the null check before calling free(3), sorry. Regards, --F. Index: ci.c === RCS file: /cvs/src/usr.bin/rcs/ci.c,v retrieving revision 1.220 diff -u -p -r1.220 ci.c --- ci.c13 Jun 2015

Re: Bug in uvm_pmr_get1page()?

On Tue, Jun 16, 2015 at 23:57 +0200, Mark Kettenis wrote: You're definitely on to something. It certainly looks like your diff fixes the bug. However, if there is no constraint, it would make sense to pick a page from the size tree of the right type. Not sure if that optimization would

[patch] nm segfault

Hi, I would like to report a SEGFAULT in nm(1) that occurs with object-file with no section headers (e_shnum = 0). This object-file was generated by eg++ (I am not sure if the object-file is valid or not). I am also able to reproduce the problem with edited elf object (using hte [editors/ht]) by

Re: [patch] nm segfault

On Wed, Jun 17, 2015 at 02:43:41PM +0200, Sébastien Marie wrote: Hi, I would like to report a SEGFAULT in nm(1) that occurs with object-file with no section headers (e_shnum = 0). Index: elf.c === RCS file:

[patch] nm: read after bound

Hi, This patch corrects a read after bound that occurs in strcmp (line just after the added bound check). Found with afl. -- Sébastien Marie Index: elf.c === RCS file: /cvs/src/usr.bin/nm/elf.c,v retrieving revision 1.28 diff -u

Re: [patch]rcs: xstrdup just wrappes strdup

On Wed, Jun 17, 2015 at 01:25:07PM +0200, Fritjof Bornebusch wrote: On Mon, Jun 15, 2015 at 10:22:27AM +0100, Nicholas Marriott wrote: What about diff and ssh and file? They all use the a copy of the same xmalloc.c. Personally, I would recommend that xstrdup just calls strdup(3), as