syslogd reuseaddr *:514

2015-08-31 Thread Alexander Bluhm
Hi, I had some problems running syslogd on a machine where another process had a 514 socket bound to a specific address. As this is not a real conflict, I think syslogd should bind *:514 with SO_REUSEADDR. This is already the case with all other sockets. ok? bluhm Index:

Like free(), ksh's afree() is NULL-safe

2015-08-31 Thread Michael McConville
Also, why is fs on line 390 cast to char* when afree() takes void*? Index: emacs.c === RCS file: /cvs/src/bin/ksh/emacs.c,v retrieving revision 1.50 diff -u -p -r1.50 emacs.c --- emacs.c 25 Mar 2015 12:10:52 - 1.50 +++

Re: pool allocator names

2015-08-31 Thread Ted Unangst
Mark Kettenis wrote: > > From: "Ted Unangst" > > Date: Sat, 29 Aug 2015 18:38:45 -0400 > > > > Mark Kettenis wrote: > > > This diff is purely mechanical. This means that it also changes some > > > pool_allocator_nointr into pool_allocator_single where the intention > > >

Re: remove RH0 support from ping6(8)

2015-08-31 Thread Mike Belopuhov
On 30 August 2015 at 15:44, Florian Obser wrote: > RH0 has been deprecated for quite some time now in RFC 5095. It's > quite useless on OpenBSD since our stack unconditionally drops packets > with a RH0 header so you can't get the packet out anyway. > And last but not least

Re: [PATCH] PF: cksum modification & refactor [0/24]

2015-08-31 Thread Alexandr Nedvedicky
Hello, I'm fine with this change. It certainly posses no thread to SMP branch... > * Initialise pd->pcksum for icmp6 > > - ensures pcksum is set for all known checksummed protocols > - later patches rely on this may be this patch/change should be folded to patch, which really

Re: uow patch

2015-08-31 Thread Martin Pieuchot
On 30/08/15(Sun) 09:31, John L. Scarfone wrote: > On Sun, Aug 30, 2015 at 12:32:24PM +0200, Martin Pieuchot stated: > > That's good but the original design of allocating an xfer for every > > usbd_transfer(9) call does not make much sense. > > > > You could allocate two xfers (one for read and

Re: rt_ifa_del() tweak

2015-08-31 Thread Martin Pieuchot
On 25/08/15(Tue) 13:01, Martin Pieuchot wrote: > I want to remove this chunked introduce in r7.19 in 1991 by sklower@ > because it no longer makes any sense, it is a layer violation and > does no play well with rt refcounting. > > When this chunk was introduced rtrequest1(RTM_DELETE...) was *not*

Re: tap-and-drag on ALPS touchpads

2015-08-31 Thread Alexandr Shadchin
On Sat, Aug 15, 2015 at 4:32 AM, Ulf Brosziewski < ulf.brosziew...@t-online.de> wrote: > > The tap-and-drag gesture doesn't work reliably with the ALPS touchpads > supported by pms. To make it work, it is necessary to start dragging > immediately with the second touch, which doesn't always

Re: Call for Testing: rtalloc(9) change

2015-08-31 Thread Martin Pieuchot
On 25/08/15(Tue) 12:27, Martin Pieuchot wrote: > On 12/08/15(Wed) 17:03, Martin Pieuchot wrote: > > I'm currently working on the routing table interface to make is safe > > to use by multiple CPUs at the same time. The diff below is a big > > step in this direction and I'd really appreciate if

Re: synaptics touchpads: w mode and resolution

2015-08-31 Thread Alexandr Shadchin
On Sat, Aug 29, 2015 at 6:10 PM, Ulf Brosziewski < ulf.brosziew...@t-online.de> wrote: > On 08/29/2015 01:13 PM, Alexandr Shadchin wrote: > >> On Fri, Aug 28, 2015 at 10:04:51PM +0200, Ulf Brosziewski wrote: >> >>> >>> Some weeks ago a change was made in pms to support Synaptics touchpads >>>

virtualization support

2015-08-31 Thread Mike Larkin
TL;DR - a native hypervisor is coming. stay tuned. For the last few months, I've been working on a hypervisor for OpenBSD. The idea for this started a few years ago, and after playing around with it from time to time, things really started to take shape around the time of the Brisbane hackathon

Re: syslogd host matches ip

2015-08-31 Thread Sebastien Marie
On Sun, Aug 30, 2015 at 07:18:34PM +0200, Alexander Bluhm wrote: > > I reconsidered it. It does not make sense to truncate the hostname > in the config at some character from a list. Just take whatever > the user specified as progname or hostname. > > ok? visual ok + slightly tested OK

Re: ntpd(8): Make -n quieter

2015-08-31 Thread Michael Reed
On 08/31/15 07:36, Sebastian Benoit wrote: > Michael Reed(m.r...@mykolab.com) on 2015.08.30 14:58:35 -0400: >> Hi all, >> >> If ntpd is run with the -n flag, and /etc/ntpd.conf is parsed without >> error, then "Configuration OK" is printed. I don't think this is >> particularly useful, as both a

Re: Like free(), ksh's afree() is NULL-safe

2015-08-31 Thread Ted Unangst
Michael McConville wrote: > Also, why is fs on line 390 cast to char* when afree() takes void*? this code is older than void. and NULL apparently. please remove the casts too.

Re: rt_ifa_del() tweak

2015-08-31 Thread Alexander Bluhm
On Tue, Aug 25, 2015 at 01:01:38PM +0200, Martin Pieuchot wrote: > I want to remove this chunked introduce in r7.19 in 1991 by sklower@ > because it no longer makes any sense, it is a layer violation and > does no play well with rt refcounting. > > When this chunk was introduced

[patch] in usb(4) check for dangerous requests

2015-08-31 Thread Grant Czajkowski
Hi all, This patch adds the usb control request validity checks already present in ugen(4) to usb(4). Grant Index: usb.c === RCS file: /cvs/src/sys/dev/usb/usb.c,v retrieving revision 1.107 diff -u -p -r1.107 usb.c --- usb.c

ksh sanatizing argv redundant

2015-08-31 Thread Martijn van Duren
Hello tech@, I took a quick glance at ksh and one of the first things I noticed was that it uses some sanatizing code on argv. When looking at execve(2) I see that EINVAL or EFAULT are returned when argv isn't properly formatted. I've also verified this quickly by a small PoC and in

[WIP PATCH] SR RAID1 checksumming support

2015-08-31 Thread Karel Gardas
Hello, attached my work in progress on checksumming support for softraid RAID1. Currently it does just: - computation of checksums (crc32) - verification of checksums - signal bad checksum to console and to sensors E.g.: $ sysctl hw.sensors.softraid0 hw.sensors.softraid0.raw0=0 (sd0f), OK

PF ignores block action when rule contains route-to/dup-to action

2015-08-31 Thread Alexandr Nedvedicky
Hello, Dilli Paudel in Oracle was playing with PF enough to find funny glitch. He used rule as follows: block in on vnic4 from 192.168.1.0/24 to any route-to 172.16.1.1@vnic5 Many people expect the route-to action is somewhat futile as 'block' action takes precedence here, so packet

Re: [patch] return instead of exit(3) in src/bin/

2015-08-31 Thread Fritjof Bornebusch
On Sun, Aug 30, 2015 at 08:01:02PM +0200, Fritjof Bornebusch wrote: > As suggested by deraadt@ and tobias@ it might be better to use the *return* > statement instead of exit(3) > inside the *main* function, to let the stack protector do its work. > > This diff removes such calls in all

Re: escape minus signs in sndio manpages

2015-08-31 Thread Alexandre Ratchov
On Sun, Aug 30, 2015 at 03:35:21PM -0400, Peter Piwowarski wrote: > This patch replaces some literal '-' with '\-' in examples for sndio- > related manpages. Certain roff implementations may render '-' as a > hyphen (unicode U+2010) rather than a minus sign (unicode U+002D or ascii > 0x2D); while

Re: Introducing rtvalid(9)

2015-08-31 Thread Alexander Bluhm
On Fri, Aug 28, 2015 at 12:47:51PM +0200, Martin Pieuchot wrote: > The rtvalid() function checks if the route entry rt is still valid and > can be used. Cached entries that are no longer valid should be released > by calling rtfree(). I like it. As it does some checks and returns

doas path

2015-08-31 Thread Ted Unangst
I think we can relax the path restriction if there's no restriction on command. Index: doas.c === RCS file: /cvs/src/usr.bin/doas/doas.c,v retrieving revision 1.39 diff -u -p -r1.39 doas.c --- doas.c 27 Aug 2015 16:31:02 -

Re: Like free(), ksh's afree() is NULL-safe

2015-08-31 Thread Michael McConville
Ted Unangst wrote: > Michael McConville wrote: > > Also, why is fs on line 390 cast to char* when afree() takes void*? > > this code is older than void. and NULL apparently. please remove the casts > too. Does this look good? I had to leave one cast because the freed pointer is a const. Index:

Re: Like free(), ksh's afree() is NULL-safe

2015-08-31 Thread Ted Unangst
Michael McConville wrote: > Ted Unangst wrote: > > Michael McConville wrote: > > > Also, why is fs on line 390 cast to char* when afree() takes void*? > > > > this code is older than void. and NULL apparently. please remove the casts > > too. > > Does this look good? I had to leave one cast

Re: ksh sanatizing argv redundant

2015-08-31 Thread Ted Unangst
Martijn van Duren wrote: > Hello tech@, > > I took a quick glance at ksh and one of the first things I noticed was > that it uses some sanatizing code on argv. When looking at execve(2) I > see that EINVAL or EFAULT are returned when argv isn't properly > formatted. I've also verified this

Re: ksh sanatizing argv redundant

2015-08-31 Thread Theo de Raadt
> Martijn van Duren wrote: > > Hello tech@, > > > > I took a quick glance at ksh and one of the first things I noticed was > > that it uses some sanatizing code on argv. When looking at execve(2) I > > see that EINVAL or EFAULT are returned when argv isn't properly > > formatted. I've also

myx_intr without a mutex for the sts block

2015-08-31 Thread David Gwynne
myx_intr should be able to run without a lock, except in teh situation where are bringing an interface down. this interlock was done by serialising the changes myx_down and myx_intr needed to do with a mutex, but for the many millions and billions of interrupts you get when you're actually

Re: escape minus signs in sndio manpages

2015-08-31 Thread Peter Piwowarski
Ingo Schwarze wrote: Until somebody shows me a specific list of roff implementations that do so, i challenge that statement as urban legend, and the advice to use \- for flags as cargo cult programming. The reason lintian complains about this is that Debian had problems with - rendering as a

Re: [PATCH] PF: cksum modification & refactor [3/24]

2015-08-31 Thread Alexandr Nedvedicky
Hello Richard, the code in patch looks good for the first glance. However it seems to me the newly introduced pf_cksum_fixup*() are not called yet. Do you think you can reshuffle changes between your set of patches a bit, so the newly introduced functions will become alive (get called)? Also I