Re: [patch] return instead of exit(3) in src/bin/

2015-09-17 Thread Fritjof Bornebusch
On Mon, Aug 31, 2015 at 10:59:36PM +0200, Fritjof Bornebusch wrote: > On Sun, Aug 30, 2015 at 08:01:02PM +0200, Fritjof Bornebusch wrote: > > As suggested by deraadt@ and tobias@ it might be better to use the *return* > > statement instead of exit(3) > > inside the *main* function, to let the

Re: Merge a stub file in ps(1)

2015-09-17 Thread Otto Moerbeek
On Wed, Sep 16, 2015 at 10:36:57PM -0400, Michael McConville wrote: > Michael McConville wrote: > > fmt.c contains two functions that are only called by command() in > > print.c. One of them is tiny, too. It seems simpler to have them in > > print.c as statics. > > I forgot to mention that I

ntpd.c - percision of constraint offset

2015-09-17 Thread Rob Pierce
Good day. I understand that the authenticated TLS constraints are not for percision. Nonetheless, I thought it might make sense to consider displaying the ntpctl contraint offset output with greater percision to avoid it being misleading. The text output below shows three values for the

doas closefrom

2015-09-17 Thread Ted Unangst
doas doesn't need any other open files and should probably shut them all. Index: doas.c === RCS file: /cvs/src/usr.bin/doas/doas.c,v retrieving revision 1.41 diff -u -p -r1.41 doas.c --- doas.c 3 Sep 2015 20:05:58 -

no more _subdir in man.conf

2015-09-17 Thread Jan Stary
The new man.conf does not recognize _subdir Jan Index: man.1 === RCS file: /cvs/src/usr.bin/mandoc/man.1,v retrieving revision 1.11 diff -u -p -u -p -r1.11 man.1 --- man.1 16 Feb 2015 16:18:02 - 1.11 +++

[RFC] [PATCH] Implementation of POSIX message queues

2015-09-17 Thread Dimitris Papastamos
Hi everyone, I've written a patch that adds support for POSIX message queues. I started this implementation because I wanted to play around with this API in a hobby project. The patch is not yet fully tested but the main functionality is there to warrant some feedback on both the implementation

Re: ntpd.c - percision of constraint offset

2015-09-17 Thread Philip Guenther
On Thu, Sep 17, 2015 at 8:04 AM, Rob Pierce wrote: > I understand that the authenticated TLS constraints are not for percision. > Nonetheless, I thought it might make sense to consider displaying the ntpctl > contraint offset output with greater percision to avoid it being

Re: doas closefrom

2015-09-17 Thread Sebastian Benoit
ok, but in other places we have closefrom(STDERR_FILENO + 1) Ted Unangst(t...@tedunangst.com) on 2015.09.17 12:11:26 -0400: > doas doesn't need any other open files and should probably shut them all. > > > Index: doas.c > === > RCS

Re: openvpn-2.3.8p1 segv in libcrypto BN_bn2dec on OpenBSD/i386 current Sep 16, 2015

2015-09-17 Thread Stuart Henderson
CC'ing tech@. The last commit to bn_print.c is wrong, it dereferences t while it's still NULL. Backout diff below. On 2015/09/17 22:42, Mikolaj Kucharski wrote: > Hi, > > Does anyone see this as well? I've just upgraded to: > > OpenBSD 5.8-current (GENERIC) #1164: Wed Sep 16 21:16:53 MDT

Re: doas closefrom

2015-09-17 Thread Ted Unangst
Sebastian Benoit wrote: > ok, but in other places we have closefrom(STDERR_FILENO + 1) is that really more clear? it only makes sense if you know stderr is 2. if you sometimes forget which is 1 and which is 2, then the macro only makes it more confusing because now you have to decide what comes

Re: Cache-Control for httpd

2015-09-17 Thread Craig Skinner
Hi Manuel, On 2015-09-15 Tue 14:49 PM |, Manuel Giraud wrote: > > Questions: > - Is there any interest? As a user I'm interested: http://marc.info/?l=openbsd-misc=140976806917292=2 http://marc.info/?l=openbsd-misc=143591750200748=2

Re: openvpn-2.3.8p1 segv in libcrypto BN_bn2dec on OpenBSD/i386 current Sep 16, 2015

2015-09-17 Thread Brent Cook
I think this is the right thing to do for now. ok bcook@ On Thu, Sep 17, 2015 at 5:19 PM, Stuart Henderson wrote: > CC'ing tech@. > > The last commit to bn_print.c is wrong, it dereferences t while it's still > NULL. > > Backout diff below. > > > On 2015/09/17 22:42, Mikolaj

Re: openvpn-2.3.8p1 segv in libcrypto BN_bn2dec on OpenBSD/i386 current Sep 16, 2015

2015-09-17 Thread Mikolaj Kucharski
Hi, On Thu, Sep 17, 2015 at 11:19:59PM +0100, Stuart Henderson wrote: > CC'ing tech@. > > The last commit to bn_print.c is wrong, it dereferences t while it's still > NULL. > > Backout diff below. Thanks Stuart, recompiling libcrypto with your diff fixed the problem. OpenVPN doesn't crash any

ypserv(8) cleanup

2015-09-17 Thread Michael McConville
Index: common/yplib_host.c === RCS file: /cvs/src/usr.sbin/ypserv/common/yplib_host.c,v retrieving revision 1.19 diff -u -p -r1.19 yplib_host.c --- common/yplib_host.c 11 Sep 2015 12:42:47 - 1.19 +++ common/yplib_host.c 18

Re: ntpd.c - percision of constraint offset

2015-09-17 Thread Rob Pierce
On Thu, Sep 17, 2015 at 10:53:03AM -0700, Philip Guenther wrote: > On Thu, Sep 17, 2015 at 8:04 AM, Rob Pierce wrote: > > I understand that the authenticated TLS constraints are not for percision. > > Nonetheless, I thought it might make sense to consider displaying the ntpctl > >

reuse pf state ids to "hash" packets onto trunk members

2015-09-17 Thread David Gwynne
hashing bits of packet headers to tie connections to particular physical interfaces within a trunk turns out to be fairly expensive. in my very unscientific testing it is about 20% of the cost of udp traffic generated with tcpbench -u. we could tune or change the hash. eg, going from siphash 2 4