Re: More rtisvalid(9)

2015-10-19 Thread Alexander Bluhm
On Mon, Oct 19, 2015 at 11:43:35AM +0200, Martin Pieuchot wrote: > Diff below also includes a routing table check in in_selectsrc() to > match your comment in the INET6 version of this diff. > > ok? OK bluhm@ > > Index: netinet/in_pcb.c >

Re: rtisvalid6

2015-10-19 Thread Alexander Bluhm
On Mon, Oct 19, 2015 at 11:31:32AM +0200, Martin Pieuchot wrote: > Updated version below. OK bluhm@ > > Index: netinet6/icmp6.c > === > RCS file: /cvs/src/sys/netinet6/icmp6.c,v > retrieving revision 1.172 > diff -u -p -r1.172

Kill link_rtrequest()

2015-10-19 Thread Martin Pieuchot
This function is a no-op, let's kill it. Index: net/if.c === RCS file: /cvs/src/sys/net/if.c,v retrieving revision 1.389 diff -u -p -r1.389 if.c --- net/if.c12 Oct 2015 13:17:58 - 1.389 +++ net/if.c19 Oct 2015

Purge route entries v2

2015-10-19 Thread Martin Pieuchot
Here's an updated diff to purge route entries from the routing table when the address (ifa) they are attached too is removed. To say it differently, it ensures that the life of an entry does not exceed the life of the ifa it is attached to. This works with pppoe(4)'s horrible hack and I changed

Re: rtisvalid6

2015-10-19 Thread Martin Pieuchot
On 17/10/15(Sat) 02:43, Alexander Bluhm wrote: > On Fri, Oct 16, 2015 at 04:24:04PM +0200, Martin Pieuchot wrote: > > --- netinet6/icmp6.c18 Sep 2015 14:26:22 - 1.172 > > +++ netinet6/icmp6.c16 Oct 2015 13:48:56 - > > @@ -1568,7 +1568,7 @@ icmp6_redirect_output(struct

Re: More rtisvalid(9)

2015-10-19 Thread Martin Pieuchot
On 17/10/15(Sat) 02:05, Alexander Bluhm wrote: > On Fri, Oct 16, 2015 at 03:09:03PM +0200, Martin Pieuchot wrote: > > - if (rt->rt_flags & (RTF_REJECT | RTF_BLACKHOLE) || > > - (rt->rt_flags & RTF_UP) == 0) { > > + if (!rtisvalid(rt) || ISSET(rt->rt_flags, RTF_REJECT|RTF_BLACKHOLE)) { >

Route entries refcounting

2015-10-19 Thread Martin Pieuchot
There's actually two different reference counts for route entries. A generic one which is represented by the value of rt_ref and a rtable- specific one which is either true or false represented by the value of RT_ACTIVE(). This diff get rids of the second one. I kept the userland interface

Re: Route entries refcounting

2015-10-19 Thread Alexander Bluhm
On Mon, Oct 19, 2015 at 11:51:55AM +0200, Martin Pieuchot wrote: > There's actually two different reference counts for route entries. A > generic one which is represented by the value of rt_ref and a rtable- > specific one which is either true or false represented by the value of > RT_ACTIVE(). >

syslogd ttymsg cleanup

2015-10-19 Thread Alexander Bluhm
Hi, I want to get rid of the fork(2) in the ttymsg() syslogd function. Before I can do that, I need some cleanup. - use ERRBUFSIZE for all error buffers and call them "ebuf" - use TTYMSGTIME directly instead of passing it around - rename utmp entry "utline", normally "line" is used for the

Re: openssl.cnf req defaults -> default_md sha256

2015-10-19 Thread Jonathan Gray
On Wed, Oct 01, 2014 at 10:53:34AM +0100, Stuart Henderson wrote: > On 2014/10/01 19:05, Joel Sing wrote: > > > I should also add that the other obvious/easy "fix" is to initialise > > > digest > > > in openssl/req.c to the SHA-256 EVP. That only changes 'openssl req' > > > though. > > > > > > >

Re: pledge csh nice = death

2015-10-19 Thread Theo de Raadt
> It looks like csh would currently need to pledge("id") in order for the > builtin nice to work --- setpriority() is called in three places > depending on how nice is invoked. However, adding "id" to a shell > seems a bit scary. > > Would it be preferable to mark > [SYS_setpriority] =