Re: sed(1): Fix incomplete error message

On Fri, Jan 01, 2016 at 02:19:16PM -0500, Michael Reed wrote: > Hi, > > I noticed that when doing `sed -i` on a file you don't have > permission to read, the error message printed isn't very helpful: > > $ sed -i '/test/d' /var/log/Xorg.1.log.old > sed: /var/log/Xorg.1.log.old > > The patch

Re: eeprom does not compile on current/macppc

On Thu, Dec 31, 2015 at 12:01:10PM -0700, Todd C. Miller wrote: > Hmmm, should the yyparse() proto really be static? The actual > yyparse() generated by yacc is not static. the yyparse() as generated by yacc may be either static or extern depending on the user's preference -- she's free to

fuser(1): Fix pledge when `u' flag is used

Hi, `fuser -u -c /' doesn't seem to work for me: fuser(28663): syscall 33 "getpw" The patch below fixes my issue. The pledge condition was already a bit long, so I just switched to snprintf(3); not sure what's normally done in such situations. Regards, Michael Index: fstat.c

Checking MAC address of incoming unicast packets

Hi, by default, the ether_input() checks the destination MAC address of incoming unicast packets only if the interface is in promiscous mode. If not, it is assumed that the NIC filters unicast packets reliably. Unfortunately, for virtio-net this is not the case. There, unicast filtering is

Re: Checking MAC address of incoming unicast packets

dlg writes: > should we just do it unconditionally? is there a downside to that? That is a very good question. What are the downsides against having the driver do this filtering itself, like all real hardware does? Why risk sending packets of the wrong form further upwards into the network

Re: sed(1): Fix incomplete error message

On Fri, Jan 01, 2016 at 08:47:09PM +0100, Theo Buehler wrote: > On Fri, Jan 01, 2016 at 02:19:16PM -0500, Michael Reed wrote: > > Hi, > > > > I noticed that when doing `sed -i` on a file you don't have > > permission to read, the error message printed isn't very helpful: > > > > $ sed -i

Re: Checking MAC address of incoming unicast packets

>This could be done with a new flag. There seem to be three possible places >where this flag could be put: > >* ifnet.if_flags > This is a short and there is no free bit. But the IFF_NOTRAILERS bit has > become unused recently and could be recycled. > >* ifnet.if_xflags > An int, lots of free

Re: Checking MAC address of incoming unicast packets

> On 2 Jan 2016, at 7:55 AM, Stefan Fritsch wrote: > > Hi, > > by default, the ether_input() checks the destination MAC address of > incoming unicast packets only if the interface is in promiscous mode. If > not, it is assumed that the NIC filters unicast packets reliably.

Re: OpenBSD 5.8 on Xeon-D (1540) systems

> From: Dale Ghent > Date: Thu, 31 Dec 2015 15:02:11 -0500 > > > On Dec 31, 2015, at 2:43 PM, Mark Kettenis wrote: > > > > Can you please send me a dmesg as well as the acpidump output for this > > machine? That will give me a chance at figuring

Re: integer truncation in soreceive()

Thanks. A similar diff was discussed privately with a few developers during the last few days and is about to be committed soon. Martin Natano wrote: > Another integer overflow: A recv() call with a size of 2^32 bytes causes > soreceive() to spin in an endless loop, resulting in a system freeze.

Re: ifconfig: rm not need variable noprint

On Wed, Dec 30, 2015 at 05:24:27PM +0100, Fabian Raetz wrote: > Hi tech@, > > this patch removes the 'noprint' variable which was added to ifconfig.c in > rev 1.216 > and is not in use since rev. 1.220. Committed, thanks! > Cheers, > Fabian > > > Index: sbin/ifconfig/ifconfig.c >

Mark some functions as static in vmd.c

Mark some functions as static. Don't declare vmd_reload() in vmd.h, do it in vmd.c. Don't declare main() - we don't have to. Don't declare vmd_control_run() - it doesn't exist. Sort declarations by function name. Index: vmd.c ===

OpenBSDVMM58 -> OpenBSDVMM59 in vmmvar.h

Index: vmmvar.h === RCS file: /cvs/src/sys/arch/amd64/include/vmmvar.h,v retrieving revision 1.6 diff -u -p -r1.6 vmmvar.h --- vmmvar.h17 Dec 2015 09:29:28 - 1.6 +++ vmmvar.h1 Jan 2016 16:06:10 - @@ -21,7 +21,7 @@

Don't declare main() in pax, adventure, battlestar

main() does not need to be declared. Index: bin/pax/extern.h === RCS file: /cvs/src/bin/pax/extern.h,v retrieving revision 1.53 diff -u -p -r1.53 extern.h --- bin/pax/extern.h19 Mar 2015 05:14:24 - 1.53 +++

Re: npppd: simplify and lock down priv_open()

On Fri, 4 Dec 2015, Todd C. Miller wrote: > On Fri, 04 Dec 2015 09:47:46 -0800, Philip Guenther wrote: > > We should fix open(2); please try the diff below. Are you sure pppx > > is affected? pppxioctl()'s FIONBIO case appears to be a no-op. I > > certainly agree that bpf and tun are affected.

sed(1): Fix incomplete error message

Hi, I noticed that when doing `sed -i` on a file you don't have permission to read, the error message printed isn't very helpful: $ sed -i '/test/d' /var/log/Xorg.1.log.old sed: /var/log/Xorg.1.log.old The patch below seems to fix the issue for me: $ ./sed -i '/test/d'

Adapt video.4 for recent videoio.h change

Hi, video.4 manual page diff to cope with recent videoio.h change. OK? Best regards, Ingo Index: video.4 === RCS file: /cvs/src/share/man/man4/video.4,v retrieving revision 1.12 diff -u -p -r1.12 video.4 --- video.4 18 Oct 2014

Re: hash ports in trunk?

On 2016/01/01 11:30, Ted Unangst wrote: > If you're trying to utilize multiple links for aggregation, etc., you have to > ensure that the packets get hashed differently. Currently we use MAC address > and IP address, but not port numbers. These days we're basing the decision on the pf state ID

hash ports in trunk?

If you're trying to utilize multiple links for aggregation, etc., you have to ensure that the packets get hashed differently. Currently we use MAC address and IP address, but not port numbers. This makes it challenging to connect two servers unless you jump through some hoops and assign multiple

Re: OpenBSDVMM58 -> OpenBSDVMM59 in vmmvar.h

unless something has actually changed, it should not be necessary to increment this number. the vmm in 5.9 will still speak the same protocol as the vmm that appeared after 5.8. Michal Mazurek wrote: > Index: vmmvar.h > === > RCS

Re: hash ports in trunk?

On 01/01/16(Fri) 11:30, Ted Unangst wrote: > If you're trying to utilize multiple links for aggregation, etc., you have to > ensure that the packets get hashed differently. Currently we use MAC address > and IP address, but not port numbers. This makes it challenging to connect two > servers