Re: [patch] ftpd: ptr == NULL

2016-04-05 Thread Sebastien Marie
On Tue, Apr 05, 2016 at 08:22:22PM +0200, frit...@alokat.org wrote: > Hi, > > cmd is a ptr. > > --f. I am OK with it (after a small change for fit 80 cols) > > Index: ftpd.c > === > RCS file: /cvs/src/libexec/ftpd/ftpd.c,v > retri

Re: bgplg: use SERVER_NAME CGI variable instead of gethostname?

2016-04-05 Thread Florian Obser
I think this is good. OK florian@ On Tue, Apr 05, 2016 at 10:39:15PM +0100, Stuart Henderson wrote: > I've just been reorganising some machines and have a hostname that I don't > really want on the looking glass page, this diff uses the CGI variable > instead to take the hostname as given by the w

Re: bgplg: use SERVER_NAME CGI variable instead of gethostname?

2016-04-05 Thread Claudio Jeker
On Tue, Apr 05, 2016 at 10:39:15PM +0100, Stuart Henderson wrote: > I've just been reorganising some machines and have a hostname that I don't > really want on the looking glass page, this diff uses the CGI variable > instead to take the hostname as given by the webserver instead, which is > easier

bgplg: use SERVER_NAME CGI variable instead of gethostname?

2016-04-05 Thread Stuart Henderson
I've just been reorganising some machines and have a hostname that I don't really want on the looking glass page, this diff uses the CGI variable instead to take the hostname as given by the webserver instead, which is easier to adjust how you want it. OK to commit it, or should I keep it as a loc

cloning bpf

2016-04-05 Thread Martin Natano
The following patch enables device cloning for bpf, which allows to have just one bpf device node in /dev, that services all bpf consumers (up to 1024). Cloning bpf offers some advantages to the current situation: - Users with high bpf usage won't have to clutter /dev with device nodes. - A lot

Re: [patch] ftpd: ptr == NULL

2016-04-05 Thread Héctor Luis Gimbatti
Seems ok > -Original Message- > From: owner-t...@openbsd.org [mailto:owner-t...@openbsd.org] On Behalf > Of frit...@alokat.org > Sent: Tuesday, April 05, 2016 15:22 > To: tech@openbsd.org > Subject: [patch] ftpd: ptr == NULL > > Hi, > > cmd is a ptr. > > --f. > > > Index: ftpd.c >

Re: libc: prefer _MUTEX_LOCK() over _THREAD_PRIVATE_MUTEX_LOCK()

2016-04-05 Thread Martin Natano
On Mon, Apr 04, 2016 at 07:18:36PM -0700, Philip Guenther wrote: > On Mon, 4 Apr 2016, Martin Natano wrote: > > On Sun, Apr 03, 2016 at 08:20:57PM -0700, Philip Guenther wrote: > ... > > > So, diff below converts several uses of _THREAD_PRIVATE_MUTEX_*() to > > > _MUTEX_*(). Regress tests libc/st

[patch] ftpd: ptr == NULL

2016-04-05 Thread fritjof
Hi, cmd is a ptr. --f. Index: ftpd.c === RCS file: /cvs/src/libexec/ftpd/ftpd.c,v retrieving revision 1.213 diff -u -r1.213 ftpd.c --- ftpd.c 16 Mar 2016 15:41:10 - 1.213 +++ ftpd.c 5 Apr 2016 18:12:20 - @@ -

Re: fdt: translate memory addresses

2016-04-05 Thread Patrick Wildt
On Sun, Apr 03, 2016 at 06:56:52PM +0200, Mark Kettenis wrote: > > Date: Sun, 3 Apr 2016 16:57:10 +0200 > > From: Patrick Wildt > > > > Hi, > > > > now we're able to get a node's memory address. Though, a device tree > > may implement so called ranges. Those ranges are used to translate from >

Re: Patch for exporting PF queue status in snmpd

2016-04-05 Thread Philip Higgins
On Tue, Apr 05, 2016 at 12:35:11PM +0200, Mike Belopuhov wrote: > On Mon, Apr 04, 2016 at 15:45 +, Philip Higgins wrote: > > If I'm not mistaken this information isn't exported already. > > > > I've been using this for a while to track queue usage over time in Cacti. > > > > Still need to add

Re: new diff for reserved ports checks [2/2] Was: Re: move "privileged port" check out of in(6)_pcbaddrisavail()

2016-04-05 Thread Alexander Bluhm
On Sun, Apr 03, 2016 at 10:20:30PM +0200, Vincent Gross wrote: > On 03/31/16 14:07, Alexander Bluhm wrote: > > At this point inp has already been modified. So when we bail out > > with EACCES here, we have a partially successful system call. > > > > Move the assignments > >

Re: Options DDB/DIAGNOSTIC

2016-04-05 Thread Jonathan Gray
On Tue, Apr 05, 2016 at 08:02:51AM -0500, Amit Kulkarni wrote: > Hello, > > There is a bunch of code which is always on, but ifdef'd DDB/DIAGNOSTIC. > Those options have been turned on forever in GENERIC. Any interest in > removing code like this? The ifdef/endif DIAGNOSTIC will just be removed

Re: new diff for reserved ports checks [1/2] Was: Re: move "privileged port" check out of in(6)_pcbaddrisavail()

2016-04-05 Thread Alexander Bluhm
On Sun, Apr 03, 2016 at 10:17:49PM +0200, Vincent Gross wrote: > in_pcbpickport() need the local address, so I extend the prototype and > keep a void * to the sin(6)_addr or zeroin46_addr. And while at it, I set > the INPLOOKUP_IPV6 flag which will be needed in in_pcbpickport(). > > Ok ? OK bluhm

Options DDB/DIAGNOSTIC

2016-04-05 Thread Amit Kulkarni
Hello, There is a bunch of code which is always on, but ifdef'd DDB/DIAGNOSTIC. Those options have been turned on forever in GENERIC. Any interest in removing code like this? The ifdef/endif DIAGNOSTIC will just be removed by unifdef... If there is any interest, I will go file by file and send

Re: Patch for exporting PF queue status in snmpd

2016-04-05 Thread Mike Belopuhov
On Mon, Apr 04, 2016 at 15:45 +, Philip Higgins wrote: > If I'm not mistaken this information isn't exported already. > > I've been using this for a while to track queue usage over time in Cacti. > > Still need to add entries in OPENBSD-PF-MIB.txt, > but want to make sure I'm on the right tra

Patch for exporting PF queue status in snmpd

2016-04-05 Thread Philip Higgins
If I'm not mistaken this information isn't exported already. I've been using this for a while to track queue usage over time in Cacti. Still need to add entries in OPENBSD-PF-MIB.txt, but want to make sure I'm on the right track first. I just added it on the end of the PF section and used the n

Re: bgpd: dispatch_rtmsg_addr[change] mpath route not found

2016-04-05 Thread Peter Hessler
On 2016 Apr 04 (Mon) at 18:07:52 +0100 (+0100), Stuart Henderson wrote: :On 2016/03/31 12:40, Peter Hessler wrote: :> We see occasional bgpd deaths during boot. This is apparently caused by :> a race with ospfd starting up. :> :> The underlying problem is we are reciving a CHANGE route message fo