Re: new getformat() for jot(1)

2016-09-06 Thread Theo Buehler
On Wed, Sep 07, 2016 at 12:00:17AM +0200, Martin Natano wrote: > On Sat, Sep 03, 2016 at 04:55:59PM +0100, Theo Buehler wrote: > > The -w flag to jot() allows the user to specify a format string that > > will be passed to printf after it was verified that it contains only one > > conversion

Re: new getformat() for jot(1)

2016-09-06 Thread Martin Natano
On Sat, Sep 03, 2016 at 04:55:59PM +0100, Theo Buehler wrote: > The -w flag to jot() allows the user to specify a format string that > will be passed to printf after it was verified that it contains only one > conversion specifier. There are some subtle differences what jot's > getformat()

mg - fix modeline segfault

2016-09-06 Thread Adam Wolk
Hi tech@ attaching a fix for the following crash caused by a null pointer dereference while the modeline is trying to work on a unusable display #0 0x0bf6a4e04433 in modeline (wp=0xbf948d9d400, modelinecolor=2) at display.c:800 800 vscreen[n]->v_color = modelinecolor;/*

smtpd shutdown cleanup

2016-09-06 Thread Eric Faurot
Previously, all processes would shutdown on receiving SIGINT or SIGTERM. When going down, the parent process would kill all the other process and waitpid() them. Now, only the parent process handles SIGTERM and SIGINT, other processes ignore them. Upon receiving one of these signals, the parent

Re: Default softraid crypto PBKDF2 rounds

2016-09-06 Thread David Coppa
Il 6 settembre 2016 14:56:32 CEST, Filippo Valsorda ha scritto: >Hello, > >I recently had the occasion to dive into the softraid crypto code [1] >and was quite pleased with the cleanliness of it all. However, I found >surprising the default value of 8k PBKDF2 rounds. > >I know

Re: mg - Check pointer before calling showbuffer()

2016-09-06 Thread Adam Wolk
On Tue, Sep 06, 2016 at 05:10:39PM +, Mark Lumsden wrote: > Source Joachim Nilsson: > > Found by Coverity Scan. The popbuf() function iterated over a list to > find a wp pointer, then sent it to showbuffer() which immediately went > ahead and dereferenced it. This patch simply

Re: Improve error message in rcctl(8)

2016-09-06 Thread lists
Tue, 06 Sep 2016 22:41:53 +0200 Jeremie Courreges-Anglas > li...@wrant.com writes: > > > Tue, 6 Sep 2016 19:54:33 + Robert Peichaer > >> > Hi tech@, > >> > > >> > Daemon names historically match Antoine's alphanumeric proposal, and I > >> > think

Re: Improve error message in rcctl(8)

2016-09-06 Thread Jeremie Courreges-Anglas
li...@wrant.com writes: > Tue, 6 Sep 2016 19:54:33 + Robert Peichaer >> > Hi tech@, >> > >> > Daemon names historically match Antoine's alphanumeric proposal, and I >> > think underscore is a bit too much, if it's present use minus instead. >> > The logic behind this?

Re: Improve error message in rcctl(8)

2016-09-06 Thread Antoine Jacoutot
On Tue, Sep 06, 2016 at 04:09:49PM -0400, Anthony Coulter wrote: > Regarding Jiri's suggestion: Here is a diff that makes > `rcctl ls all' only list executable files with valid service > names. > > This diff also fixes two problems with my original submission: > 1. The use of `[' instead of `[['

Re: Improve error message in rcctl(8)

2016-09-06 Thread lists
Tue, 6 Sep 2016 19:54:33 + Robert Peichaer > > Hi tech@, > > > > Daemon names historically match Antoine's alphanumeric proposal, and I > > think underscore is a bit too much, if it's present use minus instead. > > The logic behind this? Match this to word termination

Re: Improve error message in rcctl(8)

2016-09-06 Thread Anthony Coulter
Regarding Jiri's suggestion: Here is a diff that makes `rcctl ls all' only list executable files with valid service names. This diff also fixes two problems with my original submission: 1. The use of `[' instead of `[[' causes filename expansion to take place on the right-hand side of the

Re: Improve error message in rcctl(8)

2016-09-06 Thread Robert Peichaer
> Hi tech@, > > Daemon names historically match Antoine's alphanumeric proposal, and I > think underscore is a bit too much, if it's present use minus instead. > The logic behind this? Match this to word termination symbols in ksh. > > Kind regards, > Anton $ find /usr/ports -name '*_*.rc'

Re: Improve error message in rcctl(8)

2016-09-06 Thread lists
Tue, 6 Sep 2016 21:04:55 +0200 Antoine Jacoutot > On Tue, Sep 06, 2016 at 09:01:08PM +0200, ludovic coues wrote: > > 2016-09-06 20:53 GMT+02:00 Antoine Jacoutot : > > > On Tue, Sep 06, 2016 at 12:29:58PM -0400, Anthony Coulter wrote: > > >>

Re: Improve error message in rcctl(8)

2016-09-06 Thread Jiri B
Could a change solve also this annoying situations? (saved files by editors...) # rcctl ls all | grep ^tor tor tor_2 tor_2~ j.

Re: Improve error message in rcctl(8)

2016-09-06 Thread Anthony Coulter
Antoine writes: > What about this? > + [[ "${_svc}" == +([_/+[:alnum:]]) ]] || return That doesn't fix the problem. You cannot use plus signs or slashes in a service name because the options to a service are set in rc.conf.local with the line foo_flags="" where `foo' is replaced by the

Re: Improve error message in rcctl(8)

2016-09-06 Thread Antoine Jacoutot
On Tue, Sep 06, 2016 at 09:01:08PM +0200, ludovic coues wrote: > 2016-09-06 20:53 GMT+02:00 Antoine Jacoutot : > > On Tue, Sep 06, 2016 at 12:29:58PM -0400, Anthony Coulter wrote: > >> Sometimes when I restart a service after changing its configuration file > >> I

Re: Improve error message in rcctl(8)

2016-09-06 Thread ludovic coues
2016-09-06 20:53 GMT+02:00 Antoine Jacoutot : > On Tue, Sep 06, 2016 at 12:29:58PM -0400, Anthony Coulter wrote: >> Sometimes when I restart a service after changing its configuration file >> I accidentally type: >> >> # rcctl restart smtpd.conf >> /usr/sbin/rcctl:

Re: Fix Wacom Intuos S 2 descriptor and make wsmouse work

2016-09-06 Thread Frank Groeneveld
On Tue, Sep 06, 2016 at 02:19:28PM +0200, Ulf Brosziewski wrote: > Just a remark on your use of the wsmouse interface (which isn't well > known and documented yet): wsmouse_set is a function for uncommon > cases. To report a pair of absolute coordinates use wsmouse_position, > that is, instead of

Re: Improve error message in rcctl(8)

2016-09-06 Thread Antoine Jacoutot
On Tue, Sep 06, 2016 at 12:29:58PM -0400, Anthony Coulter wrote: > Sometimes when I restart a service after changing its configuration file > I accidentally type: > > # rcctl restart smtpd.conf > /usr/sbin/rcctl: ${cached_svc_is_special_smtpd.conf}: bad substitution > /usr/sbin/rcctl[556]:

Re: subr_tree for netinet/ip_ipsp.[ch]

2016-09-06 Thread Mike Belopuhov
On Sep 6, 2016 07:07, "David Gwynne" wrote: > > this gives us back 5k on amd64. > > ok? > I can't test this ATM, but I endorse the idea. The diff looks good to me.

mg - Check pointer before calling showbuffer()

2016-09-06 Thread Mark Lumsden
Source Joachim Nilsson: Found by Coverity Scan. The popbuf() function iterated over a list to find a wp pointer, then sent it to showbuffer() which immediately went ahead and dereferenced it. This patch simply adds a NULL pointer check before calling showbuffer(), if NULL then

Improve error message in rcctl(8)

2016-09-06 Thread Anthony Coulter
Sometimes when I restart a service after changing its configuration file I accidentally type: # rcctl restart smtpd.conf /usr/sbin/rcctl: ${cached_svc_is_special_smtpd.conf}: bad substitution /usr/sbin/rcctl[556]: set: cached_svc_is_special_smtpd.conf: is not an identifier rcctl: service

Re: Default softraid crypto PBKDF2 rounds

2016-09-06 Thread Otto Moerbeek
On Tue, Sep 06, 2016 at 01:56:32PM +0100, Filippo Valsorda wrote: > Hello, > > I recently had the occasion to dive into the softraid crypto code [1] > and was quite pleased with the cleanliness of it all. However, I found > surprising the default value of 8k PBKDF2 rounds. > > I know it is easy

Re: "route add -ifp pppoe..", take care if updating remote boxes

2016-09-06 Thread Martin Pieuchot
On 06/09/16(Tue) 14:03, Stuart Henderson wrote: > [...] > And > if you're trying to "route change" to a non-allowed address when > you _already_ have a default route, you hit a repeatable kassert > '"rt->rt_gwroute != NULL" failed: file

"route add -ifp pppoe..", take care if updating remote boxes

2016-09-06 Thread Stuart Henderson
Now g2k16 is over I thought I'd update my home router from 6.0 to (self-built) -current. I know this area is in flux at the moment, posting to tech rather than mailing specific devs so that people know to take a bit more care than usual when updating remote machines that are doing this. "route

Default softraid crypto PBKDF2 rounds

2016-09-06 Thread Filippo Valsorda
Hello, I recently had the occasion to dive into the softraid crypto code [1] and was quite pleased with the cleanliness of it all. However, I found surprising the default value of 8k PBKDF2 rounds. I know it is easy to override and I should have RTFM, but I (naively, I'll admit) assumed OpenBSD

Re: sysmerge.8: Mention PAGER behavior when undefined/empty

2016-09-06 Thread Antoine Jacoutot
On Mon, Sep 05, 2016 at 05:56:03PM -0400, Michael Reed wrote: > As is done in other man pages. Committed, thank you. > === > RCS file: /cvs/src/usr.sbin/sysmerge/sysmerge.8,v > retrieving revision 1.78 > diff -u -p -r1.78 sysmerge.8

Re: Fix Wacom Intuos S 2 descriptor and make wsmouse work

2016-09-06 Thread Ulf Brosziewski
Just a remark on your use of the wsmouse interface (which isn't well known and documented yet): wsmouse_set is a function for uncommon cases. To report a pair of absolute coordinates use wsmouse_position, that is, instead of wsmouse_set(ms->sc_wsmousedev, WSMOUSE_ABS_X, x, 0);

byebye SIGNING_PARAMETERS

2016-09-06 Thread Marc Espie
seemed unclear. There's no longer any benefit to pkg_create signing packages, since signing packages is going to be signify -zS -s /etc/signify/whateverr-pkg.sec -m pkg.tgz -x signed/pkg.tgz (e.g., you have to produce the full archive first THEN you can sign it) I'll have a version of pkg_sign

Re: acme-client.1: Use indented display for source code

2016-09-06 Thread Jason McIntyre
On Mon, Sep 05, 2016 at 06:02:51PM -0400, Michael Reed wrote: > I find that keeping prose at a different indentation level than source > code makes the man page easier to read. Besides, it's already done > in most other man pages. > fixed, thanks. jmc > > > Index: acme-client.1 >

Re: Make rc scripts use [[ instead of [

2016-09-06 Thread Jason McIntyre
On Mon, Sep 05, 2016 at 04:39:49PM -0400, Anthony Coulter wrote: > > While I vaguely remember reading long ago that `echo' and `[' were > shell builtins, I'm much more strongly aware that /bin/echo and /bin/[ > are also available as separate executables. Their man pages don't > mention that they