Re: minor diff for switchd.8

2016-11-28 Thread Jason McIntyre
On Mon, Nov 28, 2016 at 09:56:23PM -0500, Rob Pierce wrote: > Index: switchd.8 > === > RCS file: /cvs/src/usr.sbin/switchd/switchd.8,v > retrieving revision 1.3 > diff -u -p -r1.3 switchd.8 > --- switchd.8 20 Oct 2016 19:55:29 -

Re: tcpdump ether proto lldp

2016-11-28 Thread Jeremie Courreges-Anglas
"Theo de Raadt" writes: > Why? The size of an array changes, but the ABI does not change > in a visible fashion. tcpdump uses that symbol directly: /*XXX from libbpfc.a */ extern struct eproto { char *s; u_short p; } eproto_db[]; static void init_eprotoarray(void) { i

Re: tcpdump ether proto lldp

2016-11-28 Thread Theo de Raadt
Why? The size of an array changes, but the ABI does not change in a visible fashion. > ok, but please bump the minor version. > > > Index: nametoaddr.c > > === > > RCS file: /cvs/src/lib/libpcap/nametoaddr.c,v > > retrieving revisio

Re: tcpdump ether proto lldp

2016-11-28 Thread Jeremie Courreges-Anglas
David Gwynne writes: > this diff lets me easily ask tcpdump to show me lldp packets. > > without it i have to remember the protocol id, and i cant. > > ok? ok, but please bump the minor version. > Index: nametoaddr.c > === > RCS fi

minor diff for switchd.8

2016-11-28 Thread Rob Pierce
Index: switchd.8 === RCS file: /cvs/src/usr.sbin/switchd/switchd.8,v retrieving revision 1.3 diff -u -p -r1.3 switchd.8 --- switchd.8 20 Oct 2016 19:55:29 - 1.3 +++ switchd.8 29 Nov 2016 02:49:53 - @@ -29,7 +29,7 @@ .

tcpdump ether proto lldp

2016-11-28 Thread David Gwynne
this diff lets me easily ask tcpdump to show me lldp packets. without it i have to remember the protocol id, and i cant. ok? Index: nametoaddr.c === RCS file: /cvs/src/lib/libpcap/nametoaddr.c,v retrieving revision 1.19 diff -u -p -

Re: armv7/stand/efiboot: working BOOTAA64.EFI payload

2016-11-28 Thread Patrick Wildt
On Tue, Nov 22, 2016 at 11:02:55PM -0500, Ian Sutton wrote: > Hi, > > Patch adds armv8/aarch64 EFI payload image build support. With > patrick@'s aarch64-none-elf- toolchain referenced in my last mail on > this list, you can build it via... > > $ MACHINE=armv8 armmake64-aarch64 -f Makefile.arm64

Re: add in6 multicast support to vxlan(4), take 4

2016-11-28 Thread Vincent Gross
On Thu, 10 Nov 2016 22:16:55 +0100 Vincent Gross wrote: > On Sat, 5 Nov 2016 12:41:39 +0100 > Vincent Gross wrote: > > > Updated diff, I reworked the logic to handle the if_get/if_put dance > > in vxlan_multicast_join(), and fixed an uninitialized variable. > > > > Ok ? > > Anyone to commen

Re: smtpd: hide struct io

2016-11-28 Thread Gilles Chehade
On Mon, Nov 28, 2016 at 08:50:14PM +0100, Eric Faurot wrote: > Hi, > > After the recent series of cleanups, it is now possible to make > struct io opaque: > > - move struct io definition in ioev.c > - replace io_init/io_clear with io_new/io_free > - allocate an iobuf for each new io internally >

smtpd: hide struct io

2016-11-28 Thread Eric Faurot
Hi, After the recent series of cleanups, it is now possible to make struct io opaque: - move struct io definition in ioev.c - replace io_init/io_clear with io_new/io_free - allocate an iobuf for each new io internally - use struct io pointer in the rest of the code - remove remaining uses of iobu

Re: arm64: add ELF machine id for AArch64

2016-11-28 Thread Patrick Wildt
On Fri, Nov 25, 2016 at 12:44:10AM +0100, Patrick Wildt wrote: > Hi, > > ARM IHI 0056B, the ELF spec for the ARM 64-bit Architecture, specifies > the following for the ELF e_machine attribute: > > An object file conforming to this specification must have the value > EM_AARCH64 (183, 0xB7). > > o

Re: LLVM: use OpenBSD target code for AArch64

2016-11-28 Thread Patrick Wildt
On Fri, Nov 25, 2016 at 12:37:10AM +0100, Patrick Wildt wrote: > Hi, > > a clang binary using the AArch64 backend currently does not use > proper OpenBSD defines and specifics. This is because we don't > tell clang to use OpenBSD target info if it encounters an AArch64 > target. > > This diff ma

Re: global mbuf memory limit

2016-11-28 Thread Simon Mages
It seems netstat -m is not printing the correct results with this diff. The max values is wrong. # sysctl kern.maxclusters kern.maxclusters=262144 # netstat -m 9543 mbufs in use: 8044 mbufs allocated to data 1491 mbufs allocated to packet headers 8 mbufs allocated to socke

bpf_mtap(9) w/o KERNEL_LOCK

2016-11-28 Thread Martin Pieuchot
Last diff to trade the KERNEL_LOCK for a mutex in order to protect data accessed inside bpf_catchpacket(). Note about the multiples data structures: - selwakeup() is called in a thread context (task) so we rely on the KERNEL_LOCK() to serialize access to kqueue(9) data. - the global list

You should be remove obsolete NOTES file from sbin/init directory

2016-11-28 Thread Андрей Болконский
subj

rt_match & splsoftassert()

2016-11-28 Thread Martin Pieuchot
This is now always called at IPL_SOFTNET, so assert it. ok? Index: net/route.c === RCS file: /cvs/src/sys/net/route.c,v retrieving revision 1.339 diff -u -p -r1.339 route.c --- net/route.c 21 Nov 2016 10:30:42 - 1.339 +++ ne

pf_if.c & splsoftnet()

2016-11-28 Thread Martin Pieuchot
These chunks depend on the if_attach() bits I sent in the previous email. As soon as if_attach() always raise the ipl level to IPL_SOFTNET pfi_attach_ifnet() doesn't need to do it. The rest is already safe since hooks are already called at IPL_SOFTNET. ok? Index: net/pf_if.c ===

tun(4), tap(4), cloned interface & splsoftnet()

2016-11-28 Thread Martin Pieuchot
This remove all but one splsoftnet() recursions when creating or destroying cloned interfaces. Note that I have to introduce some extra splsoftnet()/splx() dances in tun(4) and tap(4) create functions. ok? Index: net/if.c === RCS fi

Remove splsoftnet() in in_ioctl()

2016-11-28 Thread Martin Pieuchot
umb(4) also calls in_ioctl() directly but always under splnet(), so for the moment this is good enough. ok? Index: netinet/igmp.c === RCS file: /cvs/src/sys/netinet/igmp.c,v retrieving revision 1.55 diff -u -p -r1.55 igmp.c --- netin

Re: recursive splsoftnet() in ND6

2016-11-28 Thread Alexander Bluhm
On Mon, Nov 28, 2016 at 12:31:39PM +0100, Martin Pieuchot wrote: > This kill multiple recursive splsoftnet(), ok? OK bluhm@ > > Index: netinet6/nd6.h > === > RCS file: /cvs/src/sys/netinet6/nd6.h,v > retrieving revision 1.64 > diff

Re: Automagically created routes and ifa

2016-11-28 Thread Alexander Bluhm
On Mon, Nov 28, 2016 at 11:38:36AM +0100, Martin Pieuchot wrote: > In the kernel we should always know to witch ``ifa'' a route will be > attached. Since I'd like to only call rt_getifa() for routes inserted > from userland, here's a diff that set rti_ifa before RTM_ADD. > > ok? OK bluhm@ > >

subscribe too mailing lists.

2016-11-28 Thread leroy jordan
Hi, All Hope to learn more info. and one day be a part of the open community. LeRoy Jordan MaxStream TV lero...@maxstreamtv.com

Re: NULL check before m_freem(9)

2016-11-28 Thread Jonathan Gray
On Mon, Nov 28, 2016 at 12:42:32PM +0100, Martin Pieuchot wrote: > Our m_freem(9) and m_free(9) deal with NULL like free(3), so there's no need > for such checks. > > ok? You missed one in uipc_syscalls.c and there are a few others elsewhere: Index: arch/sgi/dev/if_iec.c

Re: NULL check before m_freem(9)

2016-11-28 Thread Reyk Floeter
> > Our m_freem(9) and m_free(9) deal with NULL like free(3), so there's no need > for such checks. > > ok? > OK reyk > Index: kern/uipc_syscalls.c > === > RCS file: /cvs/src/sys/kern/uipc_syscalls.c,v > retrieving revision 1.140

NULL check before m_freem(9)

2016-11-28 Thread Martin Pieuchot
Our m_freem(9) and m_free(9) deal with NULL like free(3), so there's no need for such checks. ok? Index: kern/uipc_syscalls.c === RCS file: /cvs/src/sys/kern/uipc_syscalls.c,v retrieving revision 1.140 diff -u -p -r1.140 uipc_syscall

Re: Patch to fix kernel build without IPSEC

2016-11-28 Thread Joe Holden
On 28/11/2016 11:33, Martin Pieuchot wrote: On 28/11/16(Mon) 11:23, Joe Holden wrote: On 28/11/2016 10:45, Martin Pieuchot wrote: On 28/11/16(Mon) 10:17, mail+li...@m.jwh.me.uk wrote: [...] Just a small one liner: If you want to submit diff, please send then against -current not 6.0. And ma

Re: Patch to fix kernel build without IPSEC

2016-11-28 Thread Martin Pieuchot
On 28/11/16(Mon) 11:23, Joe Holden wrote: > On 28/11/2016 10:45, Martin Pieuchot wrote: > > On 28/11/16(Mon) 10:17, mail+li...@m.jwh.me.uk wrote: > > > [...] > > > Just a small one liner: > > > > If you want to submit diff, please send then against -current not 6.0. > > > > And make sure people c

recursive splsoftnet() in ND6

2016-11-28 Thread Martin Pieuchot
This kill multiple recursive splsoftnet(), ok? Index: netinet6/nd6.h === RCS file: /cvs/src/sys/netinet6/nd6.h,v retrieving revision 1.64 diff -u -p -r1.64 nd6.h --- netinet6/nd6.h 21 Nov 2016 10:52:08 - 1.64 +++ netine

Re: Patch to fix kernel build without IPSEC

2016-11-28 Thread Joe Holden
On 28/11/2016 10:45, Martin Pieuchot wrote: On 28/11/16(Mon) 10:17, mail+li...@m.jwh.me.uk wrote: [...] Just a small one liner: If you want to submit diff, please send then against -current not 6.0. And make sure people can apply your diff, this is not the case with this one. Hiya, Yeah so

Re: arp(8) and ndp(8) tweak

2016-11-28 Thread Jeremie Courreges-Anglas
Martin Pieuchot writes: > vether(4) has a long name. Let's extend to output of these tools to > 80 chars to make vetherX fit in the columns. ok -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Automagically created routes and ifa

2016-11-28 Thread Martin Pieuchot
In the kernel we should always know to witch ``ifa'' a route will be attached. Since I'd like to only call rt_getifa() for routes inserted from userland, here's a diff that set rti_ifa before RTM_ADD. ok? Index: netinet/ip_icmp.c ==

Re: Patch to fix kernel build without IPSEC

2016-11-28 Thread Martin Pieuchot
On 28/11/16(Mon) 10:17, mail+li...@m.jwh.me.uk wrote: > [...] > Just a small one liner: If you want to submit diff, please send then against -current not 6.0. And make sure people can apply your diff, this is not the case with this one. > > > > Index: sys/netinet/udp_usrreq.c > > =

Patch to fix kernel build without IPSEC

2016-11-28 Thread mail+lists
Hi guys, Just a small one liner: Index: sys/netinet/udp_usrreq.c === RCS file: /cvs/src/sys/netinet/udp_usrreq.c,v retrieving revision 1.216 diff -u -p -r1.216 udp_usrreq.c --- sys/netinet/udp_usrreq.c 22 Jul 2016 11:14:

arp(8) and ndp(8) tweak

2016-11-28 Thread Martin Pieuchot
vether(4) has a long name. Let's extend to output of these tools to 80 chars to make vetherX fit in the columns. Before: === # arp -an Host Ethernet Address Netif Expire Flags 10.188.70.17 fe:e1:ba:d0:d5:6d vio0 16m27s 10.188.