softraid_crypto.c malloc failure case

2017-01-16 Thread Michael W. Bombardieri
Hi, In sr_crypto_change_maskkey() p was being checked for NULL twice, once after malloc() and once at goto label. I think malloc() failure would be the only case where p doesn't need to be freed, so add a special goto label for this. Sorry if I got it wrong. - Michael Index: softraid_crypto.c

Re: NET_LOCK() pr_sysctl

2017-01-16 Thread Mateusz Guzik
On Mon, Jan 16, 2017 at 07:34:43PM +, Alexander Bluhm wrote: > On Mon, Jan 09, 2017 at 11:55:55PM +0100, Alexander Bluhm wrote: > > On Thu, Dec 22, 2016 at 01:38:17AM +0100, Mateusz Guzik wrote: > > > In this particular case, what happens if the access results in a page > > > fault and the

Re: 11n support for athn(4)

2017-01-16 Thread Peter Kay
On 16 January 2017 at 23:30, Stefan Sperling wrote: > On Mon, Jan 16, 2017 at 07:18:04PM +, Peter Kay wrote: >> I'm still having issues with this. >> >> When the access p64 bytes from 192.168.1.251: icmp_seq=678 ttl=255 >> time=4.502 ms oint wedges, it seems to affect my

Re: NET_LOCK() pr_sysctl

2017-01-16 Thread Hrvoje Popovski
On 16.1.2017. 23:53, Alexander Bluhm wrote: > Hrvoje Popovski has tested the diff and found some ugly > pmap_unwire: wiring for pmap 0xff00075f5210 va 0x7f7d5000 didn't > change! > kernel printfs. The happens when sysctl(8) writes a value. > > If oldp and newp are in the same page, I

Re: 11n support for athn(4)

2017-01-16 Thread Stefan Sperling
On Mon, Jan 16, 2017 at 07:18:04PM +, Peter Kay wrote: > I'm still having issues with this. > > When the access point wedges, it seems to affect my Android phone more > than the iwn laptop. ifconfig athn0 down up does resolve the problem > in the short term. Do you have 2 antennas properly

Re: NET_LOCK() pr_sysctl

2017-01-16 Thread Alexander Bluhm
On Mon, Jan 16, 2017 at 08:34:43PM +0100, Alexander Bluhm wrote: > If I implement the same trick for newp, I can avoid the "netlock > locking against myself" with sysctl on memory mapped files over > NFS. Of course other copyin/copyout paths like pf(4) ioctl(2) still > have to be checked. IPsec

Re: xenocara fontconfig: make slight hinting the default

2017-01-16 Thread Matthieu Herrb
On Sun, Jan 15, 2017 at 10:37:20AM +0100, Nils Reuße wrote: > On 01/04/2017 01:19 PM, Nils Reuße wrote: > > Dear all, > > > > fontconfig made slight hinting the default in version 2.11.95 (see commit > > at [1]). > > > > xenocara currently ships, but does not install the new hinting conf files:

Re: [patch] Enable support for Subpixel Antialiasing / LCD Filter

2017-01-16 Thread Nils Reuße
On 01/15/2017 03:04 PM, Stuart Henderson wrote: Other Linux/BSD systems have this option enabled for a long time now, under them Ubuntu, Debian [2], Freebsd [3], Arch Linux [4] and more. There has been a privious discussion on this list on this topic [5] where tedu@ mentions, that this issue

Re: ksh(1): preserve xtrace option

2017-01-16 Thread frantisek holop
Anton Lindqvist, 16 Jan 2017 10:02: > > Hmm, I see now that my memory is false, ksh93 (available as port) does > > trace into functions. Still, I'm undecided if we want to change our > > ksh. > > Any thoughts from others on changing the defaults? just my 2 cents. when many years ago i found out

Re: NET_LOCK() pr_sysctl

2017-01-16 Thread Alexander Bluhm
On Mon, Jan 09, 2017 at 11:55:55PM +0100, Alexander Bluhm wrote: > On Thu, Dec 22, 2016 at 01:38:17AM +0100, Mateusz Guzik wrote: > > In this particular case, what happens if the access results in a page > > fault and the area comes from a nfs mapped file? If network i/o is done > > from the same

Re: 11n support for athn(4)

2017-01-16 Thread Peter Kay
I'm still having issues with this. When the access point wedges, it seems to affect my Android phone more than the iwn laptop. ifconfig athn0 down up does resolve the problem in the short term. I see the changes have already been committed, so it's no longer necessary to patch recent snapshots

Re: src/usr.sbin/slowcgi: possible bug

2017-01-16 Thread Ali Farzanrad
Florian Obser wrotes: >On Mon, Jan 02, 2017 at 04:29:21PM +0330, temp+...@frad.ir wrote: >> Hi tech@, >> >> I recently checked the slowcgi(8) and found that it might have an issue >> when buf_pos is at the end of buffer and buf_len is zero. >> >> Am I right? > >we can simplify this even more.

Probe up to 255 LUNs on mpii(4)

2017-01-16 Thread Mike Belopuhov
This is enough to probe and initiate I/O to multiple LUNs on mpii(4) and lets robert@ attach (but not use) his tape library where LUN 0 is an st(4) and LUN 1 is a ch(4). OK? The reason we limit it to 255 is that LUN numbers larger than 255 need to be encoded in a fairly complicated manner and

Re: xargs: fix -I when used with -0

2017-01-16 Thread Todd C. Miller
On Mon, 16 Jan 2017 09:21:39 -0700, "Todd C. Miller" wrote: > When using the -0 flag, a "line" is delimited by a NUL char, not a > newline. This fixes things like: > > $ printf 'hello\00world\00' | xargs -n 1 -0 -I arg printf '>%s<\n' "arg" Sorry, the actual test command is: $ printf

Re: 11n support for athn(4)

2017-01-16 Thread Uwe Werler
Hello Stefan, many many thanks for this work! I tested today with the latest snapshot from yesterday and a custom compiled kernel from today's sources. AP is my APU1D4 and Client is my ThinkPad T530 with iwn: AP: athn0 at pci4 dev 0 function 0 "Atheros AR9281" rev 0x01: apic 2 int 19 athn0:

iwm(4): Remove old iwm_get_{active,passive}_dwell functions.

2017-01-16 Thread Imre Vadász
The iwm_get_active_dwell() and iwm_get_passive_dwell() functions are unused, and where removed in Linux iwlwifi git commit 9437e9941025bc83d3dd43f2927019149029f667. Index: sys/dev/pci/if_iwm.c === RCS file:

iwm(4): Update struct iwm_scan_results_notif. Remove a few old defines.

2017-01-16 Thread Imre Vadász
Hi, This patch updates the struct iwm_scan_results_notif to FW Api version 3, and removes the unused enum iwm_scan_complete_status status codes, as well as the deprecated/unused struct iwm_scan_complete_notif. This corresponds to the Linux iwlwifi commits 1083fd7391e989be52022f0f338e9dadc048b063

xargs: fix -I when used with -0

2017-01-16 Thread Todd C. Miller
When using the -0 flag, a "line" is delimited by a NUL char, not a newline. This fixes things like: $ printf 'hello\00world\00' | xargs -n 1 -0 -I arg printf '>%s<\n' "arg" Before: >hello world< After: >hello< >world< This change is consistent with the behavior of GNU xargs,

iwm(4): Remove a few dead definitions from if_iwmreg.h.

2017-01-16 Thread Imre Vad??sz
Hi, This patch removes a couple of definitions from if_iwmreg.h which were never used in iwm(4), which were removed from iwlwifi in Linux git commit 76f8c0e17edc6eba43f84952e5a87c7f50f69370. Index: sys/dev/pci/if_iwmreg.h === RCS

iwm(4): Remove definitions for deprecated old scanning API.

2017-01-16 Thread Imre Vadász
Hi, This removes the old deprecated scan API definitions, which have been unused since the upgrade of iwm(4) to version 16 firmware. Also matching the iwlwifi code, it uses a IWM_DEFAULT_SCAN_CHANNELS (== 40) definition instead of IWM_MAX_NUM_SCAN_CHANNELS (== 36) as default value for

Re: ksh(1): preserve xtrace option

2017-01-16 Thread Anton Lindqvist
On Fri, Jan 13, 2017 at 10:56:51AM +0100, Otto Moerbeek wrote: > On Fri, Jan 13, 2017 at 10:20:19AM +0100, Otto Moerbeek wrote: > > > On Fri, Jan 13, 2017 at 09:51:51AM +0100, Otto Moerbeek wrote: > > > > > On Fri, Jan 13, 2017 at 09:46:54AM +0100, Anton Lindqvist wrote: > > > > > > > Consider