Re: CPU_LIDSUSPEND in init(8) and reboot(8)

ping? On Sun, May 21, 2017 at 09:46:45AM +0200, Martin Natano wrote: > While switching init and reboot to CPU_LIDACTION, I forgot about the > #ifdef's. Ok? > > natano > > > Index: init/init.c > === > RCS file:

Re: ping: Style fixes/cleanups

On Tue, Jun 13, 2017 at 08:02:13PM +0200, Klemens Nanni wrote: > Unify option checking and simply logic. > > F_HDRINCL and F_ROUTE are mutually exclusive, thus check the latter only > if the former one is not set. > > Index: ping.c >

Re: pool cpu caches and a systat view of them

> On 14 Jun 2017, at 13:50, David Gwynne wrote: > > i have a few things left to do in the pools per cpu caches, one of > which is make their activity visibile. to that end, here's a diff > provides a way for userland to request stats from the per cpu caches, > and uses that

pool cpu caches and a systat view of them

i have a few things left to do in the pools per cpu caches, one of which is make their activity visibile. to that end, here's a diff provides a way for userland to request stats from the per cpu caches, and uses that in systat so you can watch them. there are two added pool sysctls. one copies an

Re: htpasswd: use crypt_newhash instead of bcrypt API

Michal Mazurek wrote: > On 15:31:50, 10.06.17, Ted Unangst wrote: > > > @@ -58,17 +58,29 @@ The provided > > > .Fa password > > > is randomly salted and hashed and stored in > > > .Fa hash . > > > +.Fa hash > > > +must already be allocated, and > > > +.Fa hashsize > > > +must contain its size,

Re: install.sub: Fix scrambled address list in v6_defroute()

On Wed, Jun 14, 2017 at 03:00:11AM +0200, Klemens Nanni wrote: Installing -current the other day showed a broken list when picking the IPv6 default route just like reported on bugs@ five days ago[1]. Missed the link. 1: http://marc.info/?l=openbsd-bugs=149704197715791

install.sub: Fix scrambled address list in v6_defroute()

Installing -current the other day showed a broken list when picking the IPv6 default route just like reported on bugs@ five days ago[1]. This behaviour can be reproduced manually running the code from v6_defroute(): $ # source/define bsort() $ _if=trunk0 $ bsort $(ping6

Re: update logging in ifstated

On Tue, Jun 13, 2017 at 08:44:46AM +0200, Sebastian Benoit wrote: > Rob Pierce(r...@2keys.ca) on 2017.06.11 18:04:31 -0400: > > This minimizes differences with the latest log.c. > > > > I was not sure how to handle verbosity, as the current implementation is > > verbose by default in debug mode.

Re: m4(1): add -E flag support

On Tue, 13 Jun 2017 17:05:56 -0400, Brian Callahan wrote: > Whoops, that was unintentional. Fixed. Looks good to me. - todd

Re: m4(1): add -E flag support

Hi -- Whoops, that was unintentional. Fixed. ~Brian Index: usr.bin/m4/eval.c === RCS file: /cvs/src/usr.bin/m4/eval.c,v retrieving revision 1.74 diff -u -p -u -p -r1.74 eval.c --- usr.bin/m4/eval.c 5 Feb 2015 12:59:57 -

Re: m4(1): add -E flag support

Hi -- Updated diff attached. Wrapped everything up in an m4_warnx() call and added a regress test for single -E. Thanks! The one fatal_warns check in eval.c seems like a special case, so I left that one as it was. ~Brian Index: usr.bin/m4/eval.c

Re: m4(1): add -E flag support

On Tue, Jun 13, 2017 at 03:35:54PM -0400, Brian Callahan wrote: > This diff comes with man page additions explaining the new flag, > as well as a regress test for -E -E behavior. I could not figure > out how to write a regress test that checks for exit status, so > there is no test for single -E

Re: m4(1): add -E flag support

I don't have an objection to this but wouldn't it be less error-prone to include the check_fatal_warns() checks in a warnx() wrapper? There are some fprintf() calls in tokenizer.l that would need to be converted but that still seems simpler than requiring callers of warnx() or the equivalent to

Re: tcpdump: drop atalk support

Let's not support loading addresses from /etc/appletalk.names. There are two points to consider: * tcpdump uses just one file now (/etc/pf.os) which means we can probably simplify priv_getlines(), but let's not right now. * there is some lookup code left, but let's remove it later.

Re: m4(1): add -E flag support

The decisions taken seem correct. I'll let m4 people judge the rest of it.

m4(1): add -E flag support

Hi tech -- I've shared this with a few developers, and have been advised to share now with a wider audience. This diff adds -E flag functionality to m4(1). I wrote this diff after noticing a patch in ports/devel/scons by jasper@ with the comment: XXX: OpenBSD's m4(1) lacks the -E option (needs

Re: wsfont: remove iso7/pcvt encoding macros and entries

On Tue, Jun 13, 2017 at 11:00:52AM +0200, Frederic Cambus wrote: > Hi tech@, > > We do not support iso7 nor pcvt encoding, so remove macro definitions > and commented entries. > > Comments? OK? > ok mlarkin also see what miod said in a later reply, maybe more "-" for you :) > Index:

Re: ping: Style fixes/cleanups

Sorry I don't see the point of (void)printf. It makes code unreadable, and only cleans up pointless false positives from tools. Any such effort is wasted. No bugs are being fixed. Imagine doing it to the entire source tree. The work would never get finished because it is largely pointless to

Re: ping: Style fixes/cleanups

printf's return value is ignored allmost all the times so do the same for the rest of them as well for consistency. Subsequent calls got merged where I think is appropiate and readability improves. The usage format string now looks like it's actual put. Index: ping.c

Re: ping: Style fixes/cleanups

Unify option checking and simply logic. F_HDRINCL and F_ROUTE are mutually exclusive, thus check the latter only if the former one is not set. Index: ping.c === RCS file: /cvs/src/sbin/ping/ping.c,v retrieving revision 1.218 diff

Re: ping: Style fixes/cleanups

The intent here is to get the highest multiple of four smaller or equal than i + 3. Instead of relying on integer division to get rid of the remainder just to "undo" everything, simply clear the lowest two bits (0b11 = 3) leaving multiples of four. Index: ping.c

Re: ping: Style fixes/cleanups

Do not clear the unneeded dst[46] structure. Index: ping.c === RCS file: /cvs/src/sbin/ping/ping.c,v retrieving revision 1.218 diff -u -p -r1.218 ping.c --- ping.c 22 Feb 2017 13:43:35 - 1.218 +++ ping.c 13 Jun

Re: ping: Style fixes/cleanups

On Tue, Jun 13, 2017 at 10:45:57AM -0600, Theo de Raadt wrote: Sorry, but that type of diff is a no-go. You've made a large variety of different decisions on your own and mixed them up with ones which are personal taste, and then touched so many lines of the code that future study of historical

Re: ping: Style fixes/cleanups

Sorry, but that type of diff is a no-go. You've made a large variety of different decisions on your own and mixed them up with ones which are personal taste, and then touched so many lines of the code that future study of historical changes in the code will be confusing. And you've changed the

Re: htpasswd: use crypt_newhash instead of bcrypt API

On 15:31:50, 10.06.17, Ted Unangst wrote: > > @@ -58,17 +58,29 @@ The provided > > .Fa password > > is randomly salted and hashed and stored in > > .Fa hash . > > +.Fa hash > > +must already be allocated, and > > +.Fa hashsize > > +must contain its size, which cannot be less than 61 bytes. > >

ping: Style fixes/cleanups

Ignore return status of all printf calls consistently, merge subsequent ones where appropiate, do not memset unneeded dst structure, simplify/unify option checks, use err not perror, break lines at 80 chars, remove unnecessary parentheses, avoid unobvious integer divsion, make usage format string

Re: games/hunt: /usr/games/lib doesn't exist

As tb@ pointed out, /usr/man/man6 also doesn't exist. Let's remove the whole "Installation" section. OK? Index: games/hunt//README === RCS file: /cvs/src/games/hunt/README,v retrieving revision 1.1.1.1 diff -u -p -r1.1.1.1 README

Re: wsfont: remove iso7/pcvt encoding macros and entries

> Hi tech@, > > We do not support iso7 nor pcvt encoding, so remove macro definitions > and commented entries. If you do that, then you can probably optimize away vga_valid_primary_font() in sys/dev/ic/vga.c as well.

Re: sed(1): missing NUL in pattern space

On Sat, 10 Jun 2017 10:25:27 +, Otto Moerbeek wrote: > Thanks for the analysis and diff, I hope to get a chanche to think > about this soon. At least I'll make sure this diff is not forgotten, > -Otto I have seen the tests that you recently added to the tree; in the mean time, however,

wsfont: remove iso7/pcvt encoding macros and entries

Hi tech@, We do not support iso7 nor pcvt encoding, so remove macro definitions and commented entries. Comments? OK? Index: sys/dev/wscons/wsconsio.h === RCS file: /cvs/src/sys/dev/wscons/wsconsio.h,v retrieving revision 1.82 diff

Re: Copying a file on msdos FS (fat32) changes content

On 06/12/17 21:41, Stefan Fritsch wrote: > On Mon, 12 Jun 2017, Martijn Rijkeboer wrote: >> After upgrading to the latest snapshot there seems to be something wrong >> with the msdos filesystem driver. When I copy a binary file on a msdos >> (fat32) >> mounted partition the content changes e.g.:

Re: update logging in ifstated

Rob Pierce(r...@2keys.ca) on 2017.06.11 18:04:31 -0400: > This minimizes differences with the latest log.c. > > I was not sure how to handle verbosity, as the current implementation is > verbose by default in debug mode. The diff below requires actually > requesting (double) verbosity on the