Re: [PATCH] etc/ksh.kshrc - unify command substitution

2017-07-14 Thread Raf Czlonka
On Fri, Jul 07, 2017 at 05:47:46AM BST, Raf Czlonka wrote: > Hi all, > > I've noticed that etc/ksh.kshrc uses both types of command substitution > `command` and $(command). The below diff unifies it and uses > $(command) notation consistently. > > While there, [...] remove basename(1) invocation

Re: RFC 7217: random but stable addresses (take 3)

2017-07-14 Thread Sebastien Marie
On Fri, Jul 14, 2017 at 11:56:02AM +, Florian Obser wrote: > next try > - sha512 > - fixed key size > - /etc/soii.key > - man page tweaks from sthen & jmc and rewording by me to get rid of 48 bits > - link local address is updated when soii flag is toggled > Could /etc/soii.key be added to

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Jeremie Courreges-Anglas
"Todd C. Miller" writes: > On Sat, 15 Jul 2017 00:24:05 +0200, Jeremie Courreges-Anglas wrote: > >> Wouldn't it be better if we at least tried to properly free what was >> allocated in parse_file()? > > I'm not sure it is worth it since newsyslog is a short-lived

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Todd C. Miller
On Sat, 15 Jul 2017 00:24:05 +0200, Jeremie Courreges-Anglas wrote: > Wouldn't it be better if we at least tried to properly free what was > allocated in parse_file()? I'm not sure it is worth it since newsyslog is a short-lived process. If you feel strongly about this I could take a look at

Re: armv7 sunxi i2c+pmic(=shutdown -p)

2017-07-14 Thread Artturi Alm
On Sun, Jul 09, 2017 at 08:34:29PM +0300, Artturi Alm wrote: > Hi, > > revived the diff below, i2c tested via pmic's shutdown(), for working > "shutdown -p now" operation. > there was only two i2c's w/"status: 'okay'" in the FDT, so not all of > them do attach. > > related part of dmesg: > >

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Jeremie Courreges-Anglas
"Todd C. Miller" writes: > On Fri, 14 Jul 2017 22:59:58 +0200, Jeremie Courreges-Anglas wrote: > >> "Todd C. Miller" writes: >> >> > On Fri, 14 Jul 2017 22:15:49 +0200, Jeremie Courreges-Anglas wrote: >> > >> >> the proposal in >> >> >> >>

Re: RFC 7217: random but stable addresses (take 2)

2017-07-14 Thread Christian Weisgerber
David Gwynne: > secondly, im always wary of truncating hash output in case it throws away > some of the guarantees it's supposed to provide. if you cut sha512 output > down to an 8th of its size, is it 8 times easier to calculate a collision, or > more than 8 times easier? sha384 being a

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Alexander Bluhm
On Fri, Jul 14, 2017 at 11:14:38PM +0200, Jeremie Courreges-Anglas wrote: > I had a diff to (hopefully) free all the allocated memory. But I guess > that the total amount allocated doesn't matter that much and simpler may > be better. ok? OK bluhm@ > > > Index: newsyslog.c >

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Jeremie Courreges-Anglas
Alexander Bluhm writes: > On Fri, Jul 14, 2017 at 10:15:49PM +0200, Jeremie Courreges-Anglas wrote: >> I find this more readable. > > yes, it is > >> /* Step 4, compress the log.0 file if configured to do so and free */ >> -while (p) { >> +

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Todd C. Miller
On Fri, 14 Jul 2017 22:59:58 +0200, Jeremie Courreges-Anglas wrote: > "Todd C. Miller" writes: > > > On Fri, 14 Jul 2017 22:15:49 +0200, Jeremie Courreges-Anglas wrote: > > > >> the proposal in > >> > >> https://marc.info/?l=openbsd-misc=150001966325010=2 > >> >

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Jeremie Courreges-Anglas
"Todd C. Miller" writes: > On Fri, 14 Jul 2017 22:15:49 +0200, Jeremie Courreges-Anglas wrote: > >> the proposal in >> >> https://marc.info/?l=openbsd-misc=150001966325010=2 >> >> made me look at newsyslog and its manually linked lists. Here's a stab >> at using

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Alexander Bluhm
On Fri, Jul 14, 2017 at 10:15:49PM +0200, Jeremie Courreges-Anglas wrote: > I find this more readable. yes, it is > /* Step 4, compress the log.0 file if configured to do so and free */ > - while (p) { > + TAILQ_FOREACH_SAFE(p, , next, tmp) { > if ((p->flags &

Re: Move newsyslog to TAILQ*

2017-07-14 Thread Todd C. Miller
On Fri, 14 Jul 2017 22:15:49 +0200, Jeremie Courreges-Anglas wrote: > the proposal in > > https://marc.info/?l=openbsd-misc=150001966325010=2 > > made me look at newsyslog and its manually linked lists. Here's a stab > at using TAILQs instead. Oh good, now I don't have to do it ;-) I have

Move newsyslog to TAILQ*

2017-07-14 Thread Jeremie Courreges-Anglas
Hi, the proposal in https://marc.info/?l=openbsd-misc=150001966325010=2 made me look at newsyslog and its manually linked lists. Here's a stab at using TAILQs instead. Notes: - no attempt is made to free unused entries. - "free(p)" below isn't enough to properly deallocate the memory used

libexpat 2.2.2 update

2017-07-14 Thread Alexander Bluhm
Hi, libexpat 2.2.2 has been released, I would like to update it in base. ok? bluhm Index: lib/libexpat/Changes === RCS file: /data/mirror/openbsd/cvs/src/lib/libexpat/Changes,v retrieving revision 1.7 diff -u -p -r1.7 Changes ---

Re: RFC 7217: random but stable addresses (take 3)

2017-07-14 Thread Christian Weisgerber
On 2017-07-14, Florian Obser wrote: > --- etc/rc > +++ etc/rc > @@ -47,6 +47,14 @@ update_limit() { > done > } > > +# Apply soii.key settings. > +soii_key() { > + stripcom /etc/soii.key | > + while read _line; do > + sysctl -q

Re: RFC 7217 installer bits

2017-07-14 Thread Robert Peichaer
On Fri, Jul 14, 2017 at 03:43:52PM +, Florian Obser wrote: > diff --git distrib/miniroot/install.sub distrib/miniroot/install.sub > index 26cecd81cbc..bf6c562c882 100644 > --- distrib/miniroot/install.sub > +++ distrib/miniroot/install.sub > @@ -2988,6 +2988,9 @@ do_upgrade() { >

Re: RFC 7217: random but stable addresses (take 3)

2017-07-14 Thread Robert Peichaer
On Fri, Jul 14, 2017 at 11:56:02AM +, Florian Obser wrote: > next try > - sha512 > - fixed key size > - /etc/soii.key > - man page tweaks from sthen & jmc and rewording by me to get rid of 48 bits > - link local address is updated when soii flag is toggled > > If this is the final version I

Re: elf.h

2017-07-14 Thread Amit Kulkarni
> So with this base is compilable and runnable on AMD64. W.r.t. ports, yes, > some of those fails. I've not investigated more closely strange failures > which may be a cause of me not cleaning up fs from previous snapshots -- this > machine is basically 2 years old snapshots accumulation

Re: elf.h

2017-07-14 Thread Karel Gardas
On Fri, 14 Jul 2017 20:44:12 +0200 Karel Gardas wrote: > So with this base is compilable and runnable on AMD64. W.r.t. ports, yes, > some of those fails. I've not investigated more closely strange failures > which may be a cause of me not cleaning up fs from previous

Re: elf.h

2017-07-14 Thread Karel Gardas
Hi, below is another diff of my elf.h cleanup work. I'm still keeping /usr/include/elf_abi.h to not break GHC and all Haskell based ports. What I have done in this version is went thorough whole spec and check everything in the exec_elf.h. What's not in spec I commented out with "not in spec"

RFC 7217 installer bits

2017-07-14 Thread Florian Obser
diff --git distrib/miniroot/install.sub distrib/miniroot/install.sub index 26cecd81cbc..bf6c562c882 100644 --- distrib/miniroot/install.sub +++ distrib/miniroot/install.sub @@ -2988,6 +2988,9 @@ do_upgrade() { hostname $(stripcom /tmp/i/myname) THESETS="$THESETS

RFC 7217: random but stable addresses (take 3)

2017-07-14 Thread Florian Obser
next try - sha512 - fixed key size - /etc/soii.key - man page tweaks from sthen & jmc and rewording by me to get rid of 48 bits - link local address is updated when soii flag is toggled If this is the final version I can cut up the diff and send parts if people prefer. But I also take OKs for the

ifstated regress statemachine whitespace diff

2017-07-14 Thread Rob Pierce
Remove some unwanted whitespace that creeped in. Rob Index: statemachine === RCS file: /cvs/src/regress/usr.sbin/ifstated/statemachine,v retrieving revision 1.1 diff -u -p -r1.1 statemachine --- statemachine14 Jul 2017

Re: Add Diffie-Hellman group negotiation to iked

2017-07-14 Thread viq
And now with log. ikev2_recv: IKE_SA_INIT request from initiator 37.47.4.5:9911 to 31.178.147.125:500 policy 'roadwarrior' id 0, 652 bytes ikev2_recv: ispi 0x5e13d636599e1781 rspi 0x ikev2_policy2id: srcid FQDN/keibi.viq.im length 16 ikev2_pld_parse: header ispi

Re: RFC 7217: random but stable addresses (take 2)

2017-07-14 Thread Florian Obser
On Fri, Jul 14, 2017 at 11:06:49AM +1000, David Gwynne wrote: > > > On 14 Jul 2017, at 06:30, Christian Weisgerber wrote: > > > > On 2017-07-13, Florian Obser wrote: > > > >> It switches the hash function to SipHash24 from sha512 as suggested by dlg >

Re: RFC 7217: random but stable addresses (take 2)

2017-07-14 Thread Florian Obser
On Thu, Jul 13, 2017 at 08:30:55PM -, Christian Weisgerber wrote: > On 2017-07-13, Florian Obser wrote: [...] > > +# Apply soiikey.conf settings. > > +soiikey_conf() { > > + stripcom /etc/soiikey.conf | > > + while read _line; do > > + sysctl -q