[patch] Fix memory leak in dmeg.c

2017-08-31 Thread Nan Xiao
Hi tech@, I am not a nitpicker. Though all memory will be reclaimed after process exits, I still think it's a good habit to release all memory in heap. Best Regards Nan Xiao Index: dmesg.c === RCS file: /cvs/src/sbin/dmesg/dmesg.c,v

Re: iked: Do not accept superfluous arguments

2017-08-31 Thread Klemens Nanni
On Wed, Aug 23, 2017 at 10:42:36PM +0200, Klemens Nanni wrote: > Calling `iked reload' when I meant `ikectl reload' showed that iked > happily returned 0 and and fired up another daemon. > > Feedback? > > Index: iked.c > === > RCS fi

Re: i386 zzz broken, Was: CVS: cvs.openbsd.org: src

2017-08-31 Thread lists
Wed, 30 Aug 2017 16:39:18 -0700 Mike Larkin > On Wed, Aug 30, 2017 at 12:48:20AM -0700, Mike Larkin wrote: > > On Tue, Aug 29, 2017 at 04:32:04PM -0700, Mike Larkin wrote: > > > On Mon, Aug 28, 2017 at 11:18:13PM +0300, li...@wrant.com wrote: > > > > Mon, 28 Aug 2017 10:16:58 -0600 (MDT) Ted U

armv7 a few tc_counter_mask fixes

2017-08-31 Thread Artturi Alm
Hi, I was looking at /sys/sys/timetc.h: 46 struct timecounter { 47 timecounter_get_t *tc_get_timecount; 48 /* 49 * This function reads the counter. It is not required to 50 * mask any unimplemented bits out, as long as they are

Re: some cvstags

2017-08-31 Thread Ian Sutton
On Fri, Sep 01, 2017 at 12:17:29AM +0300, Artturi Alm wrote: > Hi, > > rather obvious diff below. > > -Artturi Thanks, committed

some cvstags

2017-08-31 Thread Artturi Alm
Hi, rather obvious diff below. -Artturi diff --git a/sys/arch/armv7/omap/amdisplay.c b/sys/arch/armv7/omap/amdisplay.c index 912e5407035..f42e201760b 100644 --- a/sys/arch/armv7/omap/amdisplay.c +++ b/sys/arch/armv7/omap/amdisplay.c @@ -1,3 +1,4 @@ +/* $OpenBSD$ */ /* * Copyright (c) 2016 Ia

Re: enum unsigned or not?

2017-08-31 Thread Tom Cosgrove
>>> patrick keshishian 31-Aug-17 20:40 >>> > > On Thu, Aug 31, 2017 at 12:13:19PM -0700, William Ahern wrote: > > On Thu, Aug 31, 2017 at 02:08:07PM +0200, Otto Moerbeek wrote: > > > Hi, > > > > > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > > > unsigned enum expression < 0

refactoring of pf_find_or_create_ruleset()

2017-08-31 Thread Alexandr Nedvedicky
Hello, long time ago mpi@ asked, what I would improve in PF to make the code ready for SMP massage. Everybody knows PF is perfect, right? So it took me a while to find a code for facelift. Patch below breaks pf_find_or_create_ruleset() spaghetti to more chunks: pf_find_or_create_ruleset()

Re: enum unsigned or not?

2017-08-31 Thread patrick keshishian
On Thu, Aug 31, 2017 at 12:13:19PM -0700, William Ahern wrote: > On Thu, Aug 31, 2017 at 02:08:07PM +0200, Otto Moerbeek wrote: > > Hi, > > > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > > unsigned enum expression < 0 is always false [-Wtautological-compare] > > if (

Re: enum unsigned or not?

2017-08-31 Thread William Ahern
On Thu, Aug 31, 2017 at 02:08:07PM +0200, Otto Moerbeek wrote: > Hi, > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > unsigned enum expression < 0 is always false [-Wtautological-compare] > if (state < 0 || state > FAIL) > ~ ^ ~ > /usr/src/usr.sbin/sasy

Re: enum unsigned or not?

2017-08-31 Thread Otto Moerbeek
On Thu, Aug 31, 2017 at 05:10:27PM +0200, Boudewijn Dijkstra wrote: > Op Thu, 31 Aug 2017 14:08:07 +0200 schreef Otto Moerbeek : > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > > unsigned enum expression < 0 is always false [-Wtautological-compare] > > if (state < 0 |

Re: enum unsigned or not?

2017-08-31 Thread Boudewijn Dijkstra
Op Thu, 31 Aug 2017 14:08:07 +0200 schreef Otto Moerbeek : /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of unsigned enum expression < 0 is always false [-Wtautological-compare] if (state < 0 || state > FAIL) ~ ^ ~ /usr/src/usr.sbin/sasyncd/carp.c:166:20: wa

Re: httpd: remove unused media_encoding field

2017-08-31 Thread Hiltjo Posthuma
On Sun, Aug 13, 2017 at 03:53:53PM +0200, Hiltjo Posthuma wrote: > Hi, > > This patch removes the unused media_encoding field, it was probably intended > to > be used to add text-encoding information. > > However: forcing a text-encoding can be useful in some cases. > Currently in httpd.conf the

enum unsigned or not?

2017-08-31 Thread Otto Moerbeek
Hi, /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of unsigned enum expression < 0 is always false [-Wtautological-compare] if (state < 0 || state > FAIL) ~ ^ ~ /usr/src/usr.sbin/sasyncd/carp.c:166:20: warning: comparison of unsigned enum expression < 0 is alw

ksh: histptr and undefined pointer comparisons

2017-08-31 Thread Jeremie Courreges-Anglas
I've noticed this some time ago and, while it doesn't seem to be a problem in practice, it's still undefined. C says what happens with pointers: - within the bounds of an array - one past the last element of an array but nothing about a pointer one element before the first element of an array. T

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-31 Thread Jonathan Gray
On Thu, Aug 31, 2017 at 11:41:44AM +0200, Peter Hessler wrote: > On 2017 Aug 31 (Thu) at 19:16:57 +1000 (+1000), Jonathan Gray wrote: > :On Thu, Aug 31, 2017 at 10:59:20AM +0200, Peter Hessler wrote: > :> On 2017 Aug 31 (Thu) at 10:41:41 +0200 (+0200), Peter Hessler wrote: > :> :On 2017 Aug 27 (Sun

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-31 Thread Peter Hessler
On 2017 Aug 31 (Thu) at 19:16:57 +1000 (+1000), Jonathan Gray wrote: :On Thu, Aug 31, 2017 at 10:59:20AM +0200, Peter Hessler wrote: :> On 2017 Aug 31 (Thu) at 10:41:41 +0200 (+0200), Peter Hessler wrote: :> :On 2017 Aug 27 (Sun) at 22:15:46 +0200 (+0200), Peter Hessler wrote: :> ::- Forwarded

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-31 Thread Jonathan Gray
On Thu, Aug 31, 2017 at 10:59:20AM +0200, Peter Hessler wrote: > On 2017 Aug 31 (Thu) at 10:41:41 +0200 (+0200), Peter Hessler wrote: > :On 2017 Aug 27 (Sun) at 22:15:46 +0200 (+0200), Peter Hessler wrote: > ::- Forwarded message from Peter Hessler - > ::taken from Icenowy Zheng's reposito

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-31 Thread Peter Hessler
On 2017 Aug 31 (Thu) at 10:41:41 +0200 (+0200), Peter Hessler wrote: :On 2017 Aug 27 (Sun) at 22:15:46 +0200 (+0200), Peter Hessler wrote: ::- Forwarded message from Peter Hessler - ::taken from Icenowy Zheng's repository, ::commit bd656cab0c3e0669e977641c15095f32d7b0731f :: ::This gives u

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-31 Thread Peter Hessler
On 2017 Aug 27 (Sun) at 22:15:46 +0200 (+0200), Peter Hessler wrote: :- Forwarded message from Peter Hessler - :taken from Icenowy Zheng's repository, :commit bd656cab0c3e0669e977641c15095f32d7b0731f : :This gives us basic support for the Pine64 Pinebook : :OK? : :$ sysctl hw :hw.machine=a

Re: include pinebook firmware in the install media

2017-08-31 Thread Peter Hessler
On 2017 Aug 27 (Sun) at 21:54:07 +0200 (+0200), Peter Hessler wrote: :(this depends on the patch to u-boot I just sent to ports@) : :If we should manage to boot on a Pinebook machine, we should install the :correct firmware for it. : :OK? : Updated to a now working copy! This grew bsd.rd a bit.