Re: mg: extract exit status from pclose return value

2017-10-23 Thread Scott Cheloha
> On Aug 25, 2017, at 11:27 PM, Scott Cheloha wrote: > > compile_mode() currently just reports the value returned by > pclose(3). This is incorrect because pclose gives you > whatever wait4(2) returned, which needs to be examined > with the various W* macros in to

dd: exit nonzero on receipt of SIGINT

2017-10-23 Thread Scott Cheloha
Hi, Per this bit from POSIX on dd(1): > For SIGINT, the dd utility shall interrupt its current processing, > write status information to standard error, and exit as though > terminated by SIGINT. It shall take the standard action for all > other signals; see [...]. I think we ought to exit

Re: refill msk(4) rx ring from a timeout when there's no mbufs

2017-10-23 Thread David Gwynne
theo pointed out the timeout should be cancelled when the interface goes down. this adds a timeout_del in msk_stop. some other drivers suffer this problem, ill have a look at them once this is in. On Mon, Oct 23, 2017 at 11:35:09AM +1000, David Gwynne wrote: > if msk runs out of mbufs, the rx

Re: kqueue_scan() in parallel

2017-10-23 Thread Alexander Bluhm
On Wed, Oct 18, 2017 at 11:22:01AM +0200, Martin Pieuchot wrote: > Diff below is the last version of my kqueue diff to allow grabbing the > solock() and possibly sleeping, inside kqueue_scan(). I wonder why you don't call knote_release() when calling knote_drop(). Another thread could sleep in

Re: tftpd(8): diff for ip path rewrite

2017-10-23 Thread Jan Klemkow
On Sun, Oct 22, 2017 at 09:32:54PM +, Jeremie Courreges-Anglas wrote: > On Sat, Oct 21 2017, Jan Klemkow wrote: > > On Fri, Oct 20, 2017 at 12:04:41PM +, Jeremie Courreges-Anglas wrote: > >> On Fri, Oct 20 2017, Sebastien Marie wrote: > >> > On

Re: [PATCH] etc/ksh.kshrc - unify command substitution

2017-10-23 Thread Alexander Hall
I'm OK with this. /Alexander On October 23, 2017 3:29:57 PM GMT+02:00, Raf Czlonka wrote: >What say you? > >On Tue, Aug 29, 2017 at 08:44:43PM BST, Raf Czlonka wrote: >> Ping. >> >> Anyone? >> >> On Sun, Jul 16, 2017 at 01:43:32PM BST, Raf Czlonka wrote: >> > Hi all, >>

Re: close cron sockets in child processes

2017-10-23 Thread Jeremie Courreges-Anglas
On Mon, Oct 23 2017, "Todd C. Miller" wrote: > On Mon, 23 Oct 2017 17:27:15 +0200, Jeremie Courreges-Anglas wrote: > >> Here it is. Liberal use of O_CLOEXEC except for poke_daemon() which is >> more obvious (but I can add it there too if you prefer). cronSock >>

Re: close cron sockets in child processes

2017-10-23 Thread Jeremie Courreges-Anglas
On Mon, Oct 23 2017, Jeremie Courreges-Anglas wrote: > On Mon, Oct 23 2017, "Todd C. Miller" wrote: >> On Mon, 23 Oct 2017 09:05:48 +0200, Jeremie Courreges-Anglas wrote: >> >>> That doesn't work. When here, we hold cronSock and dfd (should be 3 and

Re: close cron sockets in child processes

2017-10-23 Thread Todd C. Miller
On Mon, 23 Oct 2017 17:27:15 +0200, Jeremie Courreges-Anglas wrote: > Here it is. Liberal use of O_CLOEXEC except for poke_daemon() which is > more obvious (but I can add it there too if you prefer). cronSock > already uses SOCK_CLOEXEC. You can't set O_CLOEXEC for the fd in atrun.c as that

Re: close cron sockets in child processes

2017-10-23 Thread Jeremie Courreges-Anglas
On Mon, Oct 23 2017, "Todd C. Miller" wrote: > On Mon, 23 Oct 2017 09:05:48 +0200, Jeremie Courreges-Anglas wrote: > >> That doesn't work. When here, we hold cronSock and dfd (should be 3 and >> 4). We need dfd to get fd (should be 5), thus we can't just use >>

Re: [PATCH] etc/ksh.kshrc - unify command substitution

2017-10-23 Thread Raf Czlonka
What say you? On Tue, Aug 29, 2017 at 08:44:43PM BST, Raf Czlonka wrote: > Ping. > > Anyone? > > On Sun, Jul 16, 2017 at 01:43:32PM BST, Raf Czlonka wrote: > > Hi all, > > > > Further simplification - 'ps | grep' can be replaced by pgrep(1) > > and if-then-fi by &&. > > > > > While there: > >

save_errno for SHA256File()

2017-10-23 Thread Peter J. Philipp
Hi, I have a program that constantly stalls on reading /etc/spwd.db with SHA256File() (from sha2.h). Here is the program flow: > sha256file: Operation not permitted on file: /etc/spwd.db 2f6574632f737077642e6462 ^C beta$ stat /etc/spwd.db 1024 78977 -rw-r- 1 root _shadow 327856

Re: close cron sockets in child processes

2017-10-23 Thread Todd C. Miller
On Mon, 23 Oct 2017 09:05:48 +0200, Jeremie Courreges-Anglas wrote: > That doesn't work. When here, we hold cronSock and dfd (should be 3 and > 4). We need dfd to get fd (should be 5), thus we can't just use > "closefrom(3)". The straightest way IMO is to close what we should > close

Re: syslogd file system full

2017-10-23 Thread Alexander Bluhm
Anyone? On Thu, Oct 05, 2017 at 07:19:29PM +0200, Alexander Bluhm wrote: > Hi, > > When /var/log/ is full, syslogd(8) stops writing to these files. > It does this permanently so cleaning /var without SIGHUP to syslogd > does not help. Better retry, write an error message to other log > hosts,

Re: umb(4): recover after temporary loss of packet service

2017-10-23 Thread Stefan Sperling
On Mon, Oct 23, 2017 at 11:25:37AM +0200, Gerhard Roth wrote: > In case we have a temporary loss of connection in umb(4), the USB xfers > may time-out. umb_txeof() should always check whether there are further > mbufs in the if_snd queue; not only after successful transmits. > > Also, aborting

umb(4): recover after temporary loss of packet service

2017-10-23 Thread Gerhard Roth
In case we have a temporary loss of connection in umb(4), the USB xfers may time-out. umb_txeof() should always check whether there are further mbufs in the if_snd queue; not only after successful transmits. Also, aborting the xfer in case the watchdog timer triggers, can help to resume from

Re: close cron sockets in child processes

2017-10-23 Thread Florian Riehm
On 10/23/17 09:05, Jeremie Courreges-Anglas wrote: On Fri, Oct 20 2017, "Todd C. Miller" wrote: On Fri, 20 Oct 2017 16:25:32 +0200, Florian Riehm wrote: cron(8) opens /var/run/cron.sock for communication with crontab(1). The forked cronjobs have the socked still

Re: Enable TCP selective acknowledgements (SACK) on all kernels

2017-10-23 Thread Job Snijders
On Sun, Oct 22, 2017 at 04:04:30PM +0200, Mike Belopuhov wrote: > > If this is as expected, OK job@ > > It's setting the option in my build here: > > 15:55:20.336682 fe:e1:bb:d1:a2:f0 fe:e1:ba:d0:55:1e 0800 78: \ > 10.50.50.34.17078 > 10.50.50.1.80: S [tcp sum ok] 1313610867:1313610867(0) \ >

Re: close cron sockets in child processes

2017-10-23 Thread Jeremie Courreges-Anglas
On Fri, Oct 20 2017, "Todd C. Miller" wrote: > On Fri, 20 Oct 2017 16:25:32 +0200, Florian Riehm wrote: > >> cron(8) opens /var/run/cron.sock for communication with crontab(1). >> The forked cronjobs have the socked still open. >> This prevents restarting cron while a