fwscanf(3) returns ZERO instead of EOF when encountering an early matching failur

Hi, The diff below from FreeBSD r326635 fixes the return value of fwscanf(3) when encountering an early matching failure as the PR noted: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202240 Index: lib/libc/stdio/vfwscanf.c ===

Re: [patch] Log signals and kills generated by traps

You've done absolutely nothing to justify it. > Maybe I'm missing something, but it makes sense to me to log SEGV and > friends in the same manner pledge(2) kills are logged. > > Index: kern/kern_sig.c > === > RCS file:

[patch] Log signals and kills generated by traps

Maybe I'm missing something, but it makes sense to me to log SEGV and friends in the same manner pledge(2) kills are logged. Index: kern/kern_sig.c === RCS file: /cvs/src/sys/kern/kern_sig.c,v retrieving revision 1.212 diff -u -p -u

Re: ksh: drop unused argument from set_prompt()

On Thu, Dec 07 2017, Theo Buehler wrote: > The second argument of "void set_prompt(int, Source *)" is unused ever > since the special treatment of ! and !! in the PS1 expansion was removed > from set_prompt() as part of the implementation of the character count > toggles \[

ksh: drop unused argument from set_prompt()

The second argument of "void set_prompt(int, Source *)" is unused ever since the special treatment of ! and !! in the PS1 expansion was removed from set_prompt() as part of the implementation of the character count toggles \[ and \] way back in 2004. Index: c_sh.c

Propagate http_proxy from installer to rc.firsttime

If you need to use a proxy to fetch the base sets, you'll likely need it when you reboot in order for fw_update and syspatch to work. It's helpful for fw_update especially as it has a painfully long timeout. If the http_proxy was set, simply pass it on to rc.firsttime so you have it a reboot,

Re: mess with regression tests

On 18:01 Mon 04 Dec , Alexander Bluhm wrote: > On Mon, Dec 04, 2017 at 04:56:49PM +0100, Sebastian Benoit wrote: > > > connected to the Makefile in a source directory, tests looks broken. > > > > > > - lib/libexpat/tests/ > > > > (2), but regress/lib/libexpat exists > > I update the libexpat

Re: mess with regression tests

On 16:56 Mon 04 Dec , Sebastian Benoit wrote: > Sergey Bronnikov(serg...@bronevichok.ru) on 2017.12.02 15:31:21 +0300: > > Are there real reasons to keep these tests separately? > > the ones marked (2) should probably be kept, removing them makes the diff to > upstream larger without any gain.

Re: iwm(4) background scan

On Wed, Dec 06, 2017 at 09:25:48AM -0700, Base Pr1me wrote: > Sorry for the anecdotal information. I've enabled debugging and if I see > any relevant data, I'll pass it along. I found one bug which rendered the driver unable to make progress after an association failure. This new version fixes

Re: /usr/local/sbin in default PATH?

Intentional. wheel users add that sbin directory to their path when they need it. Other users should not have it. > Both _PATH_DEFPATH and _PATH_STDPATH, as defined in paths.h, > include /usr/local/bin but not /usr/local/sbin, > as opposed to /usr/bin:/bin:/usr/sbin:/sbin. > Is that

Re: iwm(4) background scan

Sorry for the anecdotal information. I've enabled debugging and if I see any relevant data, I'll pass it along. On Wed, Dec 6, 2017 at 4:43 AM, Stefan Sperling wrote: > On Tue, Dec 05, 2017 at 02:49:49PM -0700, Base Pr1me wrote: > > Two questions: > > > > 1) In the heuristics

Re: ypldap patch 5: fix aldap_close

> The aldap_close() return value is never checked, and I do not see > any good reason to do that. Also, in case close(2) fails, it'll miss > freeing other data. I'm blind. :-\ The problem I was looking for was right here: the aldap_close() closes the wrong file descriptor. So here is a better

Re: [patch] acme-client listen option

> I understand the reason letsencrypt came into existence is the web. So > most environments where acme-client currently is used probably already > have a httpd running. But I suspect the demand for acme-client on > non-webservers will rise and it will feel more like a kludge to > configure,

ypldap patch 6: make client_addr_init() return void

The client_addr_init never returns anything but 0, and this value isn't checked as well, so just make it void. Okay? -- WBR, Vadim Zhukov Index: ldapclient.c === RCS file: /cvs/src/usr.sbin/ypldap/ldapclient.c,v retrieving

Re: [patch] acme-client listen option

On Wed, 6 Dec 2017 13:54:36 + > On 2017/12/06 14:13, Tim Kuijsten wrote: > >But I suspect the demand for acme-client on > > non-webservers will rise and it will feel more like a kludge to > > configure, start and stop a webserver in those environments. > > Using HTTP at

Re: dc: strdup -> bstrdup

On Wed, Dec 06, 2017 at 02:47:13PM +0100, Sebastian Benoit wrote: > Michael W. Bombardieri(m...@ii.net) on 2017.12.06 16:58:27 +0800: > > Hello, > > > > Mostly dc(1) uses its own bstrdup() which exits on error. > > It can be used in two more places. > > i like to read > > if ((a = strdup(b))

Re: [patch] acme-client listen option

On 2017/12/06 14:13, Tim Kuijsten wrote: >But I suspect the demand for acme-client on non-webservers > will rise and it will feel more like a kludge to configure, start and stop a > webserver in those environments. Using HTTP at all for these (even if it's only running

Re: dc: strdup -> bstrdup

On Wed, Dec 06, 2017 at 04:58:27PM +0800, Michael W. Bombardieri wrote: > Hello, > > Mostly dc(1) uses its own bstrdup() which exits on error. > It can be used in two more places. > > - Michael Committed, thanks -Otto > > > Index: dc.c >

Re: dc: strdup -> bstrdup

Michael W. Bombardieri(m...@ii.net) on 2017.12.06 16:58:27 +0800: > Hello, > > Mostly dc(1) uses its own bstrdup() which exits on error. > It can be used in two more places. i like to read if ((a = strdup(b)) == NULL) err(1, NULL); much more than start looking what bstrdup() does...

ypldap patch 5: fix aldap_close

The aldap_close() return value is never checked, and I do not see any good reason to do that. Also, in case close(2) fails, it'll miss freeing other data. Okay? -- WBR, Vadim Zhukov Index: aldap.c === RCS file:

Re: [patch] acme-client listen option

On Tue, Dec 05, 2017 at 01:33:23PM -0700, Theo de Raadt wrote: >That was also the initial design with substantial priv seperation. >It shouldn't be designed to tap another process potentially running >with a different uid. Not wanting to touch processes that run with different user ids, is that

ypldap patch 4: fix fd leak when calling aldap_init

I've just found that under heavy load ypldap's LDAP engine leaks file descriptors. I'll try to post issues I found one-by-one, and here is the first leak I've found. This fixes an fd leak happening if aldap_init() returns NULL. Okay? -- WBR, Vadim Zhukov Index: ldapclient.c

/usr/local/sbin in default PATH?

Both _PATH_DEFPATH and _PATH_STDPATH, as defined in paths.h, include /usr/local/bin but not /usr/local/sbin, as opposed to /usr/bin:/bin:/usr/sbin:/sbin. Is that intentional? Jan Index: include/paths.h === RCS file:

Re: iwm(4) background scan

On Tue, Dec 05, 2017 at 02:49:49PM -0700, Base Pr1me wrote: > Two questions: > > 1) In the heuristics for deciding on the AP, what is used to decide the > best AP. Signal strength with which beacons from the AP were received is the final differentiator. AP selection happens only when a scan ends

dc: strdup -> bstrdup

Hello, Mostly dc(1) uses its own bstrdup() which exits on error. It can be used in two more places. - Michael Index: dc.c === RCS file: /cvs/src/usr.bin/dc/dc.c,v retrieving revision 1.19 diff -u -p -u -r1.19 dc.c --- dc.c

Boot loader's passphrase (or key) advertisement to hard coded full disk encryption

I'm interesting in how to set up hardcoded Key or Passphrase (no keyboard input or USB key is needed) during OpenBSD boot. I have a device without keyboard and/or USB stick connectivity available. It would be great to have full disk encryption, but without any key inputs on startup. Is it