Re: Fix for vi(1) manpage Visual command

2018-02-02 Thread Martijn van Duren
When running in ex-mode it sets itself in vi-mode. When running in vi-mode it's basically an alias to the ex and edit commands. This means that an uppercase first letter splits the screen in two. Personally I find this rather confusing, since we overload the function to mean two different things b

Re: Fix for vi(1) manpage Visual command

2018-02-02 Thread Jason McIntyre
On Fri, Feb 02, 2018 at 08:17:11PM -0700, Anthony J. Bentley wrote: > trondd writes: > > The manpage for vi(1) has a small error for the :Visual/:visual command. > > The > > 'V' can be capital or lowercase, followed by an 'i' and optionally 'sual'. > > Bu > > t > > the manpage shows the command

Re: Fix for vi(1) manpage Visual command

2018-02-02 Thread Anthony J. Bentley
trondd writes: > The manpage for vi(1) has a small error for the :Visual/:visual command. The > 'V' can be capital or lowercase, followed by an 'i' and optionally 'sual'. Bu > t > the manpage shows the command as [Vi]i[sual] instead of [Vv]i[sual]. This reveals a problem with the manpage. Everywh

Fix for vi(1) manpage Visual command

2018-02-02 Thread trondd
The manpage for vi(1) has a small error for the :Visual/:visual command. The 'V' can be capital or lowercase, followed by an 'i' and optionally 'sual'. But the manpage shows the command as [Vi]i[sual] instead of [Vv]i[sual]. The usage text in vi confirms the correct syntax (as does the roff docum

Re: em: minimum ethernet frame size

2018-02-02 Thread Chris Cappuccio
sc->hw.min_frame_size is only used for TBI mode, which is only available on the 82543 according to em_set_media_type() You'd need to carefully analyze how the TBI_ACCEPT macro is used to see what's right here. The macro even seems to assume that the vlan tag size might be part of min_frame_size.

Re: ether_input: more goto dropanyway

2018-02-02 Thread Alexander Bluhm
On Thu, Feb 01, 2018 at 11:38:54PM +0100, Michele Curti wrote: > this diff makes more use of the goto dropanyway instead of repeating > m_freem() and return. > Also change the sizeof(etherbroadcastaddr) with ETHER_ADDR_LEN for > consistency with the other memcmps. Commited, thanks bluhm

tcp timer disarm race

2018-02-02 Thread Alexander Bluhm
Hi, There is a race in the tcp timers. As the may sleep to grab the netlock, they may still run after they have been disarmed. Deleting the timeout is not sufficient to cancel them. But the code from 4.4 BSD is assuming this. So my solution is to add a flag for every timer to see whether it ha

Re: on-line kernel debugging

2018-02-02 Thread bijan
On 02/02/18 04:31, David Gwynne wrote: On 28 Jan 2018, at 04:07, bijan wrote: Thank you (for the quick response) and sorry if I was not as clear as I should have been! what I meant and was hoping to find was a source code debugger support, like gdb[1], where one can debug a running kernel with

Re: [PATCH] bgplg error message fix

2018-02-02 Thread Job Snijders
On Fri, Feb 02, 2018 at 02:38:54PM +0100, Pierre Emeriaud wrote: > While playing with bgplg I noticed that 'show ip bgp detail as' error > message is wrong: expects an AS number but asks for a prefix. Thanks! Committed. Kind regards, Job

[PATCH] bgplg error message fix

2018-02-02 Thread Pierre Emeriaud
Hello While playing with bgplg I noticed that 'show ip bgp detail as' error message is wrong: expects an AS number but asks for a prefix. --- bgplg.h.orig2018-02-02 14:27:29.164112594 +0100 +++ bgplg.h 2018-02-02 14:27:55.255763632 +0100 @@ -57,7 +57,7 @@ { BGPCTL, "show"

em: minimum ethernet frame size

2018-02-02 Thread Michele Curti
Hi, in sys/dev/pci/if_em.c at line 469 there is: sc->hw.min_frame_size = ETHER_MIN_LEN + ETHER_CRC_LEN; But ETHER_MIN_LEN already includes the CRC size: #define ETHER_MIN_LEN 64 /* Minimum frame length, CRC included */ In revision 1.41 the code changed in this way: