Re: switchd: bzero -> memset

2018-04-03 Thread Michael W. Bombardieri
On Tue, Apr 03, 2018 at 10:20:42PM -0600, Theo de Raadt wrote: > Michael W. Bombardieri wrote: > > > Hello, > > > > switchd can just use memset instead of mixing memset with bzero. > > But does the util.c change need to be sync'ed with other tools? > > There are 418 calls to bzero

Re: switchd: bzero -> memset

2018-04-03 Thread Theo de Raadt
Michael W. Bombardieri wrote: > Hello, > > switchd can just use memset instead of mixing memset with bzero. > But does the util.c change need to be sync'ed with other tools? There are 418 calls to bzero in *bin/*/*c bcopy isn't going to be removed from libc, and frankly it is

switchd: bzero -> memset

2018-04-03 Thread Michael W. Bombardieri
Hello, switchd can just use memset instead of mixing memset with bzero. But does the util.c change need to be sync'ed with other tools? - Michael Index: ofp10.c === RCS file: /cvs/src/usr.sbin/switchd/ofp10.c,v retrieving revision

Re: TEST_LOG semantics

2018-04-03 Thread Jeremie Courreges-Anglas
On Tue, Apr 03 2018, Marc Espie wrote: > This exists only so that individual ports may log. Tweaking it anywhere > is awkward (and will be more so with SEPARATE_BUILD). > > I just checked that the current ports tree does not abuse this. > > Okay ? ok jca@ > Index: bsd.port.mk.5

Re: [patch] RSA_new.3

2018-04-03 Thread Theo Buehler
> -typdef struct { > +typedef struct { Fixed, thanks

[patch] RSA_new.3

2018-04-03 Thread Edgar Pettijohn
typo Index: RSA_new.3 === RCS file: /cvs/src/lib/libcrypto/man/RSA_new.3,v retrieving revision 1.4 diff -u -p -u -r1.4 RSA_new.3 --- RSA_new.3    11 Dec 2016 12:52:28 -    1.4 +++ RSA_new.3    3 Apr 2018 21:12:13 - @@ -93,7

TEST_LOG semantics

2018-04-03 Thread Marc Espie
This exists only so that individual ports may log. Tweaking it anywhere is awkward (and will be more so with SEPARATE_BUILD). I just checked that the current ports tree does not abuse this. Okay ? Index: bsd.port.mk.5 === RCS file:

ksh: support 64 bit numbers on 32 bit archs

2018-04-03 Thread Tobias Stoeckmann
Hi, this patch increases the number range on 32 bit architectures like i386 to 64 bit. These are already supported on 64 bit architectures due to using "long". The rational behind this patch is to unify test/expr/ksh in allowing 64 bit integers, making variable handling more consistent in base

Re: hppa MI mutex

2018-04-03 Thread Mark Kettenis
> Date: Tue, 3 Apr 2018 12:36:18 +0200 > From: Martin Pieuchot > > On 03/04/18(Tue) 12:06, Mark Kettenis wrote: > > > Date: Tue, 3 Apr 2018 11:16:45 +0200 > > > From: Martin Pieuchot > > > > > > Here's a diff to switch hppa to the MI mutex implementation.

Re: kqueue EV_DISPATCH and EV_EOF interaction

2018-04-03 Thread Lukas Larsson
On Fri, Mar 30, 2018 at 1:51 AM, Mike Belopuhov wrote: > On Fri, Mar 30, 2018 at 01:21 +0200, Mike Belopuhov wrote: > > > > Hi, > > > > This appears to be an issue with reactivating disabled event sources > > in kqueue_register. Something along the lines of FreeBSD commits:

Re: Earlier FREF() for sys_ioctl()

2018-04-03 Thread Mark Kettenis
> Date: Tue, 3 Apr 2018 16:48:09 +0200 > From: Martin Pieuchot > > Similar to other diffs, this one move a FREF() right after > fd_getfile_mode(), ok? > > Index: kern/sys_generic.c > === > RCS file:

Earlier FREF() for sys_ioctl()

2018-04-03 Thread Martin Pieuchot
Similar to other diffs, this one move a FREF() right after fd_getfile_mode(), ok? Index: kern/sys_generic.c === RCS file: /cvs/src/sys/kern/sys_generic.c,v retrieving revision 1.116 diff -u -p -r1.116 sys_generic.c ---

FREF() for namei()

2018-04-03 Thread Martin Pieuchot
namei() currently uses fd_getfile() without calling FREF()/FRELE() because it doesn't sleep before grabbing a reference on the vnode. This won't be enough as soon as we start unlocking some syscalls, so add a FREF()/FRELE() dance. Ok? Index: kern/vfs_lookup.c

Use FREF() & finishdup() in dupfdopen()

2018-04-03 Thread Martin Pieuchot
Here's another refactoring to properly reference count a 'struct file *' just after calling fd_getfile(). Instead of incrementing `f_count' by hand, give the current reference to finishdup() like it is done in other places in the same file. Ok? Index: kern/kern_descrip.c

Re: autoconf.9 consistency

2018-04-03 Thread Ingo Schwarze
Hi David, David Gwynne wrote on Tue, Apr 03, 2018 at 02:01:33PM +1000: > i landed on this manpage and got confused cos it looked different > to the rest of them. Note that the style of having multiple synopses in multiple sections of a page is used in more than one page - though admittedly in

NFS mount & diskless tweak

2018-04-03 Thread Martin Pieuchot
Diff below changes the representation of a NFS mount point. It is adapted from NetBSD with some tweaks of mine and is required for properly locking NFSnodes. The idea is to keep a reference to the root vnode in 'struct nfsmount' instead of doing a lookup every time VFS_ROOT() is called. Calls

Re: [ed] fixing the list command

2018-04-03 Thread Nils Reuße
> Nils Reuße hat am 27. Februar 2018 um 11:27 geschrieben: > > > Hi there, > > the 'l' command in base ed currently does not mark the end of line with a > '$'. This is documented in the man page (POSIX wants each '$' escaped, and a > final '$' at EOL). Interestingly, the

Re: Looking for testers for em(4) quirks patch

2018-04-03 Thread Bryan Linton
On 2018-04-02 11:52:08, Stefan Fritsch wrote: > Hi, > > We have seen problems with em on i219V and i219LM. For example, "Hardware > Initialization Failed" if no cable is plugged in during boot, or watchdog > timeouts / hangs until next boot if the cable is removed while data

Re: hppa MI mutex

2018-04-03 Thread Martin Pieuchot
On 03/04/18(Tue) 12:06, Mark Kettenis wrote: > > Date: Tue, 3 Apr 2018 11:16:45 +0200 > > From: Martin Pieuchot > > > > Here's a diff to switch hppa to the MI mutex implementation. I'm > > looking for testers, as I don't own such hardware. > > > > Note that our MI mutex

Re: hppa MI mutex

2018-04-03 Thread Mark Kettenis
> Date: Tue, 3 Apr 2018 11:16:45 +0200 > From: Martin Pieuchot > > Here's a diff to switch hppa to the MI mutex implementation. I'm > looking for testers, as I don't own such hardware. > > Note that our MI mutex implementation relies on atomic_cas_ptr(9). On > hppa all the

hppa MI mutex

2018-04-03 Thread Martin Pieuchot
Here's a diff to switch hppa to the MI mutex implementation. I'm looking for testers, as I don't own such hardware. Note that our MI mutex implementation relies on atomic_cas_ptr(9). On hppa all the calls to this function are serialized on a single lock. I don't believe it will introduce

Re: autoconf.9 consistency

2018-04-03 Thread Jason McIntyre
morning. to be honest, I think it's fine as it is now. the intention was obviously to keep the two systems separate. but I don't strongly object to your diff either, so if you feel it is more useful to have it in a more standard format, fine. jmc, sitting on the fence...   Original Message  

Re: Looking for testers for em(4) quirks patch

2018-04-03 Thread Mike Larkin
On Mon, Apr 02, 2018 at 11:52:08AM +0200, Stefan Fritsch wrote: > Hi, > > We have seen problems with em on i219V and i219LM. For example, "Hardware > Initialization Failed" if no cable is plugged in during boot, or watchdog > timeouts / hangs until next boot if the cable is removed while data

Re: sparc64 softraid boot: workaround for memory leak

2018-04-03 Thread Mike Larkin
On Thu, Mar 29, 2018 at 09:21:16AM +0200, Mark Kettenis wrote: > > Date: Wed, 28 Mar 2018 23:46:49 -0700 > > From: Mike Larkin > > > > On Thu, Mar 29, 2018 at 08:40:27AM +0200, Stefan Sperling wrote: > > > On Mon, Mar 12, 2018 at 11:38:14AM +0100, Stefan Sperling wrote: > >