Re: Stop ping telling world its pid

2018-04-11 Thread Job Snijders
When things arrive out of sequence, that usually is of special interest to network operator people. Not sure the sequence field can easily be overloaded to increase “validity”. I’m not great at math, with a 16 bit random value, wouldn’t we start running into ID collisions around 256 concurrent

Re: Stop ping telling world its pid

2018-04-11 Thread Theo de Raadt
"The standard convention of using the locally-significant PID should be fine." Jimmy Hess, 2018 A whole bunch of protocols got holed because of that attitude.

Re: Stop ping telling world its pid

2018-04-11 Thread Theo de Raadt
We never claimed that OpenBSD ping conforms to the 'High Availability ICMP ECHO' RFC. Jimmy Hess wrote: > On Tue, Apr 10, 2018 at 3:11 PM, Vadim Zhukov wrote: > > > While working on home job for students, I've come across two > > questionable thingies in

Re: Stop ping telling world its pid

2018-04-11 Thread Jimmy Hess
On Tue, Apr 10, 2018 at 3:11 PM, Vadim Zhukov wrote: > While working on home job for students, I've come across two > questionable thingies in ping.c: > > 1. It sends process PID (well, last 16 bits) to the network. >Maybe I'm a bit paranoid, but this looks like bad idea

Re: subr_autoconf: allow _attach to fail? w/no void2int churn option

2018-04-11 Thread Artturi Alm
On Tue, Apr 10, 2018 at 02:40:29PM -0600, Theo de Raadt wrote: > >On Mon, Apr 09, 2018 at 11:11:22AM -0600, Theo de Raadt wrote: > >> I think this approach is wrong, insane, and fragile. DVF_ACTIVE > >> doesn't work precisely that way. > > > >Yes, it's a hack, but i don't see it as fragile, nor

Re: interpolation -> interpretation

2018-04-11 Thread Stuart Henderson
On 2018/04/11 22:55, Jan Stary wrote: > I am not a native speaker, but printf(3) "interprets" the conversion > specifiers, it does not "interpolate" them, right? interpolation is correct. > Jan > > Index: printf.3 > === >

Re: ifconfig,route,netstat: s/tableid/rtable/ for consistency

2018-04-11 Thread Klemens Nanni
On Wed, Apr 11, 2018 at 09:28:03AM +0200, Peter Hessler wrote: > No, all of these uses are correct as-is. `tableid' surely isn't wrong, but using the argument name across manuals seems nicer to me. Or is there any real difference between `tableid' and `rtable' I'm not aware of?

interpolation -> interpretation

2018-04-11 Thread Jan Stary
I am not a native speaker, but printf(3) "interprets" the conversion specifiers, it does not "interpolate" them, right? Jan Index: printf.3 === RCS file: /cvs/src/lib/libc/stdio/printf.3,v retrieving revision 1.78 diff -u -p

Re: Stop ping telling world its pid

2018-04-11 Thread Florian Obser
On Tue, Apr 10, 2018 at 11:11:39PM +0300, Vadim Zhukov wrote: > Hi all! > > While working on home job for students, I've come across two > questionable thingies in ping.c: > > 1. It sends process PID (well, last 16 bits) to the network. >Maybe I'm a bit paranoid, but this looks like bad

Re: vput(9) for NFS

2018-04-11 Thread Visa Hankala
On Wed, Apr 11, 2018 at 12:34:03PM +0200, Martin Pieuchot wrote: > On 09/04/18(Mon) 16:10, Martin Pieuchot wrote: > > Diff below implements most of the missing locking goo for NFS without > > enabling it. It does the following: > > > > - Add a missing PDIRUNLOCK in nfs_lookup() > > > > - Change

[patch] Chane wfd to static variable in cat.c

2018-04-11 Thread Nan Xiao
Hi tech@, It seems "wfd" only need get its value when first calling "raw_cat", so maybe a static variable should be better. Sorry if I am wrong. Thanks! Index: cat.c === RCS file: /cvs/src/bin/cat/cat.c,v retrieving revision 1.26

Re: vput(9) for NFS

2018-04-11 Thread Martin Pieuchot
On 09/04/18(Mon) 16:10, Martin Pieuchot wrote: > Diff below implements most of the missing locking goo for NFS without > enabling it. It does the following: > > - Add a missing PDIRUNLOCK in nfs_lookup() > > - Change vrele(9) into vput(9) where necessary. nfs_nget() will in > future return a

Re: tmux fix when renaming session with no client attached

2018-04-11 Thread Nicholas Marriott
Fixed, thanks! On Tue, Apr 10, 2018 at 04:31:38PM -0700, Ryan Freeman wrote: > Hey, > > After upgrading OpenBSD 6.2 -> 6.3, a program I am building for $DAYJOB > started malfunctioning. > > Basically, we use tmux to manage running sessions of this program, which > does automated work on

Re: Stop telling patch runs ed

2018-04-11 Thread Sebastian Benoit
Vadim Zhukov(persg...@gmail.com) on 2018.04.11 12:10:39 +0300: > Hi all. > > Lets stop lying that patch(1) runs ed(1). Okay? ok > Or should we tell > explicitly mention that we don't do bad things? No, otherwise we would have to document lots of bad things that we do not do in manpages ;) >

Stop telling patch runs ed

2018-04-11 Thread Vadim Zhukov
Hi all. Lets stop lying that patch(1) runs ed(1). Okay? Or should we tell explicitly mention that we don't do bad things? -- WBR, Vadim Zhukov Index: patch.1 === RCS file: /cvs/src/usr.bin/patch/patch.1,v retrieving revision

Re: ifconfig,route,netstat: s/tableid/rtable/ for consistency

2018-04-11 Thread Peter Hessler
No, all of these uses are correct as-is. On 2018 Apr 10 (Tue) at 23:23:24 +0200 (+0200), Klemens Nanni wrote: :Several tools may operate on specific routing tables (or routing domains :in special cases). : :With the exception of `tableid' in ifconfig(8), route(8) and netstat(1), :all other