Re: Should rm(1) -Pf change file permission?

2018-04-17 Thread Ingo Schwarze
Hi Gregoire, Gregoire Jadi wrote on Tue, Apr 17, 2018 at 11:44:41AM +0200: > Ingo Schwarze writes: >> Feedback is welcome both on the general idea and on the specific >> implementation. The result of that feeback was "we don't want it, the whole idea of changing this is

Re: Kernel size beyond 16 MB on amd64

2018-04-17 Thread Franco Fichtner
Hi Stuart et al., Sorry for the delay. Meanwhile, I've been reproducing the issue on 6.3 by adding device rd and increasing MINIROOTSIZE to grow the non-gdb amd64 kernel beyond 16 MB. The kernel simply fails to boot. > If the kernel should grow to a point where we run past some limit, we'll

Re: FREF(9) in unp_internalize()

2018-04-17 Thread Todd C. Miller
On Tue, 17 Apr 2018 09:50:49 +0200, Martin Pieuchot wrote: > Sure, here's an updated diff. It also moves the FRELE(9) in the error > loop down as suggested by visa@. OK millert@ - todd

Re: Should rm(1) -Pf change file permission?

2018-04-17 Thread Grégoire Jadi
Ingo Schwarze writes: Hi, > Hi, > > Gregoire Jadi wrote on Fri, Mar 30, 2018 at 06:07:42PM +0200: > >> While working on a port of keyringer, I observed the following behavior >> of rm(1) with the -P option: if the file does not have write permission, >> the file is removed

Introduce fd_iterfile()

2018-04-17 Thread Martin Pieuchot
Diff below introduces a new helper function to iterate on `filehead'. This global data structures contains a reference to living 'struct file *' so its access must be serialized with fdrop(). This is what the comment below explains. Currently the serialization is done by the KERNEL_LOCK(), but

Re: FREF(9) in unp_internalize()

2018-04-17 Thread Martin Pieuchot
On 16/04/18(Mon) 09:09, Todd C. Miller wrote: > On Mon, 16 Apr 2018 10:19:40 +0200, Martin Pieuchot wrote: > > > Diff below does FREF(9) earlier instead of incrementing `f_count' by hand. > > > > The error path is also updated to call FRELE(9) accordingly. > > Wouldn't it be less error prone to

Re: vmd: enable pause/unpause for vm owners

2018-04-17 Thread Pratik Vyas
* Mohamed Aslan [2018-04-16 00:54:43 -0400]: Hello tech@, I noticed that vmd(8) only allows VM owners to start/stop their VMs, but does not let them to pause/unpause those VMs. I was just wondering if there are reasons behind that. If not, the patch below enables