Re: errors in usage.c - libusbhid

2018-07-02 Thread Martin Pieuchot
On 02/07/18(Mon) 23:08, David Bern wrote: > > Is it necessary to parse these examples? Or maybe we can live with > > your strtonum() fix for now. > I can live with that. > > > I don't know. So unless somebody else gives us some input I'd suggest > > we move forward with your safe diff even if

teach tcpdump about gre-in-udp encapsulation

2018-07-02 Thread David Gwynne
this is the simplest diff i could make that adds gre in udp handling to tcpdump. ok? Index: print-udp.c === RCS file: /cvs/src/usr.sbin/tcpdump/print-udp.c,v retrieving revision 1.40 diff -u -p -r1.40 print-udp.c --- print-udp.c 22

/etc/services lines for gre-in-udp

2018-07-02 Thread David Gwynne
RFC8086 and IANA say that the following ports are defined for gre in udp encapsulations. ok?

Re: errors in usage.c - libusbhid

2018-07-02 Thread David Bern
> Is it necessary to parse these examples? Or maybe we can live with > your strtonum() fix for now. I can live with that. > I don't know. So unless somebody else gives us some input I'd suggest > we move forward with your safe diff even if it doesn't fix all the > cases. > > If it fixes your

Re: add a bunch of logitech webcam ids to usbdevs

2018-07-02 Thread Landry Breuil
On Mon, Jul 02, 2018 at 09:29:04PM +0200, Mark Kettenis wrote: > > Date: Mon, 2 Jul 2018 21:10:26 +0200 > > From: Landry Breuil > > > > ok ? > > Why? How do they show up right now? We typically only add USB IDs > for hardware that needs quirks or doesn't have a useful string > embedded in the

Re: add a bunch of logitech webcam ids to usbdevs

2018-07-02 Thread Theo Buehler
On Mon, Jul 02, 2018 at 09:29:04PM +0200, Mark Kettenis wrote: > > Date: Mon, 2 Jul 2018 21:10:26 +0200 > > From: Landry Breuil > > > > ok ? > > Why? How do they show up right now? We typically only add USB IDs > for hardware that needs quirks or doesn't have a useful string > embedded in the

Re: add a bunch of logitech webcam ids to usbdevs

2018-07-02 Thread Mark Kettenis
> Date: Mon, 2 Jul 2018 21:10:26 +0200 > From: Landry Breuil > > ok ? Why? How do they show up right now? We typically only add USB IDs for hardware that needs quirks or doesn't have a useful string embedded in the hardware. > Index: usbdevs >

add a bunch of logitech webcam ids to usbdevs

2018-07-02 Thread Landry Breuil
ok ? Index: usbdevs === RCS file: /cvs/src/sys/dev/usb/usbdevs,v retrieving revision 1.686 diff -u -r1.686 usbdevs --- usbdevs 28 Jun 2018 15:02:06 - 1.686 +++ usbdevs 2 Jul 2018 19:08:08 - @@ -2575,8 +2575,12 @@

Re: [PATCH] fix typo in if_aue.c

2018-07-02 Thread Rob Pierce
Ok rob@ > From: "Kevin Lo" > To: "tech" > Sent: Monday, July 2, 2018 10:23:39 AM > Subject: [PATCH] fix typo in if_aue.c > Hi, > I've just noticed a little typo in the if_aue.c (s/read/write). > The diff is below. > Index: sys/dev/usb/if_aue.c >

Re: [PATCH] mos: nuke unused variable

2018-07-02 Thread Rob Pierce
Ok rob@ > From: "Kevin Lo" > To: "tech" > Sent: Monday, July 2, 2018 10:22:58 AM > Subject: [PATCH] mos: nuke unused variable > Ok ? > Index: sys/dev/usb/if_mos.c > === > RCS file: /cvs/src/sys/dev/usb/if_mos.c,v > retrieving

v_dirtyblkhd list macros

2018-07-02 Thread Alexander Bluhm
Hi, Can we use more list macros for v_dirtyblkhd? ok? bluhm Index: kern/spec_vnops.c === RCS file: /data/mirror/openbsd/cvs/src/sys/kern/spec_vnops.c,v retrieving revision 1.92 diff -u -p -r1.92 spec_vnops.c --- kern/spec_vnops.c

Re: fdexpand() & open file tracking

2018-07-02 Thread Martin Pieuchot
On 02/07/18(Mon) 11:22, Martin Pieuchot wrote: > Let's use a array of structures to keep track of open files. This will > allow us to simplify locking when expending it. > > While here consistently use M_ZERO when (re)allocating M_FILEDESC > structures. I doubt the memset() solution makes any

Re: xhci@acpi

2018-07-02 Thread Mark Kettenis
> Date: Mon, 2 Jul 2018 08:31:23 -0700 > From: Mike Larkin > > On Mon, Jul 02, 2018 at 11:36:59AM +0200, Mark Kettenis wrote: > > Totally straightforward. > > > > ok? > > > > > > ok mlarkin > > Just wondering if you need to update the man pages for ahci(4) > and xhci(4) to include the "at

Re: xhci@acpi

2018-07-02 Thread Mike Larkin
On Mon, Jul 02, 2018 at 11:36:59AM +0200, Mark Kettenis wrote: > Totally straightforward. > > ok? > > ok mlarkin Just wondering if you need to update the man pages for ahci(4) and xhci(4) to include the "at acpi0" attachments? -ml > Index: arch/arm64/conf/GENERIC >

[PATCH] fix typo in if_aue.c

2018-07-02 Thread Kevin Lo
Hi, I've just noticed a little typo in the if_aue.c (s/read/write). The diff is below. Index: sys/dev/usb/if_aue.c === RCS file: /cvs/src/sys/dev/usb/if_aue.c,v retrieving revision 1.106 diff -u -p -u -p -r1.106 if_aue.c ---

[PATCH] mos: nuke unused variable

2018-07-02 Thread Kevin Lo
Ok ? Index: sys/dev/usb/if_mos.c === RCS file: /cvs/src/sys/dev/usb/if_mos.c,v retrieving revision 1.38 diff -u -p -u -p -r1.38 if_mos.c --- sys/dev/usb/if_mos.c22 Jan 2017 10:17:39 - 1.38 +++ sys/dev/usb/if_mos.c

xhci@acpi

2018-07-02 Thread Mark Kettenis
Totally straightforward. ok? Index: arch/arm64/conf/GENERIC === RCS file: /cvs/src/sys/arch/arm64/conf/GENERIC,v retrieving revision 1.74 diff -u -p -r1.74 GENERIC --- arch/arm64/conf/GENERIC 1 Jul 2018 19:30:37 -

fdexpand() & open file tracking

2018-07-02 Thread Martin Pieuchot
Let's use a array of structures to keep track of open files. This will allow us to simplify locking when expending it. While here consistently use M_ZERO when (re)allocating M_FILEDESC structures. I doubt the memset() solution makes any difference these days and the resulting code is simpler to