Re: slaacd, can we use AF_INET6 to restrict route messages?

2018-07-05 Thread Claudio Jeker
On Thu, Jul 05, 2018 at 10:51:24PM +0100, Stuart Henderson wrote: > I noticed relatively high cpu use from slaacd on a BGP router > that was undergoing some route churn earlier (no interfaces were > actually configured to use slaac). > > routesock is currently unfiltered so will see a lot of messa

Re: pthread_barrier_init: check count argument

2018-07-05 Thread Philip Guenther
On Thu, Jul 5, 2018 at 1:20 AM Paul Irofti wrote: > POSIX mandates that we return EINVAL if count equals zero on barrier > initialization. Which makes sense to me. > > This also fixes posixtestsuite conformance 3-1 test. > > OK? > ok guenther@

slaacd, can we use AF_INET6 to restrict route messages?

2018-07-05 Thread Stuart Henderson
I noticed relatively high cpu use from slaacd on a BGP router that was undergoing some route churn earlier (no interfaces were actually configured to use slaac). routesock is currently unfiltered so will see a lot of messages, frontend_routesock is filtered but will still see all RTM_DELETE which

Re: clock(): why is CLOCKS_PER_SEC 100 and not 1,000,000?

2018-07-05 Thread Scott Cheloha
On Thu, Jul 05, 2018 at 09:28:34AM -0400, Scott Cheloha wrote: > > On Jul 5, 2018, at 6:51 AM, Paul Irofti wrote: > > > > [...] > > From [1]: > > > The value of CLOCKS_PER_SEC shall be 1 million on XSI-conformant systems. > > However, it may be variable on other systems, and it should not be as

Re: clock(): why is CLOCKS_PER_SEC 100 and not 1,000,000?

2018-07-05 Thread Scott Cheloha
> On Jul 5, 2018, at 6:51 AM, Paul Irofti wrote: > > Hi, > > POSIX requires that CLOCKS_PER_SEC be 1,000,000[0,1]. > > Any reason we have it set to 100? > > Paul > > [0] -- http://pubs.opengroup.org/onlinepubs/009695399/functions/clock.html > [1] -- http://pubs.opengroup.org/onlinepubs/009695

Re: pthread_barrier_init: check count argument

2018-07-05 Thread Mark Kettenis
> Date: Thu, 5 Jul 2018 13:19:20 +0300 > From: Paul Irofti > > Hi, > > POSIX mandates that we return EINVAL if count equals zero on barrier > initialization. Which makes sense to me. > > This also fixes posixtestsuite conformance 3-1 test. > > OK? > > > Index: rthread_barrier.c > ===

bgpd introduce filterstate

2018-07-05 Thread Claudio Jeker
Next step on the bigger RIB refactor. Introduce a filterstate instead of passing multiple things around. As a benefit this reduces the amount of malloc() / free() calls because the rde_aspath is now on the stack. After that more changes will become possible like moving nexthop into the state, etc.

Re: [PATCH] fakertc: A Real time clock simulator

2018-07-05 Thread Mark Kettenis
> From: Aaron Lancaster > Date: Wed, 4 Jul 2018 11:40:38 -0600 > > I wrote this patch/script to deal with a very irritating case of > circular dependency failure I recently encountered on an APU2 system. > > On systems with non-existent or dead battery real time clocks, with DNS > over TLS being

Re: priofilter and rtm message types

2018-07-05 Thread Claudio Jeker
On Wed, Jul 04, 2018 at 11:51:46PM +0200, Sebastian Benoit wrote: > Remi noticed that ospfd does no longer see new interfaces. > > The priority filter should only work on routing messages that > have a rtm_priority. > > So these are out: > > RTM_DELADDR > RTM_NEWADDR (struct ifa_msghdr) > RTM_IF

clock(): why is CLOCKS_PER_SEC 100 and not 1,000,000?

2018-07-05 Thread Paul Irofti
Hi, POSIX requires that CLOCKS_PER_SEC be 1,000,000[0,1]. Any reason we have it set to 100? Paul [0] -- http://pubs.opengroup.org/onlinepubs/009695399/functions/clock.html [1] -- http://pubs.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

pthread_barrier_init: check count argument

2018-07-05 Thread Paul Irofti
Hi, POSIX mandates that we return EINVAL if count equals zero on barrier initialization. Which makes sense to me. This also fixes posixtestsuite conformance 3-1 test. OK? Index: rthread_barrier.c === RCS file: /cvs/src/lib/librthr

Network syscalls description: why we can unlock them

2018-07-05 Thread Martin Pieuchot
Diff below unlocks 12 network syscalls. It relies on the recent work that has been to make 'struct file' refcounting mpsafe and on the corresponding socket lock before messing with the content of any socket. Why can we unlock the following syscall? Here's an explanation. - sys_recvmsg() and sys

Re: uaudio: fix detection of a bunch of logitech webcams

2018-07-05 Thread Landry Breuil
On Thu, Jul 05, 2018 at 11:04:34AM +0200, Martin Pieuchot wrote: > On 05/07/18(Thu) 09:28, Landry Breuil wrote: > > On Fri, Jun 29, 2018 at 01:50:24PM +0200, Landry Breuil wrote: > > > On Fri, Jun 29, 2018 at 09:05:56AM +0200, Remco wrote: > > > > > > If you don't find any better solution, I'd sugg

Re: uaudio: fix detection of a bunch of logitech webcams

2018-07-05 Thread Martin Pieuchot
On 05/07/18(Thu) 09:28, Landry Breuil wrote: > On Fri, Jun 29, 2018 at 01:50:24PM +0200, Landry Breuil wrote: > > On Fri, Jun 29, 2018 at 09:05:56AM +0200, Remco wrote: > > > > > If you don't find any better solution, I'd suggest using a device ID > > > > > check rather than adding a quirk. Becaus

uaudio: fix detection of a bunch of logitech webcams

2018-07-05 Thread Landry Breuil
On Fri, Jun 29, 2018 at 01:50:24PM +0200, Landry Breuil wrote: > On Fri, Jun 29, 2018 at 09:05:56AM +0200, Remco wrote: > > > > If you don't find any better solution, I'd suggest using a device ID > > > > check rather than adding a quirk. Because such quirk cannot be generic. > > > > In that case