uaudio: simplify free() usage

2018-07-22 Thread Michael W. Bombardieri
Hello, A few NULL checks before free() can be removed in uaudio. Immediately freeing the value returned by uaudio_io_terminaltype() seems a little strange but I didn't look into that further. - Michael Index: uaudio.c === RCS file:

Re: slaacd(8): moving between networks

2018-07-22 Thread Peter Hessler
On 2018 Jul 22 (Sun) at 18:19:01 +0200 (+0200), Florian Obser wrote: :When one is connected to a network, suspends or hibernates, moves to a :different network and wakes up one ends up with ip addresses from both :networks and things probably go sideways. There is a good chance that :source address

Re: pcidevs Sandisk or WD

2018-07-22 Thread Bryan Vyhmeister
On Sun, Jul 22, 2018 at 11:50:07AM -0600, Theo de Raadt wrote: > Better. > > It is important to not fall into the trap of doing marketing for > vendors. But also keep in mind another product is likely months away, > and then what to you do? True. Good point. I also did not think about what kette

Re: pcidevs Sandisk or WD

2018-07-22 Thread Theo de Raadt
Better. It is important to not fall into the trap of doing marketing for vendors. But also keep in mind another product is likely months away, and then what to you do? Mark Kettenis wrote: > > Date: Sun, 22 Jul 2018 10:14:11 -0700 > > From: Bryan Vyhmeister > > > > Here is the output from dm

Re: pcidevs Sandisk or WD

2018-07-22 Thread Theo de Raadt
Bryan Vyhmeister wrote: > On Sun, Jul 22, 2018 at 11:19:00AM -0600, Theo de Raadt wrote: > > This is unreasonable. > > > > 1. Can I add High-performance to every 2nd line in this file? After all, > >I bet everyone would love to claim that for their hardware. > > I'm sure. That's the only w

Re: pcidevs Sandisk or WD

2018-07-22 Thread Bryan Vyhmeister
On Sun, Jul 22, 2018 at 07:36:32PM +0200, Mark Kettenis wrote: > And it seems that at least the 500G an 1TB models have been marketed > as SanDisk Extreme PRO: > > > https://www.anandtech.com/show/12543/the-western-digital-wd-black-3d-nand-ssd-review > > The names are a bit long. Googling for

Re: pcidevs Sandisk or WD

2018-07-22 Thread Bryan Vyhmeister
On Sun, Jul 22, 2018 at 11:19:00AM -0600, Theo de Raadt wrote: > This is unreasonable. > > 1. Can I add High-performance to every 2nd line in this file? After all, >I bet everyone would love to claim that for their hardware. I'm sure. That's the only way the generation one and two hardware a

Re: pcidevs Sandisk or WD

2018-07-22 Thread Mark Kettenis
> Date: Sun, 22 Jul 2018 10:14:11 -0700 > From: Bryan Vyhmeister > > Here is the output from dmesg before and after. > > nvme0 at pci3 dev 0 function 0 unknown vendor 0x15b7 product 0x5002 rev 0x00: > msi, NVMe 1.3 > nvme0: WDS500G2X0C-00L350, firmware 101110WD, serial 181123456789 > > nvme0 a

Re: pcidevs Sandisk or WD

2018-07-22 Thread Theo de Raadt
This is unreasonable. 1. Can I add High-performance to every 2nd line in this file? After all, I bet everyone would love to claim that for their hardware. 2. These product strings get embedded *into the kernel*, bloating it. 3. As a result, we use short boring names, or highly descriptive

Re: pcidevs Sandisk or WD

2018-07-22 Thread Bryan Vyhmeister
Here is the output from dmesg before and after. nvme0 at pci3 dev 0 function 0 unknown vendor 0x15b7 product 0x5002 rev 0x00: msi, NVMe 1.3 nvme0: WDS500G2X0C-00L350, firmware 101110WD, serial 181123456789 nvme0 at pci3 dev 0 function 0 "SanDisk WD Black High-performance NVMe SSD" rev 0x00: msi

Re: spamd.conf.5: document https

2018-07-22 Thread Jason McIntyre
On Fri, Jul 20, 2018 at 01:09:48PM +0300, Lauri Tirkkonen wrote: > Hi, > > spamd.conf supports method=https, but this is not documented. So > document it and also modify the example config to default to it. > committed, thanks. jmc > diff --git a/etc/mail/spamd.conf b/etc/mail/spamd.conf > inde

slaacd(8): moving between networks

2018-07-22 Thread Florian Obser
When one is connected to a network, suspends or hibernates, moves to a different network and wakes up one ends up with ip addresses from both networks and things probably go sideways. There is a good chance that source address selection picks the wrong IP. One common suggestion is that slaacd shou

Re: slaacd(8): handle duplicate addresses

2018-07-22 Thread Florian Obser
anyone? On Wed, Jul 18, 2018 at 01:55:37PM +0200, Florian Obser wrote: > > Handle duplicate address detection failures. > > We get notified when duplication is detected on the route socket. For > privacy addresses simply generate a new random address. If we have > soii enabled increase the dad c

rasops(9): Remove rasops4 functions?

2018-07-22 Thread Frederic Cambus
Hi tech@, Nothing uses the rasops4 (4-bit color depth) functions anymore. It seems unlikely that any future new platform will ever need them. Should we remove them? Comments? OK? Index: sys/conf/files === RCS file: /cvs/src/sys/co

Re: [diff] www/innovations.html: fix link

2018-07-22 Thread Ingo Schwarze
Hi Clemens, Clemens Goessnitzer wrote on Sun, Jul 22, 2018 at 01:41:50PM +0200: > fix link to man.cgi(8) in www/innovations.html, diff attached committed, thanks. It may take a short time to get synched to the website. Yours, Ingo > Index: innovations.html > ===

[diff] www/innovations.html: fix link

2018-07-22 Thread Clemens Goessnitzer
fix link to man.cgi(8) in www/innovations.html, diff attached Index: innovations.html === RCS file: /cvs/www/innovations.html,v retrieving revision 1.66 diff -u -p -r1.66 innovations.html --- innovations.html10 Jul 2018 17:47:28 -

mg(1): Ignore dirty flag on *undo* buffer

2018-07-22 Thread Joachim Nilsson
Hi guys, here's a patch to mg I did a couple of years ago to my fork[1], maybe it's interesting to other people as well. Best regards /Joachim [1]: https://github.com/troglobit/mg -- >From b14456674b9c78fdcabe14d802a9d7315d5a67a2 Mon Sep 17 00:00:00 2001 From: Joachim Nilsson Date: Sat, 14

Re: show advertised MTU in slaacctl

2018-07-22 Thread Theo Buehler
On Sun, Jul 22, 2018 at 10:32:31AM +0200, Björn Ketelaars wrote: > On Sun 22/07/2018 07:27, Björn Ketelaars wrote: > > Now that rad(8) is able to advertise a MTU I think it would be nice to > > have slaacctl(8) show this advertisement. The patch below touches both > > sbin/slaacd and usr.sbin/slaac

Re: show advertised MTU in slaacctl

2018-07-22 Thread Björn Ketelaars
On Sun 22/07/2018 07:27, Björn Ketelaars wrote: > Now that rad(8) is able to advertise a MTU I think it would be nice to > have slaacctl(8) show this advertisement. The patch below touches both > sbin/slaacd and usr.sbin/slaacctl. The addition to sbin/slaacd/engine.c > makes sure that MTU RA messag