Re: umidi(4) jack count

2018-09-06 Thread Alexandre Ratchov
On Fri, Sep 07, 2018 at 12:40:49AM +0800, Michael Mikonos wrote: > Hello, > > The umidi(4) driver has three different endpoint allocation > functions, which are called by alloc_all_endpoints(). The > initial jack count can be moved here because it is zero > no matter which allocation function is

Re: umidi(4) jack count

2018-09-06 Thread Stefan Sperling
On Fri, Sep 07, 2018 at 12:40:49AM +0800, Michael Mikonos wrote: > Hello, > > The umidi(4) driver has three different endpoint allocation > functions, which are called by alloc_all_endpoints(). The > initial jack count can be moved here because it is zero > no matter which allocation function is

Re: cp(1) Fix incomplete -i behaviour [1/3]

2018-09-06 Thread Stefan Sperling
On Fri, Aug 31, 2018 at 09:40:19AM +0200, Martijn van Duren wrote: > Hello tech@, > > While working on fixing the -iv behaviour yesterday I noticed that the > -i verification isn't implemented for the special copies and thus > allowing to overwrite a file. > I did some archaeology and found it

Re: cp(1) Fix incomplete -i behaviour [2/3]

2018-09-06 Thread Stefan Sperling
On Fri, Aug 31, 2018 at 09:42:08AM +0200, Martijn van Duren wrote: > part 2 > > OK? ok stsp@ > > martijn@ > > diff --git cp.c cp.c > index 321e82f..fbf924c 100644 > --- cp.c > +++ cp.c > @@ -395,9 +395,9 @@ copy(char *argv[], enum op type, int fts_options) > > switch

Re: cp(1) Fix incomplete -i behaviour [3/3]

2018-09-06 Thread Stefan Sperling
On Fri, Aug 31, 2018 at 09:43:03AM +0200, Martijn van Duren wrote: > part 3 > > OK? ok stsp@ > > martijn@ > > diff --git cp.c cp.c > index fbf924c..2ccef08 100644 > --- cp.c > +++ cp.c > @@ -434,7 +434,7 @@ copy(char *argv[], enum op type, int fts_options) >

Re: cp(1) Don't trigger -v if -i causes a skip

2018-09-06 Thread Stefan Sperling
On Thu, Aug 30, 2018 at 09:02:22PM +0200, Martijn van Duren wrote: > Hello tech@, > > Don't know if this is too much magic numbers for copy_file, but this > "fixes" the case where we print the verbose line, even if we don't copy > it. This doesn't not happen in mv or rm. > > Note that the

Re: httpd: block return with a contentless status

2018-09-06 Thread Florian Obser
Disregard for now. Carlin pointed out that this (unintentionally) stopped sending content length for head requests. While the RFC has content length optional (according to Carlin, didn't have time to check myself) we probably shouldn't just change behavior On September 6, 2018 6:39:18 PM

umidi(4) jack count

2018-09-06 Thread Michael Mikonos
Hello, The umidi(4) driver has three different endpoint allocation functions, which are called by alloc_all_endpoints(). The initial jack count can be moved here because it is zero no matter which allocation function is used. Also when we eventually free the jacks the count can be reset. Does

Re: httpd: block return with a contentless status

2018-09-06 Thread Florian Obser
On Fri, Sep 07, 2018 at 03:08:53AM +1200, Carlin Bingham wrote: > If httpd is configured to do "block return" with a 1xx or 204 status, it > sends a response with a Content-Length header and a body, which per RFC > 7230 it must not. > > The use case for this is a webapp which wants the webserver

httpd: block return with a contentless status

2018-09-06 Thread Carlin Bingham
If httpd is configured to do "block return" with a 1xx or 204 status, it sends a response with a Content-Length header and a body, which per RFC 7230 it must not. The use case for this is a webapp which wants the webserver itself to be configured to return a 204 response for certain requests. I'm

Re: umidi(4) alloc_all_endpoints_fixed_ep()

2018-09-06 Thread Martin Pieuchot
On 06/09/18(Thu) 23:01, Michael Mikonos wrote: > Hello, > > In the umidi(4) driver the function alloc_all_endpoints_fixed_ep() > returns USBD_NOMEM if mallocarray() fails, but the return value is > always USBD_INVAL when 'goto error' happens. OK? Note that it'd be better to *not* use

umidi(4) alloc_all_endpoints_fixed_ep()

2018-09-06 Thread Michael Mikonos
Hello, In the umidi(4) driver the function alloc_all_endpoints_fixed_ep() returns USBD_NOMEM if mallocarray() fails, but the return value is always USBD_INVAL when 'goto error' happens. OK? - Michael Index: umidi.c === RCS file:

bgpd, fast as number lookups using as-set

2018-09-06 Thread Claudio Jeker
This diff implements as-set. Similar to prefix-set this allows to reduce large lists of AS numbers to a single set. To define an as-set: as-set "AS_SET_AS_PCH" { 27 42 187 297 715 3856 10886 11893 13202 16327 16668 19281 20539 21312 21556 24999 25505 27678 32978 32979 35160 38052

Re: [patch] Fix closing socket twice bug in netcat program

2018-09-06 Thread Nan Xiao
Hi bluhm, Very sorry for my remiss! Updated, thanks! Index: netcat.c === RCS file: /cvs/src/usr.bin/nc/netcat.c,v retrieving revision 1.192 diff -u -p -r1.192 netcat.c --- netcat.c10 Aug 2018 17:15:22 - 1.192 +++

Re: [patch] Fix closing socket twice bug in netcat program

2018-09-06 Thread Alexander Bluhm
On Thu, Sep 06, 2018 at 06:27:15PM +0800, Nan Xiao wrote: > @@ -564,8 +564,11 @@ main(int argc, char *argv[]) > } > /* Allow only one connection at a time, but stay alive. */ > for (;;) { > - if (family != AF_UNIX) > +

Re: [patch] Fix closing socket twice bug in netcat program

2018-09-06 Thread Nan Xiao
Hi bluhm, Thanks for your reply! I think your method is better, and I update the patch: Index: netcat.c === RCS file: /cvs/src/usr.bin/nc/netcat.c,v retrieving revision 1.192 diff -u -p -r1.192 netcat.c --- netcat.c10 Aug 2018

Re: Mention errno in printf(3) man

2018-09-06 Thread Otto Moerbeek
On Wed, Sep 05, 2018 at 12:01:59PM -0700, ge...@geoffhill.org wrote: > Right now the printf(3) family of manpages make no reference to errno. > Glancing at __vfprintf, it appears that most of the erroneous paths do > set errno. Most, but not all. Stating it will set errno in all error cases is