Re: prevent bgpd from starting when control socket already used

2018-11-18 Thread Remi Locherer
Hi, from the discussion I understand nobody rejects the functionality. To ease the review here again the diff (with incorporated feedback from anton@ (redundant parens)). Any comments or OKs? Remi cvs diff: Diffing . Index: bgpd.c ==

uticom(4): last driver setting config

2018-11-18 Thread Martin Pieuchot
Here's another diff to get rid of a driver attaching to a device in unconfigured state. I'd like to convert them all to enforce that a USB device can only be matched if the stack already managed to set its configuration. I'm looking for tests and oks. Index: uticom.c

ubsa(4): don't set the config in match()

2018-11-18 Thread Martin Pieuchot
Instead of setting the configuration in the *match() routine let the stack do it for us. This operation can fail, so it's better to not attach any driver if something bad happens. This change is similar to what I did with the rest of the drivers some years ago when I fuzzed the stack. I'm lookin

kue(4): don't set the config in match()

2018-11-18 Thread Martin Pieuchot
Instead of setting the configuration in the *match() routine let the stack do it for us. This operation can fail, so it's better to not attach any driver if something bad happens. This change is similar to what I did with the rest of the drivers some years ago when I fuzzed the stack. I'm lookin

makemap.8 patch

2018-11-18 Thread Edgar Pettijohn III
Use new syntax. Index: makemap.8 === RCS file: /cvs/src/usr.sbin/smtpd/makemap.8,v retrieving revision 1.29 diff -u -p -u -r1.29 makemap.8 --- makemap.8    13 Feb 2016 08:53:18 -    1.29 +++ makemap.8    18 Nov 2018 14:29:33 -0

Re: 6.4 openBGPD Segfault caused by filters referencing undeclared prefix-set

2018-11-18 Thread Tom Smyth
Hello Stuart Thanks for the helpful advice on giving a better crash report i will do that going forward... On Sun 18 Nov 2018, 10:50 Stuart Henderson On 2018/11/18 08:58, Tom Smyth wrote: > > I have attached the coredump > > Generally the coredump by itself isn't that useful to others as it > ne

Re: 6.4 openBGPD Segfault caused by filters referencing undeclared prefix-set

2018-11-18 Thread Stuart Henderson
On 2018/11/18 08:58, Tom Smyth wrote: > I have attached the coredump Generally the coredump by itself isn't that useful to others as it needs the right binary to go with it, a backtrace is usually better: gdb /usr/sbin/bgpd /path/to/bgpd.core bt For reference, in some cases multiple processes wi

Re: bktr(4): remove useless assignment

2018-11-18 Thread Frederic Cambus
On Sat, Nov 17, 2018 at 04:36:49PM -0700, Theo de Raadt wrote: > Why not delete the 2nd line? > > I mean isn't it obvious? I'd expect some archeology to figure > out how this bug got introduced, rather than a diff which you > obviously don't know the result of. Fair enough, I realize it indeed l

Re: 6.4 openBGPD Segfault caused by filters referencing undeclared prefix-set

2018-11-18 Thread Claudio Jeker
On Sun, Nov 18, 2018 at 09:01:06AM +, Tom Smyth wrote: > just to confim > im running 6.4 GENERIC.MP#364 amd64 > On Sun, 18 Nov 2018 at 08:58, Tom Smyth wrote: > > > > Hello, > > I was configuring an openbsd 6.4 bgpd router using the > > /etc/examples/bgpd.conf as a template > > > > If you comm

Re: 6.4 openBGPD Segfault caused by filters referencing undeclared prefix-set

2018-11-18 Thread Claudio Jeker
On Sun, Nov 18, 2018 at 10:30:32AM +0100, Florian Obser wrote: > diff --git parse.y parse.y > index 7b7ce5388c0..1aa2aabc28c 100644 > --- parse.y > +++ parse.y > @@ -879,7 +879,7 @@ network : NETWORK prefix filter_set { > struct network *n; >

Re: 6.4 openBGPD Segfault caused by filters referencing undeclared prefix-set

2018-11-18 Thread Florian Obser
diff --git parse.y parse.y index 7b7ce5388c0..1aa2aabc28c 100644 --- parse.y +++ parse.y @@ -879,7 +879,7 @@ network : NETWORK prefix filter_set { struct network *n; if ((ps = find_prefixset($3, &conf->prefixsets))

Re: 6.4 openBGPD Segfault caused by filters referencing undeclared prefix-set

2018-11-18 Thread Tom Smyth
just to confim im running 6.4 GENERIC.MP#364 amd64 On Sun, 18 Nov 2018 at 08:58, Tom Smyth wrote: > > Hello, > I was configuring an openbsd 6.4 bgpd router using the > /etc/examples/bgpd.conf as a template > > If you comment out the prefix-set mynetworks > # list of networks that may be originate