Re: apmd: -t: use strtonum()

2018-11-30 Thread Martijn van Duren
On 12/1/18 8:34 AM, Theo Buehler wrote: > On Sat, Dec 01, 2018 at 08:01:00AM +0100, Martijn van Duren wrote: >> On 12/1/18 1:44 AM, Klemens Nanni wrote: > >>> # ./obj/apmd -dt -1 >>> apmd: too small seconds: -1 >>> # ./obj/apmd -dt 0 >>> apmd: too small seconds: 0 > > This looks

Re: apmd: -t: use strtonum()

2018-11-30 Thread Theo Buehler
On Sat, Dec 01, 2018 at 08:01:00AM +0100, Martijn van Duren wrote: > On 12/1/18 1:44 AM, Klemens Nanni wrote: > > # ./obj/apmd -dt -1 > > apmd: too small seconds: -1 > > # ./obj/apmd -dt 0 > > apmd: too small seconds: 0 This looks odd, seconds aren't too big or too small. > If

Re: apmd: -t: use strtonum()

2018-11-30 Thread Martijn van Duren
On 12/1/18 1:44 AM, Klemens Nanni wrote: > Base 10 suffices, negative numbers should be invalid (not converted) and > zero not treated specially: > > # apmd -dt -1 > apmd: kevent loop: Invalid argument > # apmd -dt 0 > usage: apmd [-AadHLs] [-f devname] [-S sockname]

Fwd: uvm_fault: ip_ctloutput

2018-11-30 Thread Greg Steuck
The C reproducer panics the machine like a charm. Requires root. https://syzkaller.appspot.com/x/repro.c?x=117e573340 -- Forwarded message - From: syzbot Date: Fri, Nov 30, 2018 at 7:58 PM Subject: Re: uvm_fault: ip_ctloutput To: syzbot has found a reproducer for the

apmd: -t: use strtonum()

2018-11-30 Thread Klemens Nanni
Base 10 suffices, negative numbers should be invalid (not converted) and zero not treated specially: # apmd -dt -1 apmd: kevent loop: Invalid argument # apmd -dt 0 usage: apmd [-AadHLs] [-f devname] [-S sockname] [-t seconds] [-Z percent] [-z percent] #

Re: pvclock(4)

2018-11-30 Thread johnw
johnw 於 2018-11-29 17:38 寫到: Reyk Floeter 於 2018-11-29 14:09 寫到: Do you have a full dmesg for me? Yes, attached dmesg.log, thanks. Hi, after disable pvclock, it can boot with new kernel again, thanks. -- Key fingerprint: CDB3 6C62 254B C088 1E5D DD32 182C 97DB CF2C 80AC OpenBSD

Re: apmd debug

2018-11-30 Thread Klemens Nanni
On Fri, Nov 30, 2018 at 01:24:27PM -0500, Ted Unangst wrote: > Developers who shall remain anonymous were confused by the behavior of apmd -d > because the behavior of apmd -d is confusing. It doesn't do anything like any > other daemon in the system when running with -d. :-) > This introduces a

Re: free(9) sizes for sysv_msg

2018-11-30 Thread Alexandre Ratchov
On Fri, Nov 30, 2018 at 04:02:07PM -0200, Martin Pieuchot wrote: > On 29/11/18(Thu) 22:42, Alexandre Ratchov wrote: > > On Thu, Nov 29, 2018 at 04:51:19PM -0200, Martin Pieuchot wrote: > > > Trivial one, ok? > > > > > > Index: kern/sysv_msg.c > > >

Re: Add new PCI product IDs

2018-11-30 Thread Mike Larkin
On Wed, Nov 07, 2018 at 11:33:55AM -0800, Peter Ezetta wrote: > Ping > Thanks, committed. I changed the first name a bit to remain more inline with our current naming scheme. -ml > On Thu, Oct 25, 2018 at 2:46 PM Peter Ezetta wrote: > > > Hello, > > > > Diff below adds product IDs for the

apmd debug

2018-11-30 Thread Ted Unangst
Developers who shall remain anonymous were confused by the behavior of apmd -d because the behavior of apmd -d is confusing. It doesn't do anything like any other daemon in the system when running with -d. This introduces a logmsg function to replace syslog, which will either syslog or printf

Re: fuse_opt.3 patch

2018-11-30 Thread Martin Pieuchot
On 30/11/18(Fri) 07:07, Edgar Pettijohn wrote: > Here is a diff to remove the dubious example and fix one gramatical issue. Thanks. Don't forget to use "mandoc -Tlint" to spot potentials errors after a change. In this case you forgot to remove an ".Ed". Keep the good work. All fuse manuals

Re: free(9) sizes for sysv_msg

2018-11-30 Thread Martin Pieuchot
On 29/11/18(Thu) 22:42, Alexandre Ratchov wrote: > On Thu, Nov 29, 2018 at 04:51:19PM -0200, Martin Pieuchot wrote: > > Trivial one, ok? > > > > Index: kern/sysv_msg.c > > === > > RCS file: /cvs/src/sys/kern/sysv_msg.c,v > >

Re: split ether_output up into resolution, encapsulation, and output

2018-11-30 Thread Claudio Jeker
On Fri, Nov 30, 2018 at 02:04:40PM -0200, Martin Pieuchot wrote: > On 30/11/18(Fri) 12:35, David Gwynne wrote: > > On Fri, Nov 30, 2018 at 12:21:11PM +1000, David Gwynne wrote: > > > i have a plan to allow virtual interfaces (eg, vlan, etherip, etc) to > > > provide their own output functions so

Re: split ether_output up into resolution, encapsulation, and output

2018-11-30 Thread Martin Pieuchot
On 30/11/18(Fri) 12:35, David Gwynne wrote: > On Fri, Nov 30, 2018 at 12:21:11PM +1000, David Gwynne wrote: > > i have a plan to allow virtual interfaces (eg, vlan, etherip, etc) to > > provide their own output functions so they can bypass the ifq machinery > > and push the packet onto the

Re: athn(4) hostap: mem leak

2018-11-30 Thread Alexandre Ratchov
On Fri, Nov 30, 2018 at 01:49:56PM +0100, Benjamin Baier wrote: > Hi > > There is a leak of *arg in > dev/usb/if_athn_usb.c:athn_usb_newauth() line 1263 > since Rev. 1.49 > Because athn_usb_do_async() memcpy's the argument anyway. > > Found with llvm/scan-build. > > Instead of adding free(arg)

Re: httpd server configuration evaluation bug

2018-11-30 Thread Tracey Emery
On Fri, Nov 30, 2018 at 10:16:45AM +0100, Florian Obser wrote: > On Fri, Oct 26, 2018 at 03:08:11PM -0600, Tracey Emery wrote: > > On Mon, Jul 30, 2018 at 10:24:03AM -0600, Base Pr1me wrote: > > > Sorry, this time with the correct diff. > > > > > > On 7/25/18 4:15 PM, Base Pr1me wrote: > > > >

Re: athn(4) hostap: mem leak

2018-11-30 Thread Stefan Sperling
On Fri, Nov 30, 2018 at 01:49:56PM +0100, Benjamin Baier wrote: > Hi > > There is a leak of *arg in > dev/usb/if_athn_usb.c:athn_usb_newauth() line 1263 > since Rev. 1.49 > Because athn_usb_do_async() memcpy's the argument anyway. > > Found with llvm/scan-build. > > Instead of adding free(arg)

Re: fuse_opt.3 patch

2018-11-30 Thread Edgar Pettijohn
Here is a diff to remove the dubious example and fix one gramatical issue. Index: fuse_opt.3 === RCS file: /cvs/src/lib/libfuse/fuse_opt.3,v retrieving revision 1.2 diff -u -p -u -r1.2 fuse_opt.3 --- fuse_opt.3 8 Jul 2018 06:17:10

athn(4) hostap: mem leak

2018-11-30 Thread Benjamin Baier
Hi There is a leak of *arg in dev/usb/if_athn_usb.c:athn_usb_newauth() line 1263 since Rev. 1.49 Because athn_usb_do_async() memcpy's the argument anyway. Found with llvm/scan-build. Instead of adding free(arg) I opted to make this function more like the other ones which call

Re: httpd server configuration evaluation bug

2018-11-30 Thread Florian Obser
On Fri, Oct 26, 2018 at 03:08:11PM -0600, Tracey Emery wrote: > On Mon, Jul 30, 2018 at 10:24:03AM -0600, Base Pr1me wrote: > > Sorry, this time with the correct diff. > > > > On 7/25/18 4:15 PM, Base Pr1me wrote: > > > Hi, > > > > > > I discovered that the wrong server configuration is